On Mon, Mar 15, 2021 at 07:12:12PM +0100, Krzysztof Kozlowski wrote:
> Since interrupt handler is called with disabled local interrupts, there
> is no need to use the spinlock primitives disabling interrupts as well.
>
> Suggested-by: Andy Shevchenko
> Signed-off-by: Krzysztof Kozlowski
On Fri, Mar 19, 2021 at 12:09:34PM +0200, Andy Shevchenko wrote:
> On Fri, Mar 19, 2021 at 10:09 AM Johan Hovold wrote:
> > > I think it is almost always wrong to call spin_lock_irqsave in
> > > hardirq.
> >
> > Again, no. It's even been a requirement due to "threadirqs" in some
> > cases (e.g.
> > Samsung
> > > SOC ; open list:SERIAL DRIVERS
> > > ; Linux Kernel Mailing List
> > > ; Hector Martin ; Arnd
> > > Bergmann
> > > Subject: Re: [PATCH] tty: serial: samsung_tty: remove spinlock flags in
> > > interrupt handlers
> > >
gt; > Song Bao Hua (Barry Song)
> > Cc: Krzysztof Kozlowski ; Greg
> > Kroah-Hartman ; Jiri Slaby
> > ;
> > linux-arm Mailing List ; Linux Samsung
> > SOC ; open list:SERIAL DRIVERS
> > ; Linux Kernel Mailing List
> > ; Hector Martin ; Arnd
&g
ing List ; Linux Samsung
> SOC ; open list:SERIAL DRIVERS
> ; Linux Kernel Mailing List
> ; Hector Martin ; Arnd
> Bergmann
> Subject: Re: [PATCH] tty: serial: samsung_tty: remove spinlock flags in
> interrupt handlers
>
> On Tue, Mar 16, 2021 at 11:02 AM Johan Hovold w
On Tue, Mar 16, 2021 at 11:11:43AM +0100, Krzysztof Kozlowski wrote:
> On 16/03/2021 10:56, Johan Hovold wrote:
> > On Tue, Mar 16, 2021 at 10:47:53AM +0100, Krzysztof Kozlowski wrote:
> >> On 16/03/2021 10:02, Johan Hovold wrote:
> >>> On Mon, Mar 15, 2021 at 07:12:12PM +0100, Krzysztof Kozlowski
On 16/03/2021 10:56, Johan Hovold wrote:
> On Tue, Mar 16, 2021 at 10:47:53AM +0100, Krzysztof Kozlowski wrote:
>> On 16/03/2021 10:02, Johan Hovold wrote:
>>> On Mon, Mar 15, 2021 at 07:12:12PM +0100, Krzysztof Kozlowski wrote:
Since interrupt handler is called with disabled local
On Tue, Mar 16, 2021 at 10:47:53AM +0100, Krzysztof Kozlowski wrote:
> On 16/03/2021 10:02, Johan Hovold wrote:
> > On Mon, Mar 15, 2021 at 07:12:12PM +0100, Krzysztof Kozlowski wrote:
> >> Since interrupt handler is called with disabled local interrupts, there
> >> is no need to use the spinlock
On 16/03/2021 10:02, Johan Hovold wrote:
> On Mon, Mar 15, 2021 at 07:12:12PM +0100, Krzysztof Kozlowski wrote:
>> Since interrupt handler is called with disabled local interrupts, there
>> is no need to use the spinlock primitives disabling interrupts as well.
>
> This isn't generally true due
On Tue, Mar 16, 2021 at 11:02 AM Johan Hovold wrote:
>
> On Mon, Mar 15, 2021 at 07:12:12PM +0100, Krzysztof Kozlowski wrote:
> > Since interrupt handler is called with disabled local interrupts, there
> > is no need to use the spinlock primitives disabling interrupts as well.
>
> This isn't
On Mon, Mar 15, 2021 at 07:12:12PM +0100, Krzysztof Kozlowski wrote:
> Since interrupt handler is called with disabled local interrupts, there
> is no need to use the spinlock primitives disabling interrupts as well.
This isn't generally true due to "threadirqs" and that can lead to
deadlocks if
On Mon, Mar 15, 2021 at 8:12 PM Krzysztof Kozlowski
wrote:
>
> Since interrupt handler is called with disabled local interrupts, there
> is no need to use the spinlock primitives disabling interrupts as well.
Thanks!
Reviewed-by: Andy Shevchenko
> Suggested-by: Andy Shevchenko
>
Since interrupt handler is called with disabled local interrupts, there
is no need to use the spinlock primitives disabling interrupts as well.
Suggested-by: Andy Shevchenko
Signed-off-by: Krzysztof Kozlowski
---
drivers/tty/serial/samsung_tty.c | 15 ++-
1 file changed, 6
13 matches
Mail list logo
