On Wed, 17 Oct 2007, Roel Kluin wrote:
> if (oclose >= abs(obaud - baud_table[i])) {
>
> should work as well
Hmm, I am not sure if it is clearer or produces better code, but send a
patch -- I will not object.
Maciej
-
To unsubscribe from this list: send the line "unsubscribe
On Wed, 17 Oct 2007, Alan Cox wrote:
> > The tty_termios_encode_baud_rate() function as defined by tty_ioctl.c has
> > a problem with the baud_table within. The comparison operators are
> > reversed and as a result this table's entries never match and BOTHER is
> > always used.
>
> Oops. I
On Wed, 17 Oct 2007, Alan Cox wrote:
The tty_termios_encode_baud_rate() function as defined by tty_ioctl.c has
a problem with the baud_table within. The comparison operators are
reversed and as a result this table's entries never match and BOTHER is
always used.
Oops. I thought
On Wed, 17 Oct 2007, Roel Kluin wrote:
if (oclose = abs(obaud - baud_table[i])) {
should work as well
Hmm, I am not sure if it is clearer or produces better code, but send a
patch -- I will not object.
Maciej
-
To unsubscribe from this list: send the line unsubscribe
On Tue, 16 Oct 2007 19:12:11 +0100 (BST)
"Maciej W. Rozycki" <[EMAIL PROTECTED]> wrote:
> The tty_termios_encode_baud_rate() function as defined by tty_ioctl.c has
> a problem with the baud_table within. The comparison operators are
> reversed and as a result this table's entries never match
On Tue, 16 Oct 2007 19:12:11 +0100 (BST)
Maciej W. Rozycki [EMAIL PROTECTED] wrote:
The tty_termios_encode_baud_rate() function as defined by tty_ioctl.c has
a problem with the baud_table within. The comparison operators are
reversed and as a result this table's entries never match and
Since you were sending a fix, possibly I shouldn't comment on this. If so
please disregard my
suggestion for a trivial cleanup.
Roel
Maciej W. Rozycki wrote:
> +void tty_termios_encode_baud_rate(struct ktermios *termios,
> + speed_t ibaud, speed_t obaud)
> {
>
The tty_termios_encode_baud_rate() function as defined by tty_ioctl.c has
a problem with the baud_table within. The comparison operators are
reversed and as a result this table's entries never match and BOTHER is
always used.
Additionally this function's prototype is not exported unlike the
The tty_termios_encode_baud_rate() function as defined by tty_ioctl.c has
a problem with the baud_table within. The comparison operators are
reversed and as a result this table's entries never match and BOTHER is
always used.
Additionally this function's prototype is not exported unlike the
Since you were sending a fix, possibly I shouldn't comment on this. If so
please disregard my
suggestion for a trivial cleanup.
Roel
Maciej W. Rozycki wrote:
+void tty_termios_encode_baud_rate(struct ktermios *termios,
+ speed_t ibaud, speed_t obaud)
{
10 matches
Mail list logo