Re: [PATCH] tulip: Poll link status more frequently for Comet chips

2014-06-22 Thread David Miller
From: Ondrej Zary Date: Sun, 22 Jun 2014 12:01:12 +0200 > It now takes up to 60 seconds to detect cable (un)plug on ADMtek Comet chips. > That's too slow and might cause people to think that it doesn't work at all. > > Poll link status every 2 seconds instead of 60 for ADMtek Comet chips. >

[PATCH] tulip: Poll link status more frequently for Comet chips

2014-06-22 Thread Ondrej Zary
It now takes up to 60 seconds to detect cable (un)plug on ADMtek Comet chips. That's too slow and might cause people to think that it doesn't work at all. Poll link status every 2 seconds instead of 60 for ADMtek Comet chips. That should be fast enough while not stressing the system too much.

[PATCH] tulip: Poll link status more frequently for Comet chips

2014-06-22 Thread Ondrej Zary
It now takes up to 60 seconds to detect cable (un)plug on ADMtek Comet chips. That's too slow and might cause people to think that it doesn't work at all. Poll link status every 2 seconds instead of 60 for ADMtek Comet chips. That should be fast enough while not stressing the system too much.

Re: [PATCH] tulip: Poll link status more frequently for Comet chips

2014-06-22 Thread David Miller
From: Ondrej Zary li...@rainbow-software.org Date: Sun, 22 Jun 2014 12:01:12 +0200 It now takes up to 60 seconds to detect cable (un)plug on ADMtek Comet chips. That's too slow and might cause people to think that it doesn't work at all. Poll link status every 2 seconds instead of 60 for

Re: [PATCH] tulip: Poll link status more frequently for Comet chips

2014-06-21 Thread David Miller
From: Grant Grundler Date: Sat, 21 Jun 2014 15:59:30 -0700 > Hi Ondrej, > > On Sat, Jun 21, 2014 at 1:29 PM, Ondrej Zary > wrote: >> Poll link status every 2 seconds instead of 60 for ADMtek Comet chips. > > Why use 2 seconds for the polling interval? > > I'm sure you have a good reason for

Re: [PATCH] tulip: Poll link status more frequently for Comet chips

2014-06-21 Thread Grant Grundler
Hi Ondrej, On Sat, Jun 21, 2014 at 1:29 PM, Ondrej Zary wrote: > Poll link status every 2 seconds instead of 60 for ADMtek Comet chips. Why use 2 seconds for the polling interval? I'm sure you have a good reason for this and it should be in the commit message or as a comment in the code. I

[PATCH] tulip: Poll link status more frequently for Comet chips

2014-06-21 Thread Ondrej Zary
Poll link status every 2 seconds instead of 60 for ADMtek Comet chips. Tested with AN983B. Signed-off-by: Ondrej Zary --- drivers/net/ethernet/dec/tulip/timer.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/dec/tulip/timer.c

[PATCH] tulip: Poll link status more frequently for Comet chips

2014-06-21 Thread Ondrej Zary
Poll link status every 2 seconds instead of 60 for ADMtek Comet chips. Tested with AN983B. Signed-off-by: Ondrej Zary li...@rainbow-software.org --- drivers/net/ethernet/dec/tulip/timer.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH] tulip: Poll link status more frequently for Comet chips

2014-06-21 Thread Grant Grundler
Hi Ondrej, On Sat, Jun 21, 2014 at 1:29 PM, Ondrej Zary li...@rainbow-software.org wrote: Poll link status every 2 seconds instead of 60 for ADMtek Comet chips. Why use 2 seconds for the polling interval? I'm sure you have a good reason for this and it should be in the commit message or as a

Re: [PATCH] tulip: Poll link status more frequently for Comet chips

2014-06-21 Thread David Miller
From: Grant Grundler grantgrund...@gmail.com Date: Sat, 21 Jun 2014 15:59:30 -0700 Hi Ondrej, On Sat, Jun 21, 2014 at 1:29 PM, Ondrej Zary li...@rainbow-software.org wrote: Poll link status every 2 seconds instead of 60 for ADMtek Comet chips. Why use 2 seconds for the polling interval?