Re: [PATCH] uacce: Add uacce_ctrl misc device

2021-01-22 Thread Greg Kroah-Hartman
On Fri, Jan 22, 2021 at 07:33:40PM +0800, Zhou Wang wrote: > >> +struct uacce_pin_address { > >> + unsigned long addr; > >> + unsigned long size; > > > > These are not valid ioctl structure members for crossing the user/kernel > > boundry. Please make them work properly (i.e. use __u64 and frie

Re: [PATCH] uacce: Add uacce_ctrl misc device

2021-01-22 Thread Zhou Wang
On 2021/1/21 17:44, Greg Kroah-Hartman wrote: > On Thu, Jan 21, 2021 at 05:09:14PM +0800, Zhou Wang wrote: >> When IO page fault happens, DMA performance will be affected. Pin user page >> can avoid IO page fault, this patch introduces a new char device named >> /dev/uacce_ctrl to help to maintain

Re: [PATCH] uacce: Add uacce_ctrl misc device

2021-01-21 Thread kernel test robot
Hi Zhou, I love your patch! Yet something to improve: [auto build test ERROR on char-misc/char-misc-testing] [also build test ERROR on soc/for-next linux/master linus/master v5.11-rc4 next-20210121] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch

Re: [PATCH] uacce: Add uacce_ctrl misc device

2021-01-21 Thread kernel test robot
Hi Zhou, I love your patch! Perhaps something to improve: [auto build test WARNING on char-misc/char-misc-testing] [also build test WARNING on soc/for-next linux/master linus/master v5.11-rc4 next-20210121] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitti

Re: [PATCH] uacce: Add uacce_ctrl misc device

2021-01-21 Thread Greg Kroah-Hartman
> Cc: Wangzhou (B) ; Zhangfei Gao > > ; Arnd Bergmann ; > > linux-accelerat...@lists.ozlabs.org; linux-kernel@vger.kernel.org; > > chensihang (A) > > Subject: Re: [PATCH] uacce: Add uacce_ctrl misc device > > > > On Thu, Jan 21, 2021 at 10:18:24AM +, So

Re: [PATCH] uacce: Add uacce_ctrl misc device

2021-01-21 Thread Greg Kroah-Hartman
gfei Gao ; Arnd Bergmann ; > > linux-accelerat...@lists.ozlabs.org; linux-kernel@vger.kernel.org; > > chensihang (A) > > Subject: Re: [PATCH] uacce: Add uacce_ctrl misc device > > > > On Thu, Jan 21, 2021 at 05:09:14PM +0800, Zhou Wang wrote: > > > When IO

RE: [PATCH] uacce: Add uacce_ctrl misc device

2021-01-21 Thread Song Bao Hua (Barry Song)
ernel@vger.kernel.org; > chensihang (A) > Subject: Re: [PATCH] uacce: Add uacce_ctrl misc device > > On Thu, Jan 21, 2021 at 10:18:24AM +, Song Bao Hua (Barry Song) wrote: > > > > > > > -Original Message- > > > From: Greg Kroah-Hartman [mailto:gre...

Re: [PATCH] uacce: Add uacce_ctrl misc device

2021-01-21 Thread kernel test robot
Hi Zhou, I love your patch! Perhaps something to improve: [auto build test WARNING on char-misc/char-misc-testing] [also build test WARNING on soc/for-next linux/master linus/master v5.11-rc4 next-20210120] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitti

Re: [PATCH] uacce: Add uacce_ctrl misc device

2021-01-21 Thread kernel test robot
Hi Zhou, I love your patch! Perhaps something to improve: [auto build test WARNING on char-misc/char-misc-testing] [also build test WARNING on soc/for-next linux/master linus/master v5.11-rc4 next-20210120] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitti

RE: [PATCH] uacce: Add uacce_ctrl misc device

2021-01-21 Thread Song Bao Hua (Barry Song)
ng (A) > Subject: Re: [PATCH] uacce: Add uacce_ctrl misc device > > On Thu, Jan 21, 2021 at 05:09:14PM +0800, Zhou Wang wrote: > > When IO page fault happens, DMA performance will be affected. Pin user page > > can avoid IO page fault, this patch introduces a new char device nam

Re: [PATCH] uacce: Add uacce_ctrl misc device

2021-01-21 Thread Greg Kroah-Hartman
On Thu, Jan 21, 2021 at 05:09:14PM +0800, Zhou Wang wrote: > When IO page fault happens, DMA performance will be affected. Pin user page > can avoid IO page fault, this patch introduces a new char device named > /dev/uacce_ctrl to help to maintain pin/unpin pages. User space can do > pin/unpin page

Re: [PATCH] uacce: Add uacce_ctrl misc device

2021-01-21 Thread Greg Kroah-Hartman
On Thu, Jan 21, 2021 at 05:09:14PM +0800, Zhou Wang wrote: > When IO page fault happens, DMA performance will be affected. Pin user page > can avoid IO page fault, this patch introduces a new char device named > /dev/uacce_ctrl to help to maintain pin/unpin pages. User space can do > pin/unpin page

[PATCH] uacce: Add uacce_ctrl misc device

2021-01-21 Thread Zhou Wang
When IO page fault happens, DMA performance will be affected. Pin user page can avoid IO page fault, this patch introduces a new char device named /dev/uacce_ctrl to help to maintain pin/unpin pages. User space can do pin/unpin pages by ioctls of an open file of /dev/uacce_ctrl, all pinned pages un