Re: [PATCH] ubi: fix sparse errors in ubi.h

2008-02-14 Thread Joe Perches
On Thu, 2008-02-14 at 23:56 +, Ben Dooks wrote: > On Thu, Feb 14, 2008 at 01:53:15PM -0800, Harvey Harrison wrote: > > In C, signed 1-bit bitfields can only take the values 0 and -1, only > > 0 and 1 are ever assigned in current code. Make them unsigned > > bitfields. > > > > Fixes the (repea

Re: [PATCH] ubi: fix sparse errors in ubi.h

2008-02-14 Thread Adrian Bunk
On Thu, Feb 14, 2008 at 01:53:15PM -0800, Harvey Harrison wrote: > In C, signed 1-bit bitfields can only take the values 0 and -1, only > 0 and 1 are ever assigned in current code. Make them unsigned > bitfields. > > Fixes the (repeated) sparse errors: > drivers/mtd/ubi/ubi.h:220:15: error: dubio

Re: [PATCH] ubi: fix sparse errors in ubi.h

2008-02-14 Thread Ben Dooks
On Thu, Feb 14, 2008 at 01:53:15PM -0800, Harvey Harrison wrote: > In C, signed 1-bit bitfields can only take the values 0 and -1, only > 0 and 1 are ever assigned in current code. Make them unsigned > bitfields. > > Fixes the (repeated) sparse errors: > drivers/mtd/ubi/ubi.h:220:15: error: dubio

[PATCH] ubi: fix sparse errors in ubi.h

2008-02-14 Thread Harvey Harrison
In C, signed 1-bit bitfields can only take the values 0 and -1, only 0 and 1 are ever assigned in current code. Make them unsigned bitfields. Fixes the (repeated) sparse errors: drivers/mtd/ubi/ubi.h:220:15: error: dubious one-bit signed bitfield drivers/mtd/ubi/ubi.h:221:17: error: dubious one-b