Re: [PATCH] ubifs: Fix a potential space leak problem while linking tmpfile

2020-07-12 Thread Zhihao Cheng
在 2020/7/11 14:37, Zhihao Cheng 写道: 在 2020/7/7 20:47, Richard Weinberger 写道: - Ursprüngliche Mail - Perhaps I misunderstood what commit 32fe905c17f001 ("ubifs: Fix O_TMPFILE corner case in ubifs_link()") wanted to fix. I think orphan area is used to remind filesystem don't forget to

Re: [PATCH] ubifs: Fix a potential space leak problem while linking tmpfile

2020-07-11 Thread Zhihao Cheng
在 2020/7/11 14:37, Zhihao Cheng 写道: 在 2020/7/7 20:47, Richard Weinberger 写道: - Ursprüngliche Mail - Perhaps I misunderstood what commit 32fe905c17f001 ("ubifs: Fix O_TMPFILE corner case in ubifs_link()") wanted to fix. I think orphan area is used to remind filesystem don't forget to

Re: [PATCH] ubifs: Fix a potential space leak problem while linking tmpfile

2020-07-11 Thread Zhihao Cheng
在 2020/7/7 20:47, Richard Weinberger 写道: - Ursprüngliche Mail - Perhaps I misunderstood what commit 32fe905c17f001 ("ubifs: Fix O_TMPFILE corner case in ubifs_link()") wanted to fix. I think orphan area is used to remind filesystem don't forget to delete inodes (whose nlink is 0) in

Re: [PATCH] ubifs: Fix a potential space leak problem while linking tmpfile

2020-07-07 Thread Richard Weinberger
- Ursprüngliche Mail - >>> Perhaps I misunderstood what commit 32fe905c17f001 ("ubifs: Fix >>> O_TMPFILE corner case in ubifs_link()") wanted to fix. >>> I think orphan area is used to remind filesystem don't forget to delete >>> inodes (whose nlink is 0) in next unclean rebooting.

Re: [PATCH] ubifs: Fix a potential space leak problem while linking tmpfile

2020-07-07 Thread Zhihao Cheng
在 2020/7/7 20:09, Richard Weinberger 写道: - Ursprüngliche Mail - Perhaps I misunderstood what commit 32fe905c17f001 ("ubifs: Fix O_TMPFILE corner case in ubifs_link()") wanted to fix. I think orphan area is used to remind filesystem don't forget to delete inodes (whose nlink is 0) in

Re: [PATCH] ubifs: Fix a potential space leak problem while linking tmpfile

2020-07-07 Thread Richard Weinberger
- Ursprüngliche Mail - > Perhaps I misunderstood what commit 32fe905c17f001 ("ubifs: Fix > O_TMPFILE corner case in ubifs_link()") wanted to fix. > I think orphan area is used to remind filesystem don't forget to delete > inodes (whose nlink is 0) in next unclean rebooting. Generally, the

Re: [PATCH] ubifs: Fix a potential space leak problem while linking tmpfile

2020-07-07 Thread Zhihao Cheng
在 2020/7/7 19:26, Richard Weinberger 写道: On Wed, Jul 1, 2020 at 1:28 PM Zhihao Cheng wrote: There is a potential space leak problem while linking tmpfile, in which case, inode node (with nlink=0) is valid in tnc (on flash), which leads to space leak. Meanwhile, the corresponding data nodes

Re: [PATCH] ubifs: Fix a potential space leak problem while linking tmpfile

2020-07-07 Thread Richard Weinberger
On Wed, Jul 1, 2020 at 1:28 PM Zhihao Cheng wrote: > > There is a potential space leak problem while linking tmpfile, in which > case, inode node (with nlink=0) is valid in tnc (on flash), which leads > to space leak. Meanwhile, the corresponding data nodes won't be released > from tnc. For

[PATCH] ubifs: Fix a potential space leak problem while linking tmpfile

2020-07-01 Thread Zhihao Cheng
There is a potential space leak problem while linking tmpfile, in which case, inode node (with nlink=0) is valid in tnc (on flash), which leads to space leak. Meanwhile, the corresponding data nodes won't be released from tnc. For example, (A reproducer can be found in Link): $ mount UBIFS

[PATCH] ubifs: Fix a potential space leak problem while linking tmpfile

2020-07-01 Thread Zhihao Cheng
There is a potential space leak problem while linking tmpfile, in which case, inode node (with nlink=0) is valid in tnc (on flash), which leads to space leak. Meanwhile, the corresponding data nodes won't be released from tnc. For example, (A reproducer can be found in Link): $ mount UBIFS