Re: [PATCH] ubsan: Require GCC-8+ or Clang to use UBSAN

2021-02-09 Thread Kees Cook
On Wed, Feb 10, 2021 at 02:17:57AM +0300, Andrey Rybainin wrote: > Subject: ubsan: Require GCC-8+ or Clang to use UBSAN > > Just like how we require GCC-8.2 for KASAN due to compiler bugs, require > a sane version of GCC for UBSAN. > > Specifically, before GCC-8 UBSAN

Re: [PATCH] ubsan: Require GCC-8+ or Clang to use UBSAN

2021-02-09 Thread Andrey Rybainin
On 2/9/21 9:24 PM, Josh Poimboeuf wrote: > On Mon, Jan 18, 2021 at 11:53:37AM -0600, Josh Poimboeuf wrote: >> On Thu, Jan 14, 2021 at 02:09:28PM +0300, Andrey Ryabinin wrote: >>> >>> >>> On 1/14/21 1:59 PM, Peter Zijlstra wrote: On Mon, Jan 04, 2021 at 04:13:17PM +0100, Peter Zijlstra

Re: [PATCH] ubsan: Require GCC-8+ or Clang to use UBSAN

2021-02-09 Thread Josh Poimboeuf
On Mon, Jan 18, 2021 at 11:53:37AM -0600, Josh Poimboeuf wrote: > On Thu, Jan 14, 2021 at 02:09:28PM +0300, Andrey Ryabinin wrote: > > > > > > On 1/14/21 1:59 PM, Peter Zijlstra wrote: > > > On Mon, Jan 04, 2021 at 04:13:17PM +0100, Peter Zijlstra wrote: > > >> On Tue, Dec 22, 2020 at 11:04:54PM

Re: [PATCH] ubsan: Require GCC-8+ or Clang to use UBSAN

2021-01-18 Thread Josh Poimboeuf
On Thu, Jan 14, 2021 at 02:09:28PM +0300, Andrey Ryabinin wrote: > > > On 1/14/21 1:59 PM, Peter Zijlstra wrote: > > On Mon, Jan 04, 2021 at 04:13:17PM +0100, Peter Zijlstra wrote: > >> On Tue, Dec 22, 2020 at 11:04:54PM -0600, Josh Poimboeuf wrote: > >>> GCC 7 has a known bug where UBSAN

Re: [PATCH] ubsan: Require GCC-8+ or Clang to use UBSAN

2021-01-14 Thread Andrey Ryabinin
On 1/14/21 1:59 PM, Peter Zijlstra wrote: > On Mon, Jan 04, 2021 at 04:13:17PM +0100, Peter Zijlstra wrote: >> On Tue, Dec 22, 2020 at 11:04:54PM -0600, Josh Poimboeuf wrote: >>> GCC 7 has a known bug where UBSAN ignores '-fwrapv' and generates false >>> signed-overflow-UB warnings. The type

[PATCH] ubsan: Require GCC-8+ or Clang to use UBSAN

2021-01-14 Thread Peter Zijlstra
On Mon, Jan 04, 2021 at 04:13:17PM +0100, Peter Zijlstra wrote: > On Tue, Dec 22, 2020 at 11:04:54PM -0600, Josh Poimboeuf wrote: > > GCC 7 has a known bug where UBSAN ignores '-fwrapv' and generates false > > signed-overflow-UB warnings. The type mismatch between 'i' and > > 'nr_segs' in