Re: [PATCH] udevadm-info: Don't access sysfs 'resource' files

2013-03-19 Thread Myron Stowe
On Tue, 2013-03-19 at 10:57 -0600, Myron Stowe wrote: > On Mon, 2013-03-18 at 12:59 -0600, Alex Williamson wrote: > > On Mon, 2013-03-18 at 19:25 +0100, Bjørn Mork wrote: > > > Alex Williamson wrote: > > > > > > >On Mon, 2013-03-18 at 18:20 +0100, Bjørn Mork wrote: > > > >> Alex Williamson

Re: [PATCH] udevadm-info: Don't access sysfs 'resource' files

2013-03-19 Thread Myron Stowe
On Mon, 2013-03-18 at 12:59 -0600, Alex Williamson wrote: > On Mon, 2013-03-18 at 19:25 +0100, Bjørn Mork wrote: > > Alex Williamson wrote: > > > > >On Mon, 2013-03-18 at 18:20 +0100, Bjørn Mork wrote: > > >> Alex Williamson writes: > > >> > > >> > At least for KVM the kernel fix is the

Re: [PATCH] udevadm-info: Don't access sysfs 'resource' files

2013-03-18 Thread Robert Hancock
On Mon, Mar 18, 2013 at 8:35 PM, Greg KH wrote: > On Mon, Mar 18, 2013 at 08:09:22PM -0600, Robert Hancock wrote: >> > Great, that's one possible solution, the other is just not creating the >> > files at all for known problem devices, right? >> >> I don't think one can reasonably enumerate all

Re: [PATCH] udevadm-info: Don't access sysfs 'resource' files

2013-03-18 Thread Greg KH
On Mon, Mar 18, 2013 at 08:09:22PM -0600, Robert Hancock wrote: > > Great, that's one possible solution, the other is just not creating the > > files at all for known problem devices, right? > > I don't think one can reasonably enumerate all problem devices. There > are probably countless devices

Re: [PATCH] udevadm-info: Don't access sysfs 'resource' files

2013-03-18 Thread Robert Hancock
On Mon, Mar 18, 2013 at 8:03 PM, Greg KH wrote: > On Mon, Mar 18, 2013 at 07:54:09PM -0600, Robert Hancock wrote: >> On 03/16/2013 07:03 PM, Greg KH wrote: >> >On Sat, Mar 16, 2013 at 05:50:53PM -0600, Myron Stowe wrote: >> >>On Sat, 2013-03-16 at 15:11 -0700, Greg KH wrote: >> >>>On Sat, Mar 16,

Re: [PATCH] udevadm-info: Don't access sysfs 'resource' files

2013-03-18 Thread Greg KH
On Mon, Mar 18, 2013 at 07:54:09PM -0600, Robert Hancock wrote: > On 03/16/2013 07:03 PM, Greg KH wrote: > >On Sat, Mar 16, 2013 at 05:50:53PM -0600, Myron Stowe wrote: > >>On Sat, 2013-03-16 at 15:11 -0700, Greg KH wrote: > >>>On Sat, Mar 16, 2013 at 03:35:19PM -0600, Myron Stowe wrote: >

Re: [PATCH] udevadm-info: Don't access sysfs 'resource' files

2013-03-18 Thread Robert Hancock
On 03/16/2013 07:03 PM, Greg KH wrote: On Sat, Mar 16, 2013 at 05:50:53PM -0600, Myron Stowe wrote: On Sat, 2013-03-16 at 15:11 -0700, Greg KH wrote: On Sat, Mar 16, 2013 at 03:35:19PM -0600, Myron Stowe wrote: Sysfs includes entries to memory that backs a PCI device's BARs, both I/O Port

Re: [PATCH] udevadm-info: Don't access sysfs 'resource' files

2013-03-18 Thread Alex Williamson
On Mon, 2013-03-18 at 19:25 +0100, Bjørn Mork wrote: > Alex Williamson wrote: > > >On Mon, 2013-03-18 at 18:20 +0100, Bjørn Mork wrote: > >> Alex Williamson writes: > >> > >> > At least for KVM the kernel fix is the addition of the vfio driver > >which > >> > gives us a non-sysfs way to do

Re: [PATCH] udevadm-info: Don't access sysfs 'resource' files

2013-03-18 Thread Robert Brown
On 03/18/13 13:54, Alex Williamson wrote: > On Mon, 2013-03-18 at 18:20 +0100, Bjørn Mork wrote: >> Alex Williamson writes: >> >>> At least for KVM the kernel fix is the addition of the vfio driver which >>> gives us a non-sysfs way to do this. If this problem was found a few >>> years later and

Re: [PATCH] udevadm-info: Don't access sysfs 'resource' files

2013-03-18 Thread Bjørn Mork
Alex Williamson wrote: >On Mon, 2013-03-18 at 18:20 +0100, Bjørn Mork wrote: >> Alex Williamson writes: >> >> > At least for KVM the kernel fix is the addition of the vfio driver >which >> > gives us a non-sysfs way to do this. If this problem was found a >few >> > years later and we were

Re: [PATCH] udevadm-info: Don't access sysfs 'resource' files

2013-03-18 Thread Alex Williamson
On Mon, 2013-03-18 at 18:20 +0100, Bjørn Mork wrote: > Alex Williamson writes: > > > At least for KVM the kernel fix is the addition of the vfio driver which > > gives us a non-sysfs way to do this. If this problem was found a few > > years later and we were ready to make the switch I'd support

Re: [PATCH] udevadm-info: Don't access sysfs 'resource' files

2013-03-18 Thread Bjørn Mork
Alex Williamson writes: > At least for KVM the kernel fix is the addition of the vfio driver which > gives us a non-sysfs way to do this. If this problem was found a few > years later and we were ready to make the switch I'd support just > removing these resource files. In the meantime we have

Re: [PATCH] udevadm-info: Don't access sysfs 'resource' files

2013-03-18 Thread Alex Williamson
On Mon, 2013-03-18 at 09:41 -0700, Greg KH wrote: > On Mon, Mar 18, 2013 at 10:24:40AM -0600, Alex Williamson wrote: > > On Sun, 2013-03-17 at 15:00 +0100, Kay Sievers wrote: > > > On Sun, Mar 17, 2013 at 2:38 PM, Alex Williamson > > > wrote: > > > > I'm assuming that the device only breaks

Re: [PATCH] udevadm-info: Don't access sysfs 'resource' files

2013-03-18 Thread Greg KH
On Mon, Mar 18, 2013 at 10:24:40AM -0600, Alex Williamson wrote: > On Sun, 2013-03-17 at 15:00 +0100, Kay Sievers wrote: > > On Sun, Mar 17, 2013 at 2:38 PM, Alex Williamson > > wrote: > > > I'm assuming that the device only breaks because udevadm is dumping the > > > full I/O port register space

Re: [PATCH] udevadm-info: Don't access sysfs 'resource' files

2013-03-18 Thread Alex Williamson
On Mon, 2013-03-18 at 10:50 -0400, Don Dutile wrote: > On 03/17/2013 06:28 PM, Alex Williamson wrote: > > On Sun, 2013-03-17 at 08:33 -0600, Myron Stowe wrote: > >> On Sun, 2013-03-17 at 07:38 -0600, Alex Williamson wrote: > >>> On Sat, 2013-03-16 at 22:36 -0700, Greg KH wrote: > On Sat, Mar

Re: [PATCH] udevadm-info: Don't access sysfs 'resource' files

2013-03-18 Thread Alex Williamson
On Sun, 2013-03-17 at 15:00 +0100, Kay Sievers wrote: > On Sun, Mar 17, 2013 at 2:38 PM, Alex Williamson > wrote: > > I'm assuming that the device only breaks because udevadm is dumping the > > full I/O port register space of the device and that if an actual driver > > was interacting with it

Re: [PATCH] udevadm-info: Don't access sysfs 'resource' files

2013-03-18 Thread Don Dutile
On 03/17/2013 06:28 PM, Alex Williamson wrote: On Sun, 2013-03-17 at 08:33 -0600, Myron Stowe wrote: On Sun, 2013-03-17 at 07:38 -0600, Alex Williamson wrote: On Sat, 2013-03-16 at 22:36 -0700, Greg KH wrote: On Sat, Mar 16, 2013 at 10:11:22PM -0600, Alex Williamson wrote: On Sat, 2013-03-16

Re: [PATCH] udevadm-info: Don't access sysfs 'resource' files

2013-03-17 Thread Alex Williamson
On Sun, 2013-03-17 at 08:33 -0600, Myron Stowe wrote: > On Sun, 2013-03-17 at 07:38 -0600, Alex Williamson wrote: > > On Sat, 2013-03-16 at 22:36 -0700, Greg KH wrote: > > > On Sat, Mar 16, 2013 at 10:11:22PM -0600, Alex Williamson wrote: > > > > On Sat, 2013-03-16 at 18:03 -0700, Greg KH wrote: >

Re: [PATCH] udevadm-info: Don't access sysfs 'resource' files

2013-03-17 Thread Kay Sievers
On Sun, Mar 17, 2013 at 3:36 PM, Myron Stowe wrote: > On Sun, 2013-03-17 at 15:29 +0100, Kay Sievers wrote: >> On Sun, Mar 17, 2013 at 3:20 PM, Myron Stowe wrote: >> > On Sun, 2013-03-17 at 15:00 +0100, Kay Sievers wrote: >> >> On Sun, Mar 17, 2013 at 2:38 PM, Alex Williamson >> >> wrote: >> >>

Re: [PATCH] udevadm-info: Don't access sysfs 'resource' files

2013-03-17 Thread Myron Stowe
On Sun, 2013-03-17 at 15:29 +0100, Kay Sievers wrote: > On Sun, Mar 17, 2013 at 3:20 PM, Myron Stowe wrote: > > On Sun, 2013-03-17 at 15:00 +0100, Kay Sievers wrote: > >> On Sun, Mar 17, 2013 at 2:38 PM, Alex Williamson > >> wrote: > >> > I'm assuming that the device only breaks because udevadm

Re: [PATCH] udevadm-info: Don't access sysfs 'resource' files

2013-03-17 Thread Myron Stowe
On Sun, 2013-03-17 at 07:38 -0600, Alex Williamson wrote: > On Sat, 2013-03-16 at 22:36 -0700, Greg KH wrote: > > On Sat, Mar 16, 2013 at 10:11:22PM -0600, Alex Williamson wrote: > > > On Sat, 2013-03-16 at 18:03 -0700, Greg KH wrote: > > > > On Sat, Mar 16, 2013 at 05:50:53PM -0600, Myron Stowe

Re: [PATCH] udevadm-info: Don't access sysfs 'resource' files

2013-03-17 Thread Kay Sievers
On Sun, Mar 17, 2013 at 3:20 PM, Myron Stowe wrote: > On Sun, 2013-03-17 at 15:00 +0100, Kay Sievers wrote: >> On Sun, Mar 17, 2013 at 2:38 PM, Alex Williamson >> wrote: >> > I'm assuming that the device only breaks because udevadm is dumping the >> > full I/O port register space of the device

Re: [PATCH] udevadm-info: Don't access sysfs 'resource' files

2013-03-17 Thread Myron Stowe
On Sun, 2013-03-17 at 15:00 +0100, Kay Sievers wrote: > On Sun, Mar 17, 2013 at 2:38 PM, Alex Williamson > wrote: > > I'm assuming that the device only breaks because udevadm is dumping the > > full I/O port register space of the device and that if an actual driver > > was interacting with it

Re: [PATCH] udevadm-info: Don't access sysfs 'resource' files

2013-03-17 Thread Myron Stowe
On Sat, 2013-03-16 at 18:03 -0700, Greg KH wrote: > On Sat, Mar 16, 2013 at 05:50:53PM -0600, Myron Stowe wrote: > > On Sat, 2013-03-16 at 15:11 -0700, Greg KH wrote: > > > On Sat, Mar 16, 2013 at 03:35:19PM -0600, Myron Stowe wrote: > > > > Sysfs includes entries to memory that backs a PCI

Re: [PATCH] udevadm-info: Don't access sysfs 'resource' files

2013-03-17 Thread Kay Sievers
On Sun, Mar 17, 2013 at 2:38 PM, Alex Williamson wrote: > I'm assuming that the device only breaks because udevadm is dumping the > full I/O port register space of the device and that if an actual driver > was interacting with it through this interface that it would work. Who > knows how many

Re: [PATCH] udevadm-info: Don't access sysfs 'resource' files

2013-03-17 Thread Alex Williamson
On Sat, 2013-03-16 at 22:36 -0700, Greg KH wrote: > On Sat, Mar 16, 2013 at 10:11:22PM -0600, Alex Williamson wrote: > > On Sat, 2013-03-16 at 18:03 -0700, Greg KH wrote: > > > On Sat, Mar 16, 2013 at 05:50:53PM -0600, Myron Stowe wrote: > > > > On Sat, 2013-03-16 at 15:11 -0700, Greg KH wrote: >

Re: [PATCH] udevadm-info: Don't access sysfs 'resource' files

2013-03-16 Thread Greg KH
On Sat, Mar 16, 2013 at 10:11:22PM -0600, Alex Williamson wrote: > On Sat, 2013-03-16 at 18:03 -0700, Greg KH wrote: > > On Sat, Mar 16, 2013 at 05:50:53PM -0600, Myron Stowe wrote: > > > On Sat, 2013-03-16 at 15:11 -0700, Greg KH wrote: > > > > On Sat, Mar 16, 2013 at 03:35:19PM -0600, Myron

Re: [PATCH] udevadm-info: Don't access sysfs 'resource' files

2013-03-16 Thread Alex Williamson
On Sat, 2013-03-16 at 18:03 -0700, Greg KH wrote: > On Sat, Mar 16, 2013 at 05:50:53PM -0600, Myron Stowe wrote: > > On Sat, 2013-03-16 at 15:11 -0700, Greg KH wrote: > > > On Sat, Mar 16, 2013 at 03:35:19PM -0600, Myron Stowe wrote: > > > > Sysfs includes entries to memory that backs a PCI

Re: [PATCH] udevadm-info: Don't access sysfs 'resource' files

2013-03-16 Thread Greg KH
On Sat, Mar 16, 2013 at 05:50:53PM -0600, Myron Stowe wrote: > On Sat, 2013-03-16 at 15:11 -0700, Greg KH wrote: > > On Sat, Mar 16, 2013 at 03:35:19PM -0600, Myron Stowe wrote: > > > Sysfs includes entries to memory that backs a PCI device's BARs, both I/O > > > Port space and MMIO. This memory

Re: [PATCH] udevadm-info: Don't access sysfs 'resource' files

2013-03-16 Thread Myron Stowe
On Sat, 2013-03-16 at 15:11 -0700, Greg KH wrote: > On Sat, Mar 16, 2013 at 03:35:19PM -0600, Myron Stowe wrote: > > Sysfs includes entries to memory that backs a PCI device's BARs, both I/O > > Port space and MMIO. This memory regions correspond to the device's > > internal status and control

Re: [PATCH] udevadm-info: Don't access sysfs 'resource' files

2013-03-16 Thread Bjorn Helgaas
On Sat, Mar 16, 2013 at 4:11 PM, Greg KH wrote: > On Sat, Mar 16, 2013 at 03:35:19PM -0600, Myron Stowe wrote: >> Sysfs includes entries to memory that backs a PCI device's BARs, both I/O >> Port space and MMIO. This memory regions correspond to the device's >> internal status and control

Re: [PATCH] udevadm-info: Don't access sysfs 'resource' files

2013-03-16 Thread Greg KH
On Sat, Mar 16, 2013 at 03:35:19PM -0600, Myron Stowe wrote: > Sysfs includes entries to memory that backs a PCI device's BARs, both I/O > Port space and MMIO. This memory regions correspond to the device's > internal status and control registers used to drive the device. > > Accessing these

[PATCH] udevadm-info: Don't access sysfs 'resource' files

2013-03-16 Thread Myron Stowe
Sysfs includes entries to memory that backs a PCI device's BARs, both I/O Port space and MMIO. This memory regions correspond to the device's internal status and control registers used to drive the device. Accessing these registers from userspace such as "udevadm info --attribute-walk