Re: [PATCH] udf: convert some macros to functions

2008-01-08 Thread Jan Kara
On Mon 07-01-08 21:44:26, Marcin Slusarz wrote: > On Mon, Jan 07, 2008 at 12:26:18PM +, Christoph Hellwig wrote: > > On Sun, Jan 06, 2008 at 01:44:34AM +0100, [EMAIL PROTECTED] wrote: > > > +static struct udf_bitmap *udf_sb_alloc_bitmap(struct super_block *sb, > > > __u32 index) > > > +{ > >

Re: [PATCH] udf: convert some macros to functions

2008-01-08 Thread Jan Kara
On Mon 07-01-08 21:44:26, Marcin Slusarz wrote: On Mon, Jan 07, 2008 at 12:26:18PM +, Christoph Hellwig wrote: On Sun, Jan 06, 2008 at 01:44:34AM +0100, [EMAIL PROTECTED] wrote: +static struct udf_bitmap *udf_sb_alloc_bitmap(struct super_block *sb, __u32 index) +{ + struct

Re: [PATCH] udf: convert some macros to functions

2008-01-07 Thread Marcin Slusarz
On Mon, Jan 07, 2008 at 03:28:15PM -0800, Andrew Morton wrote: > On Mon, 7 Jan 2008 21:44:26 +0100 > Marcin Slusarz <[EMAIL PROTECTED]> wrote: > > > > There's some overly long lines here and some odd style, this should look > > > more like: > > These long lines were split later in "[PATCH 1/7]

Re: [PATCH] udf: convert some macros to functions

2008-01-07 Thread Andrew Morton
On Mon, 7 Jan 2008 21:44:26 +0100 Marcin Slusarz <[EMAIL PROTECTED]> wrote: > > There's some overly long lines here and some odd style, this should look > > more like: > These long lines were split later in "[PATCH 1/7] udf: fix coding style" Confused. How can patch 1/n come "later" than this

Re: [PATCH] udf: convert some macros to functions

2008-01-07 Thread Marcin Slusarz
On Mon, Jan 07, 2008 at 12:26:18PM +, Christoph Hellwig wrote: > On Sun, Jan 06, 2008 at 01:44:34AM +0100, [EMAIL PROTECTED] wrote: > > +static struct udf_bitmap *udf_sb_alloc_bitmap(struct super_block *sb, > > __u32 index) > > +{ > > + struct udf_part_map *map = _SB(sb)->s_partmaps[index];

Re: [PATCH] udf: convert some macros to functions

2008-01-07 Thread Christoph Hellwig
On Sun, Jan 06, 2008 at 01:44:34AM +0100, [EMAIL PROTECTED] wrote: > +static struct udf_bitmap *udf_sb_alloc_bitmap(struct super_block *sb, __u32 > index) > +{ > + struct udf_part_map *map = _SB(sb)->s_partmaps[index]; > + int nr_groups = (map->s_partition_len + (sizeof(struct

Re: [PATCH] udf: convert some macros to functions

2008-01-07 Thread Christoph Hellwig
On Sun, Jan 06, 2008 at 01:44:34AM +0100, [EMAIL PROTECTED] wrote: +static struct udf_bitmap *udf_sb_alloc_bitmap(struct super_block *sb, __u32 index) +{ + struct udf_part_map *map = UDF_SB(sb)-s_partmaps[index]; + int nr_groups = (map-s_partition_len + (sizeof(struct

Re: [PATCH] udf: convert some macros to functions

2008-01-07 Thread Marcin Slusarz
On Mon, Jan 07, 2008 at 12:26:18PM +, Christoph Hellwig wrote: On Sun, Jan 06, 2008 at 01:44:34AM +0100, [EMAIL PROTECTED] wrote: +static struct udf_bitmap *udf_sb_alloc_bitmap(struct super_block *sb, __u32 index) +{ + struct udf_part_map *map = UDF_SB(sb)-s_partmaps[index]; +

Re: [PATCH] udf: convert some macros to functions

2008-01-07 Thread Andrew Morton
On Mon, 7 Jan 2008 21:44:26 +0100 Marcin Slusarz [EMAIL PROTECTED] wrote: There's some overly long lines here and some odd style, this should look more like: These long lines were split later in [PATCH 1/7] udf: fix coding style Confused. How can patch 1/n come later than this one? Your

Re: [PATCH] udf: convert some macros to functions

2008-01-07 Thread Marcin Slusarz
On Mon, Jan 07, 2008 at 03:28:15PM -0800, Andrew Morton wrote: On Mon, 7 Jan 2008 21:44:26 +0100 Marcin Slusarz [EMAIL PROTECTED] wrote: There's some overly long lines here and some odd style, this should look more like: These long lines were split later in [PATCH 1/7] udf: fix coding

[PATCH] udf: convert some macros to functions

2008-01-05 Thread marcin . slusarz
convert UDF_SB_ALLOC_BITMAP macro to udf_sb_alloc_bitmap function convert UDF_SB_FREE_BITMAP macro to udf_sb_free_bitmap function Signed-off-by: Marcin Slusarz <[EMAIL PROTECTED]> CC: Ben Fennema <[EMAIL PROTECTED]> CC: Jan Kara <[EMAIL PROTECTED]> CC: Christoph Hellwig <[EMAIL PROTECTED]> ---

[PATCH] udf: convert some macros to functions

2008-01-05 Thread marcin . slusarz
convert UDF_SB_ALLOC_BITMAP macro to udf_sb_alloc_bitmap function convert UDF_SB_FREE_BITMAP macro to udf_sb_free_bitmap function Signed-off-by: Marcin Slusarz [EMAIL PROTECTED] CC: Ben Fennema [EMAIL PROTECTED] CC: Jan Kara [EMAIL PROTECTED] CC: Christoph Hellwig [EMAIL PROTECTED] ---