Re: [PATCH] udp: Add support for getsockopt(..., ..., UDP_GRO, ..., ...)

2021-04-01 Thread Norman Maurer
> On 1. Apr 2021, at 02:18, David Ahern wrote: > > On 3/31/21 7:10 AM, Norman Maurer wrote: >> Friendly ping… >> >> As this missing change was most likely an oversight in the original commit I >> do think it should go into 5.12 and subsequently stable as well. That’s also >> the reason why

Re: [PATCH] udp: Add support for getsockopt(..., ..., UDP_GRO, ..., ...)

2021-03-31 Thread David Ahern
On 3/31/21 7:10 AM, Norman Maurer wrote: > Friendly ping… > > As this missing change was most likely an oversight in the original commit I > do think it should go into 5.12 and subsequently stable as well. That’s also > the reason why I didn’t send a v2 and changed the commit message / subject

Re: [PATCH] udp: Add support for getsockopt(..., ..., UDP_GRO, ..., ...)

2021-03-31 Thread Paolo Abeni
On Wed, 2021-03-31 at 15:10 +0200, Norman Maurer wrote: > As this missing change was most likely an oversight in the original > commit I do think it should go into 5.12 and subsequently stable as > well. That’s also the reason why I didn’t send a v2 and changed the > commit message / subject for th

Re: [PATCH] udp: Add support for getsockopt(..., ..., UDP_GRO, ..., ...)

2021-03-31 Thread Norman Maurer
Friendly ping… As this missing change was most likely an oversight in the original commit I do think it should go into 5.12 and subsequently stable as well. That’s also the reason why I didn’t send a v2 and changed the commit message / subject for the patch. For me it clearly is a bug and not

Re: [PATCH] udp: Add support for getsockopt(..., ..., UDP_GRO, ..., ...)

2021-03-26 Thread Norman Maurer
Hi, > On 26. Mar 2021, at 10:36, Paolo Abeni wrote: > > Hello, > > On Thu, 2021-03-25 at 20:56 +0100, Norman Maurer wrote: >> From: Norman Maurer >> >> Support for UDP_GRO was added in the past but the implementation for >> getsockopt was missed which did lead to an error when we tried to >>

Re: [PATCH] udp: Add support for getsockopt(..., ..., UDP_GRO, ..., ...)

2021-03-26 Thread Norman Maurer
Hi, > On 26. Mar 2021, at 10:36, Paolo Abeni wrote: > > Hello, > > On Thu, 2021-03-25 at 20:56 +0100, Norman Maurer wrote: >> From: Norman Maurer >> >> Support for UDP_GRO was added in the past but the implementation for >> getsockopt was missed which did lead to an error when we tried to >>

Re: [PATCH] udp: Add support for getsockopt(..., ..., UDP_GRO, ..., ...)

2021-03-26 Thread Paolo Abeni
On Fri, 2021-03-26 at 11:22 +0100, Norman Maurer wrote: > On 26. Mar 2021, at 10:36, Paolo Abeni wrote: > > One thing you can do to simplifies the maintainer's life, would be post > > a v2 with the correct tag (and ev. obsolete this patch in patchwork). > > I am quite new to contribute patches to

Re: [PATCH] udp: Add support for getsockopt(..., ..., UDP_GRO, ..., ...)

2021-03-26 Thread Norman Maurer
Hi, > On 26. Mar 2021, at 10:36, Paolo Abeni wrote: > > Hello, > > On Thu, 2021-03-25 at 20:56 +0100, Norman Maurer wrote: >> From: Norman Maurer >> >> Support for UDP_GRO was added in the past but the implementation for >> getsockopt was missed which did lead to an error when we tried to >>

Re: [PATCH] udp: Add support for getsockopt(..., ..., UDP_GRO, ..., ...)

2021-03-26 Thread Paolo Abeni
Hello, On Thu, 2021-03-25 at 20:56 +0100, Norman Maurer wrote: > From: Norman Maurer > > Support for UDP_GRO was added in the past but the implementation for > getsockopt was missed which did lead to an error when we tried to > retrieve the setting for UDP_GRO. This patch adds the missing switch

[PATCH] udp: Add support for getsockopt(..., ..., UDP_GRO, ..., ...);

2021-03-25 Thread Norman Maurer
From: Norman Maurer Support for UDP_GRO was added in the past but the implementation for getsockopt was missed which did lead to an error when we tried to retrieve the setting for UDP_GRO. This patch adds the missing switch case for UDP_GRO Fixes: e20cf8d3f1f7 ("udp: implement GRO for plain UDP