Re: [PATCH] udp: gso: fix MTU check for small packets

2025-01-29 Thread Yan Zhai
v2 link here: https://lore.kernel.org/netdev/Z5swit7ykNRbJFMS@debian.debian/T/#u On Wed, Jan 29, 2025 at 10:48 AM Yan Zhai wrote: > > On Wed, Jan 29, 2025 at 8:08 AM Willem de Bruijn > wrote: > > > > Yan Zhai wrote: > > > On Tue, Jan 28, 2025 at 8:45 AM Willem de Bruijn > > > wrote: > > > > > >

Re: [PATCH] udp: gso: fix MTU check for small packets

2025-01-29 Thread Yan Zhai
On Wed, Jan 29, 2025 at 8:08 AM Willem de Bruijn wrote: > > Yan Zhai wrote: > > On Tue, Jan 28, 2025 at 8:45 AM Willem de Bruijn > > wrote: > > > > > > Yan Zhai wrote: > > > > Hi Willem, > > > > > > > > Thanks for getting back to me. > > > > > > > > On Mon, Jan 27, 2025 at 8:33 AM Willem de Bruij

Re: [PATCH] udp: gso: fix MTU check for small packets

2025-01-29 Thread Willem de Bruijn
Yan Zhai wrote: > On Tue, Jan 28, 2025 at 8:45 AM Willem de Bruijn > wrote: > > > > Yan Zhai wrote: > > > Hi Willem, > > > > > > Thanks for getting back to me. > > > > > > On Mon, Jan 27, 2025 at 8:33 AM Willem de Bruijn > > > wrote: > > > > > > > > Yan Zhai wrote: > > > > > Commit 4094871db1d6 (

Re: [PATCH] udp: gso: fix MTU check for small packets

2025-01-28 Thread Yan Zhai
On Tue, Jan 28, 2025 at 8:45 AM Willem de Bruijn wrote: > > Yan Zhai wrote: > > Hi Willem, > > > > Thanks for getting back to me. > > > > On Mon, Jan 27, 2025 at 8:33 AM Willem de Bruijn > > wrote: > > > > > > Yan Zhai wrote: > > > > Commit 4094871db1d6 ("udp: only do GSO if # of segs > 1") avoid

Re: [PATCH] udp: gso: fix MTU check for small packets

2025-01-28 Thread Willem de Bruijn
Yan Zhai wrote: > Hi Willem, > > Thanks for getting back to me. > > On Mon, Jan 27, 2025 at 8:33 AM Willem de Bruijn > wrote: > > > > Yan Zhai wrote: > > > Commit 4094871db1d6 ("udp: only do GSO if # of segs > 1") avoided GSO > > > for small packets. But the kernel currently dismisses GSO reques

Re: [PATCH] udp: gso: fix MTU check for small packets

2025-01-27 Thread Yan Zhai
Hi Willem, Thanks for getting back to me. On Mon, Jan 27, 2025 at 8:33 AM Willem de Bruijn wrote: > > Yan Zhai wrote: > > Commit 4094871db1d6 ("udp: only do GSO if # of segs > 1") avoided GSO > > for small packets. But the kernel currently dismisses GSO requests only > > after checking MTU on gs

Re: [PATCH] udp: gso: fix MTU check for small packets

2025-01-27 Thread Willem de Bruijn
Yan Zhai wrote: > Commit 4094871db1d6 ("udp: only do GSO if # of segs > 1") avoided GSO > for small packets. But the kernel currently dismisses GSO requests only > after checking MTU on gso_size. This means any packets, regardless of > their payload sizes, would be dropped when MTU is smaller than

[PATCH] udp: gso: fix MTU check for small packets

2025-01-26 Thread Yan Zhai
Commit 4094871db1d6 ("udp: only do GSO if # of segs > 1") avoided GSO for small packets. But the kernel currently dismisses GSO requests only after checking MTU on gso_size. This means any packets, regardless of their payload sizes, would be dropped when MTU is smaller than requested gso_size. Mean