Re: [PATCH] um: ubd: Fix crash from option parsing

2021-01-22 Thread Paul Lawrence
> This was addressed/fixed by the below patch, though that one doesn't > the first "file" variable check. I don't believe the first file variable can in fact be NULL, so my check was unnecessary. Pleased to see this has been fixed, we can abandon my patch now. Paul

Re: [PATCH] um: ubd: Fix crash from option parsing

2021-01-21 Thread Hajime Tazaki
Hello, On Wed, 20 Jan 2021 03:19:45 +0900, Paul Lawrence wrote: > > Below patch will cause NULL ptr dereferences if the optional filenames > are not present. > > Fixes: ef3ba87cb7c9 (um: ubd: Set device serial attribute from cmdline) > Signed-off-by: Paul Lawrence This was addressed/fixed by

Re: [PATCH] um: ubd: Fix crash from option parsing

2021-01-19 Thread Gabriel Krisman Bertazi
Paul Lawrence writes: > Below patch will cause NULL ptr dereferences if the optional filenames > are not present. > > Fixes: ef3ba87cb7c9 (um: ubd: Set device serial attribute from cmdline) > Signed-off-by: Paul Lawrence Looks good. Reviewed-by: Gabriel Krisman Bertazi Totally unrelated, but

[PATCH] um: ubd: Fix crash from option parsing

2021-01-19 Thread Paul Lawrence
Below patch will cause NULL ptr dereferences if the optional filenames are not present. Fixes: ef3ba87cb7c9 (um: ubd: Set device serial attribute from cmdline) Signed-off-by: Paul Lawrence --- arch/um/drivers/ubd_kern.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/ar