Re: [PATCH] um: use KERN_CONT in stack dump

2017-04-11 Thread Vegard Nossum
On 12 March 2017 at 10:47, Vegard Nossum wrote: > On 12/03/2017 10:45, Richard Weinberger wrote: >> diff --git a/arch/um/kernel/sysrq.c b/arch/um/kernel/sysrq.c >> index aa1b56f5ac68..18eddf677ec6 100644 >> --- a/arch/um/kernel/sysrq.c >> +++ b/arch/um/kernel/sysrq.c >> @@ -17,10 +17,8 @@ >> >> s

Re: [PATCH] um: use KERN_CONT in stack dump

2017-03-12 Thread Vegard Nossum
On 12/03/2017 10:45, Richard Weinberger wrote: Am 12.03.2017 um 10:38 schrieb Vegard Nossum: Without KERN_CONT, the symbol will appear on a new line, making stack traces completely unreadable: [snip] I think it is better to fix the root of the problem by using a single printk. i.e. diff --git

Re: [PATCH] um: use KERN_CONT in stack dump

2017-03-12 Thread Richard Weinberger
Vegard, Am 12.03.2017 um 10:38 schrieb Vegard Nossum: > Without KERN_CONT, the symbol will appear on a new line, making stack > traces completely unreadable: > > Call Trace: > [<6008e891>] ? > printk+0x0/0x94 > [<6001cce6>] > show_stack+0xfe/0x15b > [<600666ec>] ? >

[PATCH] um: use KERN_CONT in stack dump

2017-03-12 Thread Vegard Nossum
Without KERN_CONT, the symbol will appear on a new line, making stack traces completely unreadable: Call Trace: [<6008e891>] ? printk+0x0/0x94 [<6001cce6>] show_stack+0xfe/0x15b [<600666ec>] ? dump_stack_print_info+0xe1/0xea [<6008e891>] ? printk+0x0/0x94