Dave Hansen writes:
> Several of our on-disk filesystems have an ioctl function that already
> has indented goto labels. I don't think it's quite worth churning all
> of these (working) filesystems to make a style checker happy.
I agree.
> I think it's worse style to be mixing label indentation
On Fri, Jun 22, 2007 at 11:02:10AM -0700, Dave Hansen wrote:
> On Fri, 2007-06-22 at 12:54 -0500, Joel Schopp wrote:
> > If it is "kinda like a mini function" why not make it "actually a mini
> > function" and call it?
>
> Several of our on-disk filesystems have an ioctl function that already
> h
Several of our on-disk filesystems have an ioctl function that already
has indented goto labels. I don't think it's quite worth churning all
of these (working) filesystems to make a style checker happy.
I think it's worse style to be mixing label indentation in a file as it
is to create new "cor
On Fri, 2007-06-22 at 12:54 -0500, Joel Schopp wrote:
> If it is "kinda like a mini function" why not make it "actually a mini
> function" and call it?
Several of our on-disk filesystems have an ioctl function that already
has indented goto labels. I don't think it's quite worth churning all
of
foo_ioctl()
{
switch(ioctl) {
case FOO:
lots
of
code
error:
return result;
case BAR:
return result;
}
Notice that the "error:" label is indented. Each of the case is kinda
like a mini
Andy and Joel, very cool that you got this in-tree!
I have a patch touching a bunch of fs ioctl functions.
Things like ext2_ioctl() look like this:
foo_ioctl()
{
switch(ioctl) {
case FOO:
lots
of
code
error:
Update to checkpatch.pl v0.06. Of note:
- do { and else handled correctly as control structures for { matching
- trailing whitespace correctly tripped when line otherwise empty
- support for const, including const foo * const bar
- multiline macros defining values correctly reported
This ve
7 matches
Mail list logo
