Hi Oleg,
On Tue, May 5, 2020 at 12:47 AM Oleg Nesterov wrote:
>
> uprobe_write_opcode() must not cross page boundary; prepare_uprobe()
> relies on arch_uprobe_analyze_insn() which should validate "vaddr" but
> some architectures (csky, s390, and sparc) don't do this.
>
> We can remove the BUG_ON(
On Tue, May 5, 2020 at 2:41 AM Christian Borntraeger
wrote:
>
>
>
> On 04.05.20 18:47, Oleg Nesterov wrote:
> > uprobe_write_opcode() must not cross page boundary; prepare_uprobe()
> > relies on arch_uprobe_analyze_insn() which should validate "vaddr" but
> > some architectures (csky, s390, and sp
On Tue, 9 Jun 2020 09:48:45 -0700
Linus Torvalds wrote:
> On Tue, Jun 9, 2020 at 8:30 AM Oleg Nesterov wrote:
> >
> > Looks like this patch was forgotten...
> >
> > Should I resend it?
>
> I guess I'll just take it directly, since it was triggered by me
> complaining anyway.
>
> I had hoped
On Tue, Jun 9, 2020 at 8:30 AM Oleg Nesterov wrote:
>
> Looks like this patch was forgotten...
>
> Should I resend it?
I guess I'll just take it directly, since it was triggered by me
complaining anyway.
I had hoped it would go through the usual channels.
Linus
Looks like this patch was forgotten...
Should I resend it?
On 05/04, Oleg Nesterov wrote:
>
> uprobe_write_opcode() must not cross page boundary; prepare_uprobe()
> relies on arch_uprobe_analyze_insn() which should validate "vaddr" but
> some architectures (csky, s390, and sparc) don't do this.
>
On 05/06, Steven Rostedt wrote:
>
> As this is in the kernel/events/ directory, I'm guessing it should be taken
> through the tip tree?
this would be great, thanks Steven.
Oleg.
On Wed, 6 May 2020 10:59:55 +0530
Srikar Dronamraju wrote:
> * Oleg Nesterov [2020-05-04 18:47:25]:
>
> > uprobe_write_opcode() must not cross page boundary; prepare_uprobe()
> > relies on arch_uprobe_analyze_insn() which should validate "vaddr" but
> > some architectures (csky, s390, and sparc
* Oleg Nesterov [2020-05-04 18:47:25]:
> uprobe_write_opcode() must not cross page boundary; prepare_uprobe()
> relies on arch_uprobe_analyze_insn() which should validate "vaddr" but
> some architectures (csky, s390, and sparc) don't do this.
>
> We can remove the BUG_ON() check in prepare_uprob
Hi,
On Mon, May 04, 2020 at 08:40:44PM +0200, Christian Borntraeger wrote:
>
>
> On 04.05.20 18:47, Oleg Nesterov wrote:
> > uprobe_write_opcode() must not cross page boundary; prepare_uprobe()
> > relies on arch_uprobe_analyze_insn() which should validate "vaddr" but
> > some architectures (csk
On 04.05.20 18:47, Oleg Nesterov wrote:
> uprobe_write_opcode() must not cross page boundary; prepare_uprobe()
> relies on arch_uprobe_analyze_insn() which should validate "vaddr" but
> some architectures (csky, s390, and sparc) don't do this.
I think the idea was that the uprobe instruction is
uprobe_write_opcode() must not cross page boundary; prepare_uprobe()
relies on arch_uprobe_analyze_insn() which should validate "vaddr" but
some architectures (csky, s390, and sparc) don't do this.
We can remove the BUG_ON() check in prepare_uprobe() and validate the
offset early in __uprobe_regis
11 matches
Mail list logo