Re: [PATCH] usb/hid: The HID Simple Driver Interface 0.4.1 (core)

2006-12-06 Thread Liyu
Jiri Kosina wrote: > Do you think that you could wait a little bit more, after the split has > been done? (it's currently planned approximately after 2.6.20-rc1). It > seems to me that your patches will apply almost cleanly on top of the > split patches (you will have to change the pathnames, of

Re: [PATCH] usb/hid: The HID Simple Driver Interface 0.4.1 (core)

2006-12-06 Thread Greg KH
On Wed, Dec 06, 2006 at 04:18:37PM +0100, Marcel Holtmann wrote: > Hi Dmitry, > > > > > > I still have the same objection - the "simple'" code will have to be > > > > > compiled into the driver instead of being a separate module and > > > > > eventyally will lead to a monster-size HID module. We h

Re: [PATCH] usb/hid: The HID Simple Driver Interface 0.4.1 (core)

2006-12-06 Thread Jiri Kosina
On Wed, 6 Dec 2006, Dmitry Torokhov wrote: > If Greg is OK with that I would start with truly mechanical merge (no > now data structures, just move the files around) and merge this ASAP, > before we hit -rc1 or -rc2 at the latest. Then you can start puling up > your changesin the separate git t

Re: [PATCH] usb/hid: The HID Simple Driver Interface 0.4.1 (core)

2006-12-06 Thread Dmitry Torokhov
On 12/6/06, Jiri Kosina <[EMAIL PROTECTED]> wrote: On Wed, 6 Dec 2006, Dmitry Torokhov wrote: > Is there any reason why we can't mecanically move everything into > drivers/hid right now? Then Greg could simply forward all patches he > gets for HID your way and you won't have hard time merging you

Re: [PATCH] usb/hid: The HID Simple Driver Interface 0.4.1 (core)

2006-12-06 Thread Marcel Holtmann
Hi Jiri, > This would be nice to merge, if noone has any major objections, and do > other development on top of that. > I am currently trying to set up an account and git tree for this at > kernel.org ... request sent, waiting for reply :) I can setup a tree for the merge. You simply have to c

Re: [PATCH] usb/hid: The HID Simple Driver Interface 0.4.1 (core)

2006-12-06 Thread Jiri Kosina
On Wed, 6 Dec 2006, Dmitry Torokhov wrote: > > I guess that this paragraph wasn't for me, but rather for the author of > > the HID Simple Driver proposal, am I right? > Yes, mainly for him but also for you because we need to be able to do > what Li Yu is trying to do and be able to tweak HID inter

Re: [PATCH] usb/hid: The HID Simple Driver Interface 0.4.1 (core)

2006-12-06 Thread Marcel Holtmann
Hi Dmitry, > > > > I still have the same objection - the "simple'" code will have to be > > > > compiled into the driver instead of being a separate module and > > > > eventyally will lead to a monster-size HID module. We have this issue > > > > with psmouse to a degree but with HID the growth pot

Re: [PATCH] usb/hid: The HID Simple Driver Interface 0.4.1 (core)

2006-12-06 Thread Dmitry Torokhov
On 12/6/06, Jiri Kosina <[EMAIL PROTECTED]> wrote: On Wed, 6 Dec 2006, Marcel Holtmann wrote: > > I still have the same objection - the "simple'" code will have to be > > compiled into the driver instead of being a separate module and > > eventyally will lead to a monster-size HID module. We hav

Re: [PATCH] usb/hid: The HID Simple Driver Interface 0.4.1 (core)

2006-12-06 Thread Marcel Holtmann
Hi Dmitry, > > > I still have the same objection - the "simple'" code will have to be > > > compiled into the driver instead of being a separate module and > > > eventyally will lead to a monster-size HID module. We have this issue > > > with psmouse to a degree but with HID the growth potential i

Re: [PATCH] usb/hid: The HID Simple Driver Interface 0.4.1 (core)

2006-12-06 Thread Dmitry Torokhov
Hi Marcel, On 12/6/06, Marcel Holtmann <[EMAIL PROTECTED]> wrote: Hi Dmitry, > > > 1. Make hidinput_disconnect_core() be more robust, it can not > > > break anything even failed to allocate device struct. > > > 2. Thanks new input device driver API, we need not the extra co

Re: [PATCH] usb/hid: The HID Simple Driver Interface 0.4.1 (core)

2006-12-06 Thread Jiri Kosina
On Wed, 6 Dec 2006, Marcel Holtmann wrote: > > I still have the same objection - the "simple'" code will have to be > > compiled into the driver instead of being a separate module and > > eventyally will lead to a monster-size HID module. We have this issue > > with psmouse to a degree but with HI

Re: [PATCH] usb/hid: The HID Simple Driver Interface 0.4.1 (core)

2006-12-06 Thread Marcel Holtmann
Hi Dmitry, > > > 1. Make hidinput_disconnect_core() be more robust, it can not > > > break anything even failed to allocate device struct. > > > 2. Thanks new input device driver API, we need not the extra code > > > for support force-feed device yet, so say bye to >

Re: [PATCH] usb/hid: The HID Simple Driver Interface 0.4.1 (core)

2006-12-06 Thread Dmitry Torokhov
Hi, On 12/6/06, Jiri Kosina <[EMAIL PROTECTED]> wrote: On Wed, 6 Dec 2006, Li Yu wrote: > 1. Make hidinput_disconnect_core() be more robust, it can not > break anything even failed to allocate device struct. > 2. Thanks new input device driver API, we need not the extra cod

Re: [PATCH] usb/hid: The HID Simple Driver Interface 0.4.1 (core)

2006-12-06 Thread Jiri Kosina
On Wed, 6 Dec 2006, Li Yu wrote: > 1. Make hidinput_disconnect_core() be more robust, it can not > break anything even failed to allocate device struct. > 2. Thanks new input device driver API, we need not the extra code > for support force-feed device yet, so say b

[PATCH] usb/hid: The HID Simple Driver Interface 0.4.1 (core)

2006-12-06 Thread Li Yu
Changelogs (since 0.4.0): 1. Make hidinput_disconnect_core() be more robust, it can not break anything even failed to allocate device struct. 2. Thanks new input device driver API, we need not the extra code for support force-feed device yet, so say bye to CONFIG_HID_SIMPLE_FF.