Re: [PATCH] usb: acm gadget: Null termintate strings table

2013-08-30 Thread Greg Kroah-Hartman
On Wed, Aug 28, 2013 at 04:36:14PM -0700, Graham Williams wrote: > The gadget strings table should be null terminated. > usb_gadget_get_string() loops through the table > expecting a null at the end of the list. > > Signed-off-by: Graham Williams Yeah, this finally worked! :) Thanks for sticki

[PATCH] usb: acm gadget: Null termintate strings table

2013-08-28 Thread Graham Williams
The gadget strings table should be null terminated. usb_gadget_get_string() loops through the table expecting a null at the end of the list. Signed-off-by: Graham Williams --- drivers/usb/gadget/f_acm.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/gadget/f_acm.c b/drivers/usb/

Re: [PATCH] usb: acm gadget: Null termintate strings table

2013-08-27 Thread Felipe Balbi
Hi, On Thu, Aug 22, 2013 at 07:10:04PM +, Graham Williams wrote: > The gadget strings table should be null terminated. > usb_gadget_get_string() loops through the table > expecting a null at the end of the list. > > Signed-off-by: Graham complains about being a malformed patch. -- balbi

Re: [PATCH] usb: acm gadget: Null termintate strings table

2013-08-23 Thread Greg KH
On Fri, Aug 23, 2013 at 11:19:55PM +, Graham Williams wrote: > I couldn't get the whitespace formatting correctly from Windows Office (work > email) so I attached the patch file. I ran it on it applies correctly. I can't take attachments, and especially not base64 ones :( Take a look at th

[PATCH] usb: acm gadget: Null termintate strings table

2013-08-23 Thread Graham Williams
I couldn't get the whitespace formatting correctly from Windows Office (work email) so I attached the patch file. I ran it on it applies correctly. 0001-usb-acm-gadget-Null-termintate-strings-table.patch Description: 0001-usb-acm-gadget-Null-termintate-strings-table.patch

Re: [PATCH] usb: acm gadget: Null termintate strings table

2013-08-23 Thread Greg KH
On Fri, Aug 23, 2013 at 05:51:12PM +, Graham Williams wrote: > > The gadget strings table should be null terminated. > usb_gadget_get_string() loops through the table > expecting a null at the end of the list. > > Signed-off-by: Graham Williams Nice, that works. > --- > drivers/usb/gadget/

[PATCH] usb: acm gadget: Null termintate strings table

2013-08-23 Thread Graham Williams
The gadget strings table should be null terminated. usb_gadget_get_string() loops through the table expecting a null at the end of the list. Signed-off-by: Graham Williams --- drivers/usb/gadget/f_acm.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/gadget/f_acm.c b/drivers/usb/g

Re: [PATCH] usb: acm gadget: Null termintate strings table

2013-08-23 Thread Greg KH
On Fri, Aug 23, 2013 at 05:43:51PM +, Graham Williams wrote: > > The gadget strings table should be null terminated. > usb_gadget_get_string() loops through the table > expecting a null at the end of the list. > > Signed-off-by: Graham Williams Minor nit, you need a space after your last nam

[PATCH] usb: acm gadget: Null termintate strings table

2013-08-23 Thread Graham Williams
The gadget strings table should be null terminated. usb_gadget_get_string() loops through the table expecting a null at the end of the list. Signed-off-by: Graham Williams --- drivers/usb/gadget/f_acm.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/gadget/f_acm.c b/drivers/usb/ga

Re: [PATCH] usb: acm gadget: Null termintate strings table

2013-08-23 Thread Greg KH
On Tue, Aug 20, 2013 at 03:17:37PM +, Graham Williams wrote: > The gadget strings table should be null terminated. > usb_gadget_get_string() loops through the table > expecting a null at the end of the list. > > Signed-off-by: Graham I need a full name for a signed-off-by: line, can you plea

[PATCH] usb: acm gadget: Null termintate strings table

2013-08-22 Thread Graham Williams
The gadget strings table should be null terminated. usb_gadget_get_string() loops through the table expecting a null at the end of the list. Signed-off-by: Graham --- drivers/usb/gadget/f_acm.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/gadget/f_acm.c b/drivers/usb/gadget/f_ac

[PATCH] usb: acm gadget: Null termintate strings table

2013-08-20 Thread Graham Williams
The gadget strings table should be null terminated. usb_gadget_get_string() loops through the table expecting a null at the end of the list. Signed-off-by: Graham --- drivers/usb/gadget/f_acm.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/gadget/f_acm.c b/drivers/usb/gadget/f_