> On Thu, 2019-01-17 at 06:44 +, Peter Chen wrote:
> >
> > > On Wed, 2019-01-16 at 14:44 +0100, Thomas Petazzoni wrote:
> > > > Well prior to your code, there was already a possibility for both
> > > > ci->phy and ci->usb_phy to be valid. I don't think it's really
> > > > ci->useful
> > > > t
Hi,
On Thu, 2019-01-17 at 06:44 +, Peter Chen wrote:
>
> > On Wed, 2019-01-16 at 14:44 +0100, Thomas Petazzoni wrote:
> > > Well prior to your code, there was already a possibility for both
> > > ci->phy and ci->usb_phy to be valid. I don't think it's really useful
> > > to avoid the fallbac
>
> On Wed, 2019-01-16 at 14:44 +0100, Thomas Petazzoni wrote:
> > Well prior to your code, there was already a possibility for both
> > ci->phy and ci->usb_phy to be valid. I don't think it's really useful
> > to avoid the fallback when a generic PHY has already been found, it's
> > confusing.
Hi,
On Wed, 2019-01-16 at 14:44 +0100, Thomas Petazzoni wrote:
> Well prior to your code, there was already a possibility for both
> ci->phy and ci->usb_phy to be valid. I don't think it's really useful
> to avoid the fallback when a generic PHY has already been found, it's
> confusing. If really
Hello,
On Wed, 16 Jan 2019 14:30:28 +0100, Paul Kocialkowski wrote:
> > Why is this conditional on the generic PHY lookup failing?
> >
> > Don't we simply want:
> >
> > ci->phy = devm_phy_get(dev->parent, "usb-phy");
> > ci->usb_phy = devm_usb_get_phy_by_phandle(dev->parent, "phys", 0);
Hi,
On Wed, 2019-01-16 at 11:53 +0100, Thomas Petazzoni wrote:
> Hello,
>
> Thanks for the patch!
And thanks for the review!
> On Wed, 16 Jan 2019 11:10:51 +0100, Paul Kocialkowski wrote:
> > According to the chipidea driver bindings, the USB PHY is specified via
> > the "phys" phandle node. Ho
Hello,
Thanks for the patch!
On Wed, 16 Jan 2019 11:10:51 +0100, Paul Kocialkowski wrote:
> According to the chipidea driver bindings, the USB PHY is specified via
> the "phys" phandle node. However, this only takes effect for USB PHYs
> that use the common PHY framework. For legacy USB PHYs, a s
According to the chipidea driver bindings, the USB PHY is specified via
the "phys" phandle node. However, this only takes effect for USB PHYs
that use the common PHY framework. For legacy USB PHYs, a simple lookup
based on the USB PHY type is done instead.
This does not play out well when more tha
8 matches
Mail list logo
