Re: [PATCH] usb: devio: remove assignment from if condition

2015-08-03 Thread Dan Carpenter
On Mon, Aug 03, 2015 at 01:08:26PM -0400, Kris Borer wrote: > else > + switch (ctl->ioctl_code) { This else statement isn't indented. It looks weird and it will cause static checker warnings (hopefully). Maybe leave that one out and send the rest. Do complicated one in

[PATCH] usb: devio: remove assignment from if condition

2015-08-03 Thread Kris Borer
Fix six occurrences of the checkpatch.pl error: ERROR: do not use assignment in if condition The semantic patch that makes this change is: // @@ identifier i; expression E; statement S1, S2; @@ + i = E; if ( - (i = E) + i ) S1 else S2 @@ identifier i; expression E; statement S; constant c