Re: [PATCH] usb: dwc2: Fix error path in gadget registration

2020-07-16 Thread Marek Szyprowski
On 16.07.2020 13:58, Marek Szyprowski wrote: > On 15.07.2020 15:54, Minas Harutyunyan wrote: >> On 7/15/2020 12:42 PM, Marek Szyprowski wrote: >>> On 14.07.2020 14:32, Minas Harutyunyan wrote: On 7/14/2020 12:48 PM, Marek Szyprowski wrote: > When gadget registration fails, one should not c

Re: [PATCH] usb: dwc2: Fix error path in gadget registration

2020-07-16 Thread Marek Szyprowski
Hi Minas, On 15.07.2020 15:54, Minas Harutyunyan wrote: > On 7/15/2020 12:42 PM, Marek Szyprowski wrote: >> On 14.07.2020 14:32, Minas Harutyunyan wrote: >>> On 7/14/2020 12:48 PM, Marek Szyprowski wrote: When gadget registration fails, one should not call usb_del_gadget_udc(). Ensure th

Re: [PATCH] usb: dwc2: Fix error path in gadget registration

2020-07-15 Thread Minas Harutyunyan
Hi Marek, On 7/15/2020 12:42 PM, Marek Szyprowski wrote: > Hi Minas, > > On 14.07.2020 14:32, Minas Harutyunyan wrote: >> On 7/14/2020 12:48 PM, Marek Szyprowski wrote: >>> When gadget registration fails, one should not call usb_del_gadget_udc(). >>> Ensure this by setting gadget->udc to NULL. Al

Re: [PATCH] usb: dwc2: Fix error path in gadget registration

2020-07-15 Thread Marek Szyprowski
Hi Minas, On 14.07.2020 14:32, Minas Harutyunyan wrote: > On 7/14/2020 12:48 PM, Marek Szyprowski wrote: >> When gadget registration fails, one should not call usb_del_gadget_udc(). >> Ensure this by setting gadget->udc to NULL. Also in case of a failure > I was able to reproduce issue. I'm Ok wit

Re: [PATCH] usb: dwc2: Fix error path in gadget registration

2020-07-14 Thread Minas Harutyunyan
Hi Marek, On 7/14/2020 12:48 PM, Marek Szyprowski wrote: > When gadget registration fails, one should not call usb_del_gadget_udc(). > Ensure this by setting gadget->udc to NULL. Also in case of a failure I was able to reproduce issue. I'm Ok with this fix. > there is no need to disable low-level

[PATCH] usb: dwc2: Fix error path in gadget registration

2020-07-14 Thread Marek Szyprowski
When gadget registration fails, one should not call usb_del_gadget_udc(). Ensure this by setting gadget->udc to NULL. Also in case of a failure there is no need to disable low-level hardware, so return immiedetly instead of jumping to error_init label. This fixes the following kernel NULL ptr dere