Re: [PATCH] usb: dwc3: core: Don't try to get PHYs during suspend/resume

On 11/01/18 11:31, Felipe Balbi wrote: > > Hi, > > Roger Quadros writes: >>> Roger Quadros writes: >>> - ret = dwc3_core_soft_reset(dwc); >>> + ret = dwc3_core_get_phy(dwc); >> >> we can get_phy in dwc3_core_init() as it will get called

Re: [PATCH] usb: dwc3: core: Don't try to get PHYs during suspend/resume

On 11/01/18 11:31, Felipe Balbi wrote: > > Hi, > > Roger Quadros writes: >>> Roger Quadros writes: >>> - ret = dwc3_core_soft_reset(dwc); >>> + ret = dwc3_core_get_phy(dwc); >> >> we can get_phy in dwc3_core_init() as it will get called on resume(). >> This was

Re: [PATCH] usb: dwc3: core: Don't try to get PHYs during suspend/resume

Hi, Roger Quadros writes: >> Roger Quadros writes: >> -ret = dwc3_core_soft_reset(dwc); >> +ret = dwc3_core_get_phy(dwc); > > we can get_phy in dwc3_core_init() as it will get called on resume(). > This was the $subject of this

Re: [PATCH] usb: dwc3: core: Don't try to get PHYs during suspend/resume

Hi, Roger Quadros writes: >> Roger Quadros writes: >> -ret = dwc3_core_soft_reset(dwc); >> +ret = dwc3_core_get_phy(dwc); > > we can get_phy in dwc3_core_init() as it will get called on resume(). > This was the $subject of this patch. indeed.

Re: [PATCH] usb: dwc3: core: Don't try to get PHYs during suspend/resume

On 11/01/18 11:09, Roger Quadros wrote: > +Heikki > > On 11/01/18 10:25, Felipe Balbi wrote: >> >> Hi, >> >> Roger Quadros writes: >> -ret = dwc3_core_soft_reset(dwc); >> +ret = dwc3_core_get_phy(dwc); > > we can get_phy in dwc3_core_init() as it

Re: [PATCH] usb: dwc3: core: Don't try to get PHYs during suspend/resume

On 11/01/18 11:09, Roger Quadros wrote: > +Heikki > > On 11/01/18 10:25, Felipe Balbi wrote: >> >> Hi, >> >> Roger Quadros writes: >> -ret = dwc3_core_soft_reset(dwc); >> +ret = dwc3_core_get_phy(dwc); > > we can get_phy in dwc3_core_init() as it will get called

Re: [PATCH] usb: dwc3: core: Don't try to get PHYs during suspend/resume

+Heikki On 11/01/18 10:25, Felipe Balbi wrote: > > Hi, > > Roger Quadros writes: > - ret = dwc3_core_soft_reset(dwc); > + ret = dwc3_core_get_phy(dwc); we can get_phy in dwc3_core_init() as it will get called on resume(). This was the $subject of this

Re: [PATCH] usb: dwc3: core: Don't try to get PHYs during suspend/resume

+Heikki On 11/01/18 10:25, Felipe Balbi wrote: > > Hi, > > Roger Quadros writes: > - ret = dwc3_core_soft_reset(dwc); > + ret = dwc3_core_get_phy(dwc); we can get_phy in dwc3_core_init() as it will get called on resume(). This was the $subject of this patch. >>> >>>

Re: [PATCH] usb: dwc3: core: Don't try to get PHYs during suspend/resume

Hi, Roger Quadros writes: - ret = dwc3_core_soft_reset(dwc); + ret = dwc3_core_get_phy(dwc); >>> >>> we can get_phy in dwc3_core_init() as it will get called on resume(). >>> This was the $subject of this patch. >> >> indeed. thanks :-) >> > > oops sorry. I meant we

Re: [PATCH] usb: dwc3: core: Don't try to get PHYs during suspend/resume

Hi, Roger Quadros writes: - ret = dwc3_core_soft_reset(dwc); + ret = dwc3_core_get_phy(dwc); >>> >>> we can get_phy in dwc3_core_init() as it will get called on resume(). >>> This was the $subject of this patch. >> >> indeed. thanks :-) >> > > oops sorry. I meant we can't call

Re: [PATCH] usb: dwc3: core: Don't try to get PHYs during suspend/resume

On 10/01/18 16:04, Felipe Balbi wrote: > > Hi, > > Roger Quadros writes: >>> Roger Quadros writes: Felipe, On 10/01/18 15:11, Roger Quadros wrote: > The USB PHYs should be requested only once during the life cycle of > this driver. >

Re: [PATCH] usb: dwc3: core: Don't try to get PHYs during suspend/resume

On 10/01/18 16:04, Felipe Balbi wrote: > > Hi, > > Roger Quadros writes: >>> Roger Quadros writes: Felipe, On 10/01/18 15:11, Roger Quadros wrote: > The USB PHYs should be requested only once during the life cycle of > this driver. > > As dwc3_core_init() is

Re: [PATCH] usb: dwc3: core: Don't try to get PHYs during suspend/resume

Hi, Roger Quadros writes: >> Roger Quadros writes: >>> Felipe, >>> >>> On 10/01/18 15:11, Roger Quadros wrote: The USB PHYs should be requested only once during the life cycle of this driver. As dwc3_core_init() is called during system

Re: [PATCH] usb: dwc3: core: Don't try to get PHYs during suspend/resume

Hi, Roger Quadros writes: >> Roger Quadros writes: >>> Felipe, >>> >>> On 10/01/18 15:11, Roger Quadros wrote: The USB PHYs should be requested only once during the life cycle of this driver. As dwc3_core_init() is called during system suspend/resume it will result in

Re: [PATCH] usb: dwc3: core: Don't try to get PHYs during suspend/resume

On 10/01/18 15:33, Felipe Balbi wrote: > > Hi, > > Roger Quadros writes: >> Felipe, >> >> On 10/01/18 15:11, Roger Quadros wrote: >>> The USB PHYs should be requested only once during the life cycle of >>> this driver. >>> >>> As dwc3_core_init() is called during system

Re: [PATCH] usb: dwc3: core: Don't try to get PHYs during suspend/resume

On 10/01/18 15:33, Felipe Balbi wrote: > > Hi, > > Roger Quadros writes: >> Felipe, >> >> On 10/01/18 15:11, Roger Quadros wrote: >>> The USB PHYs should be requested only once during the life cycle of >>> this driver. >>> >>> As dwc3_core_init() is called during system suspend/resume >>> it

Re: [PATCH] usb: dwc3: core: Don't try to get PHYs during suspend/resume

Hi, Roger Quadros writes: > Felipe, > > On 10/01/18 15:11, Roger Quadros wrote: >> The USB PHYs should be requested only once during the life cycle of >> this driver. >> >> As dwc3_core_init() is called during system suspend/resume >> it will result in multiple calls to

Re: [PATCH] usb: dwc3: core: Don't try to get PHYs during suspend/resume

Hi, Roger Quadros writes: > Felipe, > > On 10/01/18 15:11, Roger Quadros wrote: >> The USB PHYs should be requested only once during the life cycle of >> this driver. >> >> As dwc3_core_init() is called during system suspend/resume >> it will result in multiple calls to dwc3_core_get_phy()

Re: [PATCH] usb: dwc3: core: Don't try to get PHYs during suspend/resume

Felipe, On 10/01/18 15:11, Roger Quadros wrote: > The USB PHYs should be requested only once during the life cycle of > this driver. > > As dwc3_core_init() is called during system suspend/resume > it will result in multiple calls to dwc3_core_get_phy() which is wrong. > > To prevent that let's

Re: [PATCH] usb: dwc3: core: Don't try to get PHYs during suspend/resume

Felipe, On 10/01/18 15:11, Roger Quadros wrote: > The USB PHYs should be requested only once during the life cycle of > this driver. > > As dwc3_core_init() is called during system suspend/resume > it will result in multiple calls to dwc3_core_get_phy() which is wrong. > > To prevent that let's

[PATCH] usb: dwc3: core: Don't try to get PHYs during suspend/resume

The USB PHYs should be requested only once during the life cycle of this driver. As dwc3_core_init() is called during system suspend/resume it will result in multiple calls to dwc3_core_get_phy() which is wrong. To prevent that let's move dwc3_core_get_phy() call outside dwc3_core_init().

[PATCH] usb: dwc3: core: Don't try to get PHYs during suspend/resume

The USB PHYs should be requested only once during the life cycle of this driver. As dwc3_core_init() is called during system suspend/resume it will result in multiple calls to dwc3_core_get_phy() which is wrong. To prevent that let's move dwc3_core_get_phy() call outside dwc3_core_init().