Re: [PATCH] usb: dwc3-exynos fix unspecified suspend clk error handling

Hi Krzysztof, On Tuesday 10 January 2017 11:55 PM, Krzysztof Kozlowski wrote: > On Tue, Jan 10, 2017 at 06:09:40PM +0100, Bartlomiej Zolnierkiewicz wrote: >> BTW What is interesting is that the Exynos7 dts patch [2] has never >> made it into upstream for some reason. In the meantime however >>

Re: [PATCH] usb: dwc3-exynos fix unspecified suspend clk error handling

Hi Krzysztof, On Tuesday 10 January 2017 11:55 PM, Krzysztof Kozlowski wrote: > On Tue, Jan 10, 2017 at 06:09:40PM +0100, Bartlomiej Zolnierkiewicz wrote: >> BTW What is interesting is that the Exynos7 dts patch [2] has never >> made it into upstream for some reason. In the meantime however >>

Re: [PATCH] usb: dwc3-exynos fix unspecified suspend clk error handling

On 01/10/2017 11:59 AM, Krzysztof Kozlowski wrote: > On Tue, Jan 10, 2017 at 11:37:24AM -0700, Shuah Khan wrote: >> On 01/10/2017 11:23 AM, Bartlomiej Zolnierkiewicz wrote: >>> I also think that regardless of what is decided on making susp_clk >>> non-optional for some Exynos SoCs we should

Re: [PATCH] usb: dwc3-exynos fix unspecified suspend clk error handling

On 01/10/2017 11:59 AM, Krzysztof Kozlowski wrote: > On Tue, Jan 10, 2017 at 11:37:24AM -0700, Shuah Khan wrote: >> On 01/10/2017 11:23 AM, Bartlomiej Zolnierkiewicz wrote: >>> I also think that regardless of what is decided on making susp_clk >>> non-optional for some Exynos SoCs we should

Re: [PATCH] usb: dwc3-exynos fix unspecified suspend clk error handling

On Tue, Jan 10, 2017 at 11:37:24AM -0700, Shuah Khan wrote: > On 01/10/2017 11:23 AM, Bartlomiej Zolnierkiewicz wrote: > > I also think that regardless of what is decided on making susp_clk > > non-optional for some Exynos SoCs we should probably remove the debug > > message as it doesn't bring

Re: [PATCH] usb: dwc3-exynos fix unspecified suspend clk error handling

On Tue, Jan 10, 2017 at 11:37:24AM -0700, Shuah Khan wrote: > On 01/10/2017 11:23 AM, Bartlomiej Zolnierkiewicz wrote: > > I also think that regardless of what is decided on making susp_clk > > non-optional for some Exynos SoCs we should probably remove the debug > > message as it doesn't bring

Re: [PATCH] usb: dwc3-exynos fix unspecified suspend clk error handling

On 01/10/2017 11:23 AM, Bartlomiej Zolnierkiewicz wrote: > On Tuesday, January 10, 2017 07:03:57 PM Bartlomiej Zolnierkiewicz wrote: >> >> Hi, >> >> On Tuesday, January 10, 2017 11:23:38 PM Anand Moon wrote: >>> Hi Shuah, >>> >>> On 10 January 2017 at 21:58, Shuah Khan

Re: [PATCH] usb: dwc3-exynos fix unspecified suspend clk error handling

On 01/10/2017 11:23 AM, Bartlomiej Zolnierkiewicz wrote: > On Tuesday, January 10, 2017 07:03:57 PM Bartlomiej Zolnierkiewicz wrote: >> >> Hi, >> >> On Tuesday, January 10, 2017 11:23:38 PM Anand Moon wrote: >>> Hi Shuah, >>> >>> On 10 January 2017 at 21:58, Shuah Khan wrote: On 01/10/2017

Re: [PATCH] usb: dwc3-exynos fix unspecified suspend clk error handling

Hi Bartlomiej, On 10 January 2017 at 23:33, Bartlomiej Zolnierkiewicz wrote: > > Hi, > > On Tuesday, January 10, 2017 11:23:38 PM Anand Moon wrote: >> Hi Shuah, >> >> On 10 January 2017 at 21:58, Shuah Khan wrote: >> > On 01/10/2017 09:05 AM,

Re: [PATCH] usb: dwc3-exynos fix unspecified suspend clk error handling

Hi Bartlomiej, On 10 January 2017 at 23:33, Bartlomiej Zolnierkiewicz wrote: > > Hi, > > On Tuesday, January 10, 2017 11:23:38 PM Anand Moon wrote: >> Hi Shuah, >> >> On 10 January 2017 at 21:58, Shuah Khan wrote: >> > On 01/10/2017 09:05 AM, Bartlomiej Zolnierkiewicz wrote: >> >> >> >> Hi, >>

Re: [PATCH] usb: dwc3-exynos fix unspecified suspend clk error handling

On Tuesday, January 10, 2017 07:03:57 PM Bartlomiej Zolnierkiewicz wrote: > > Hi, > > On Tuesday, January 10, 2017 11:23:38 PM Anand Moon wrote: > > Hi Shuah, > > > > On 10 January 2017 at 21:58, Shuah Khan wrote: > > > On 01/10/2017 09:05 AM, Bartlomiej Zolnierkiewicz

Re: [PATCH] usb: dwc3-exynos fix unspecified suspend clk error handling

On Tuesday, January 10, 2017 07:03:57 PM Bartlomiej Zolnierkiewicz wrote: > > Hi, > > On Tuesday, January 10, 2017 11:23:38 PM Anand Moon wrote: > > Hi Shuah, > > > > On 10 January 2017 at 21:58, Shuah Khan wrote: > > > On 01/10/2017 09:05 AM, Bartlomiej Zolnierkiewicz wrote: > > >> > > >> Hi,

Re: [PATCH] usb: dwc3-exynos fix unspecified suspend clk error handling

On Tue, Jan 10, 2017 at 06:09:40PM +0100, Bartlomiej Zolnierkiewicz wrote: > BTW What is interesting is that the Exynos7 dts patch [2] has never > made it into upstream for some reason. In the meantime however > Exynos5433 (similar to Exynos7 to some degree) became the user of > susp_clk. > >

Re: [PATCH] usb: dwc3-exynos fix unspecified suspend clk error handling

On Tue, Jan 10, 2017 at 06:09:40PM +0100, Bartlomiej Zolnierkiewicz wrote: > BTW What is interesting is that the Exynos7 dts patch [2] has never > made it into upstream for some reason. In the meantime however > Exynos5433 (similar to Exynos7 to some degree) became the user of > susp_clk. > >

Re: [PATCH] usb: dwc3-exynos fix unspecified suspend clk error handling

Hi, On Tuesday, January 10, 2017 11:23:38 PM Anand Moon wrote: > Hi Shuah, > > On 10 January 2017 at 21:58, Shuah Khan wrote: > > On 01/10/2017 09:05 AM, Bartlomiej Zolnierkiewicz wrote: > >> > >> Hi, > >> > >> On Tuesday, January 10, 2017 07:36:35 AM Shuah Khan wrote:

Re: [PATCH] usb: dwc3-exynos fix unspecified suspend clk error handling

Hi, On Tuesday, January 10, 2017 11:23:38 PM Anand Moon wrote: > Hi Shuah, > > On 10 January 2017 at 21:58, Shuah Khan wrote: > > On 01/10/2017 09:05 AM, Bartlomiej Zolnierkiewicz wrote: > >> > >> Hi, > >> > >> On Tuesday, January 10, 2017 07:36:35 AM Shuah Khan wrote: > >>> On 01/10/2017

Re: [PATCH] usb: dwc3-exynos fix unspecified suspend clk error handling

Hi Shuah, On 10 January 2017 at 21:58, Shuah Khan wrote: > On 01/10/2017 09:05 AM, Bartlomiej Zolnierkiewicz wrote: >> >> Hi, >> >> On Tuesday, January 10, 2017 07:36:35 AM Shuah Khan wrote: >>> On 01/10/2017 07:16 AM, Shuah Khan wrote: On 01/10/2017 05:05 AM,

Re: [PATCH] usb: dwc3-exynos fix unspecified suspend clk error handling

Hi Shuah, On 10 January 2017 at 21:58, Shuah Khan wrote: > On 01/10/2017 09:05 AM, Bartlomiej Zolnierkiewicz wrote: >> >> Hi, >> >> On Tuesday, January 10, 2017 07:36:35 AM Shuah Khan wrote: >>> On 01/10/2017 07:16 AM, Shuah Khan wrote: On 01/10/2017 05:05 AM, Bartlomiej Zolnierkiewicz

Re: [PATCH] usb: dwc3-exynos fix unspecified suspend clk error handling

On 2017-01-10 22:39, Bartlomiej Zolnierkiewicz wrote: Hi, On Tuesday, January 10, 2017 09:28:52 AM Shuah Khan wrote: On 01/10/2017 09:05 AM, Bartlomiej Zolnierkiewicz wrote: > > Hi, > > On Tuesday, January 10, 2017 07:36:35 AM Shuah Khan wrote: >> On 01/10/2017 07:16 AM, Shuah Khan wrote: >>>

Re: [PATCH] usb: dwc3-exynos fix unspecified suspend clk error handling

On 2017-01-10 22:39, Bartlomiej Zolnierkiewicz wrote: Hi, On Tuesday, January 10, 2017 09:28:52 AM Shuah Khan wrote: On 01/10/2017 09:05 AM, Bartlomiej Zolnierkiewicz wrote: > > Hi, > > On Tuesday, January 10, 2017 07:36:35 AM Shuah Khan wrote: >> On 01/10/2017 07:16 AM, Shuah Khan wrote: >>>

Re: [PATCH] usb: dwc3-exynos fix unspecified suspend clk error handling

Hi, On Tuesday, January 10, 2017 09:28:52 AM Shuah Khan wrote: > On 01/10/2017 09:05 AM, Bartlomiej Zolnierkiewicz wrote: > > > > Hi, > > > > On Tuesday, January 10, 2017 07:36:35 AM Shuah Khan wrote: > >> On 01/10/2017 07:16 AM, Shuah Khan wrote: > >>> On 01/10/2017 05:05 AM, Bartlomiej

Re: [PATCH] usb: dwc3-exynos fix unspecified suspend clk error handling

Hi, On Tuesday, January 10, 2017 09:28:52 AM Shuah Khan wrote: > On 01/10/2017 09:05 AM, Bartlomiej Zolnierkiewicz wrote: > > > > Hi, > > > > On Tuesday, January 10, 2017 07:36:35 AM Shuah Khan wrote: > >> On 01/10/2017 07:16 AM, Shuah Khan wrote: > >>> On 01/10/2017 05:05 AM, Bartlomiej

Re: [PATCH] usb: dwc3-exynos fix unspecified suspend clk error handling

On 01/10/2017 09:05 AM, Bartlomiej Zolnierkiewicz wrote: > > Hi, > > On Tuesday, January 10, 2017 07:36:35 AM Shuah Khan wrote: >> On 01/10/2017 07:16 AM, Shuah Khan wrote: >>> On 01/10/2017 05:05 AM, Bartlomiej Zolnierkiewicz wrote: Hi, On Monday, January 09, 2017 07:21:31

Re: [PATCH] usb: dwc3-exynos fix unspecified suspend clk error handling

On 01/10/2017 09:05 AM, Bartlomiej Zolnierkiewicz wrote: > > Hi, > > On Tuesday, January 10, 2017 07:36:35 AM Shuah Khan wrote: >> On 01/10/2017 07:16 AM, Shuah Khan wrote: >>> On 01/10/2017 05:05 AM, Bartlomiej Zolnierkiewicz wrote: Hi, On Monday, January 09, 2017 07:21:31

Re: [PATCH] usb: dwc3-exynos fix unspecified suspend clk error handling

Hi, On Tuesday, January 10, 2017 07:36:35 AM Shuah Khan wrote: > On 01/10/2017 07:16 AM, Shuah Khan wrote: > > On 01/10/2017 05:05 AM, Bartlomiej Zolnierkiewicz wrote: > >> > >> Hi, > >> > >> On Monday, January 09, 2017 07:21:31 PM Shuah Khan wrote: > >>> Fix dwc3_exynos_probe() to call

Re: [PATCH] usb: dwc3-exynos fix unspecified suspend clk error handling

Hi, On Tuesday, January 10, 2017 07:36:35 AM Shuah Khan wrote: > On 01/10/2017 07:16 AM, Shuah Khan wrote: > > On 01/10/2017 05:05 AM, Bartlomiej Zolnierkiewicz wrote: > >> > >> Hi, > >> > >> On Monday, January 09, 2017 07:21:31 PM Shuah Khan wrote: > >>> Fix dwc3_exynos_probe() to call

Re: [PATCH] usb: dwc3-exynos fix unspecified suspend clk error handling

On 01/10/2017 07:16 AM, Shuah Khan wrote: > On 01/10/2017 05:05 AM, Bartlomiej Zolnierkiewicz wrote: >> >> Hi, >> >> On Monday, January 09, 2017 07:21:31 PM Shuah Khan wrote: >>> Fix dwc3_exynos_probe() to call clk_prepare_enable() only when suspend >>> clock is specified. Call

Re: [PATCH] usb: dwc3-exynos fix unspecified suspend clk error handling

On 01/10/2017 04:20 AM, Sergei Shtylyov wrote: > Hello! > > On 01/10/2017 05:21 AM, Shuah Khan wrote: > >> Fix dwc3_exynos_probe() to call clk_prepare_enable() only when suspend >> clock is specified. Call clk_disable_unprepare() from remove and probe >> error path only when susp_clk has been

Re: [PATCH] usb: dwc3-exynos fix unspecified suspend clk error handling

On 01/10/2017 04:20 AM, Sergei Shtylyov wrote: > Hello! > > On 01/10/2017 05:21 AM, Shuah Khan wrote: > >> Fix dwc3_exynos_probe() to call clk_prepare_enable() only when suspend >> clock is specified. Call clk_disable_unprepare() from remove and probe >> error path only when susp_clk has been

Re: [PATCH] usb: dwc3-exynos fix unspecified suspend clk error handling

On 01/10/2017 07:16 AM, Shuah Khan wrote: > On 01/10/2017 05:05 AM, Bartlomiej Zolnierkiewicz wrote: >> >> Hi, >> >> On Monday, January 09, 2017 07:21:31 PM Shuah Khan wrote: >>> Fix dwc3_exynos_probe() to call clk_prepare_enable() only when suspend >>> clock is specified. Call

Re: [PATCH] usb: dwc3-exynos fix unspecified suspend clk error handling

On 01/10/2017 05:05 AM, Bartlomiej Zolnierkiewicz wrote: > > Hi, > > On Monday, January 09, 2017 07:21:31 PM Shuah Khan wrote: >> Fix dwc3_exynos_probe() to call clk_prepare_enable() only when suspend >> clock is specified. Call clk_disable_unprepare() from remove and probe >> error path only

Re: [PATCH] usb: dwc3-exynos fix unspecified suspend clk error handling

On 01/10/2017 05:05 AM, Bartlomiej Zolnierkiewicz wrote: > > Hi, > > On Monday, January 09, 2017 07:21:31 PM Shuah Khan wrote: >> Fix dwc3_exynos_probe() to call clk_prepare_enable() only when suspend >> clock is specified. Call clk_disable_unprepare() from remove and probe >> error path only

Re: [PATCH] usb: dwc3-exynos fix unspecified suspend clk error handling

Hi, On Monday, January 09, 2017 07:21:31 PM Shuah Khan wrote: > Fix dwc3_exynos_probe() to call clk_prepare_enable() only when suspend > clock is specified. Call clk_disable_unprepare() from remove and probe > error path only when susp_clk has been set from remove and probe error > paths. It is

Re: [PATCH] usb: dwc3-exynos fix unspecified suspend clk error handling

Hi, On Monday, January 09, 2017 07:21:31 PM Shuah Khan wrote: > Fix dwc3_exynos_probe() to call clk_prepare_enable() only when suspend > clock is specified. Call clk_disable_unprepare() from remove and probe > error path only when susp_clk has been set from remove and probe error > paths. It is

Re: [PATCH] usb: dwc3-exynos fix unspecified suspend clk error handling

Hello! On 01/10/2017 05:21 AM, Shuah Khan wrote: Fix dwc3_exynos_probe() to call clk_prepare_enable() only when suspend clock is specified. Call clk_disable_unprepare() from remove and probe error path only when susp_clk has been set from remove and probe error paths. Signed-off-by: Shuah

Re: [PATCH] usb: dwc3-exynos fix unspecified suspend clk error handling

Hello! On 01/10/2017 05:21 AM, Shuah Khan wrote: Fix dwc3_exynos_probe() to call clk_prepare_enable() only when suspend clock is specified. Call clk_disable_unprepare() from remove and probe error path only when susp_clk has been set from remove and probe error paths. Signed-off-by: Shuah

[PATCH] usb: dwc3-exynos fix unspecified suspend clk error handling

Fix dwc3_exynos_probe() to call clk_prepare_enable() only when suspend clock is specified. Call clk_disable_unprepare() from remove and probe error path only when susp_clk has been set from remove and probe error paths. Signed-off-by: Shuah Khan ---

[PATCH] usb: dwc3-exynos fix unspecified suspend clk error handling

Fix dwc3_exynos_probe() to call clk_prepare_enable() only when suspend clock is specified. Call clk_disable_unprepare() from remove and probe error path only when susp_clk has been set from remove and probe error paths. Signed-off-by: Shuah Khan --- drivers/usb/dwc3/dwc3-exynos.c | 10