Re: [PATCH] usb: echi-hcd: Add ehci_setup check before echi_shutdown

2016-05-30 Thread Pramod Gurav
On 19 May 2016 at 15:42, Srinivas Kandagatla wrote: > Fixes 4bb3cad7125b ("usb: host: ehci-msm: Register usb shutdown function") > Signed-off-by: Srinivas Kandagatla Was seeing this crash while doing a reboot on db410c which is fixed with this patch: Tested-by: Pramod Gurav

Re: [PATCH] usb: echi-hcd: Add ehci_setup check before echi_shutdown

2016-05-20 Thread Andy Gross
On 20 May 2016 at 10:57, Alan Stern wrote: > On Fri, 20 May 2016, Andy Gross wrote: > >> On 20 May 2016 at 09:31, Alan Stern wrote: >> > On Thu, 19 May 2016, Andy Gross wrote: >> > >> >> On 19 May 2016 at 05:12, Srinivas Kandagatla >> >> wrote: >> >> >> >> >> >> >> >> > +++ b/drivers/usb/host/e

Re: [PATCH] usb: echi-hcd: Add ehci_setup check before echi_shutdown

2016-05-20 Thread Alan Stern
On Fri, 20 May 2016, Andy Gross wrote: > On 20 May 2016 at 09:31, Alan Stern wrote: > > On Thu, 19 May 2016, Andy Gross wrote: > > > >> On 19 May 2016 at 05:12, Srinivas Kandagatla > >> wrote: > >> > >> > >> > >> > +++ b/drivers/usb/host/ehci-hcd.c > >> > @@ -368,6 +368,15 @@ static void ehci_s

Re: [PATCH] usb: echi-hcd: Add ehci_setup check before echi_shutdown

2016-05-20 Thread Andy Gross
On 20 May 2016 at 09:31, Alan Stern wrote: > On Thu, 19 May 2016, Andy Gross wrote: > >> On 19 May 2016 at 05:12, Srinivas Kandagatla >> wrote: >> >> >> >> > +++ b/drivers/usb/host/ehci-hcd.c >> > @@ -368,6 +368,15 @@ static void ehci_shutdown(struct usb_hcd *hcd) >> > { >> > struct ehc

Re: [PATCH] usb: echi-hcd: Add ehci_setup check before echi_shutdown

2016-05-20 Thread Alan Stern
On Thu, 19 May 2016, Andy Gross wrote: > On 19 May 2016 at 05:12, Srinivas Kandagatla > wrote: > > > > > +++ b/drivers/usb/host/ehci-hcd.c > > @@ -368,6 +368,15 @@ static void ehci_shutdown(struct usb_hcd *hcd) > > { > > struct ehci_hcd *ehci = hcd_to_ehci(hcd); > > > > + /** >

Re: [PATCH] usb: echi-hcd: Add ehci_setup check before echi_shutdown

2016-05-19 Thread Andy Gross
On 19 May 2016 at 05:12, Srinivas Kandagatla wrote: > +++ b/drivers/usb/host/ehci-hcd.c > @@ -368,6 +368,15 @@ static void ehci_shutdown(struct usb_hcd *hcd) > { > struct ehci_hcd *ehci = hcd_to_ehci(hcd); > > + /** > +* Protect the system from crashing at system shutdown

Re: [PATCH] usb: echi-hcd: Add ehci_setup check before echi_shutdown

2016-05-19 Thread Andy Gross
On 19 May 2016 at 05:12, Srinivas Kandagatla wrote: > This patch protects system from crashing at shutdown in > cases where usb host is not added yet from OTG controller driver. > As ehci_setup() not done yet, so stop accessing registers or > variables initialized as part of ehci_setup(). > > The

Re: [PATCH] usb: echi-hcd: Add ehci_setup check before echi_shutdown

2016-05-19 Thread Alan Stern
On Thu, 19 May 2016, Srinivas Kandagatla wrote: > This patch protects system from crashing at shutdown in > cases where usb host is not added yet from OTG controller driver. > As ehci_setup() not done yet, so stop accessing registers or > variables initialized as part of ehci_setup(). > > The use

[PATCH] usb: echi-hcd: Add ehci_setup check before echi_shutdown

2016-05-19 Thread Srinivas Kandagatla
This patch protects system from crashing at shutdown in cases where usb host is not added yet from OTG controller driver. As ehci_setup() not done yet, so stop accessing registers or variables initialized as part of ehci_setup(). The use case is simple, for boards like DB410c where the usb host or