Re: [PATCH] usb: f_fs: Drop check on Reserved1 field on OS_DESC_EXT_COMPAT

2017-11-27 Thread Felipe Balbi
Hi, John Keeping writes: > On Mon, 13 Nov 2017 12:57:21 +0200, Felipe Balbi wrote: >> Good point. Then how about we just force the value to 1 in f_fs.c and >> remove the check? > > That seems reasonable. Something like this? > > -- >8 -- > Subject: [PATCH] usb: f_fs: Force

Re: [PATCH] usb: f_fs: Drop check on Reserved1 field on OS_DESC_EXT_COMPAT

2017-11-27 Thread Felipe Balbi
Hi, John Keeping writes: > On Mon, 13 Nov 2017 12:57:21 +0200, Felipe Balbi wrote: >> Good point. Then how about we just force the value to 1 in f_fs.c and >> remove the check? > > That seems reasonable. Something like this? > > -- >8 -- > Subject: [PATCH] usb: f_fs: Force Reserved1=1 in

Re: [PATCH] usb: f_fs: Drop check on Reserved1 field on OS_DESC_EXT_COMPAT

2017-11-13 Thread John Keeping
On Mon, 13 Nov 2017 12:57:21 +0200, Felipe Balbi wrote: > Good point. Then how about we just force the value to 1 in f_fs.c and > remove the check? That seems reasonable. Something like this? -- >8 -- Subject: [PATCH] usb: f_fs: Force Reserved1=1 in OS_DESC_EXT_COMPAT The specification says

Re: [PATCH] usb: f_fs: Drop check on Reserved1 field on OS_DESC_EXT_COMPAT

2017-11-13 Thread John Keeping
On Mon, 13 Nov 2017 12:57:21 +0200, Felipe Balbi wrote: > Good point. Then how about we just force the value to 1 in f_fs.c and > remove the check? That seems reasonable. Something like this? -- >8 -- Subject: [PATCH] usb: f_fs: Force Reserved1=1 in OS_DESC_EXT_COMPAT The specification says

Re: [PATCH] usb: f_fs: Drop check on Reserved1 field on OS_DESC_EXT_COMPAT

2017-11-13 Thread Felipe Balbi
Hi, John Keeping writes: > On Fri, 10 Nov 2017 12:40:39 +0200, Felipe Balbi wrote: > >> John Keeping writes: >> > This check has gone through several incompatible variations in commits >> > 53642399aa71 ("usb: gadget: f_fs: Fix wrong check on reserved1 of

Re: [PATCH] usb: f_fs: Drop check on Reserved1 field on OS_DESC_EXT_COMPAT

2017-11-13 Thread Felipe Balbi
Hi, John Keeping writes: > On Fri, 10 Nov 2017 12:40:39 +0200, Felipe Balbi wrote: > >> John Keeping writes: >> > This check has gone through several incompatible variations in commits >> > 53642399aa71 ("usb: gadget: f_fs: Fix wrong check on reserved1 of >> > OS_DESC_EXT_COMPAT"),

Re: [PATCH] usb: f_fs: Drop check on Reserved1 field on OS_DESC_EXT_COMPAT

2017-11-10 Thread John Keeping
On Fri, 10 Nov 2017 12:40:39 +0200, Felipe Balbi wrote: > John Keeping writes: > > This check has gone through several incompatible variations in commits > > 53642399aa71 ("usb: gadget: f_fs: Fix wrong check on reserved1 of > > OS_DESC_EXT_COMPAT"), 354bc45bf329 ("usb: gadget:

Re: [PATCH] usb: f_fs: Drop check on Reserved1 field on OS_DESC_EXT_COMPAT

2017-11-10 Thread John Keeping
On Fri, 10 Nov 2017 12:40:39 +0200, Felipe Balbi wrote: > John Keeping writes: > > This check has gone through several incompatible variations in commits > > 53642399aa71 ("usb: gadget: f_fs: Fix wrong check on reserved1 of > > OS_DESC_EXT_COMPAT"), 354bc45bf329 ("usb: gadget: f_fs: Fix

Re: [PATCH] usb: f_fs: Drop check on Reserved1 field on OS_DESC_EXT_COMPAT

2017-11-10 Thread Felipe Balbi
Hi, John Keeping writes: > This check has gone through several incompatible variations in commits > 53642399aa71 ("usb: gadget: f_fs: Fix wrong check on reserved1 of > OS_DESC_EXT_COMPAT"), 354bc45bf329 ("usb: gadget: f_fs: Fix ExtCompat > descriptor validation") and

Re: [PATCH] usb: f_fs: Drop check on Reserved1 field on OS_DESC_EXT_COMPAT

2017-11-10 Thread Felipe Balbi
Hi, John Keeping writes: > This check has gone through several incompatible variations in commits > 53642399aa71 ("usb: gadget: f_fs: Fix wrong check on reserved1 of > OS_DESC_EXT_COMPAT"), 354bc45bf329 ("usb: gadget: f_fs: Fix ExtCompat > descriptor validation") and 3ba534df815f ("Revert "usb:

[PATCH] usb: f_fs: Drop check on Reserved1 field on OS_DESC_EXT_COMPAT

2017-11-09 Thread John Keeping
This check has gone through several incompatible variations in commits 53642399aa71 ("usb: gadget: f_fs: Fix wrong check on reserved1 of OS_DESC_EXT_COMPAT"), 354bc45bf329 ("usb: gadget: f_fs: Fix ExtCompat descriptor validation") and 3ba534df815f ("Revert "usb: gadget: f_fs: Fix ExtCompat

[PATCH] usb: f_fs: Drop check on Reserved1 field on OS_DESC_EXT_COMPAT

2017-11-09 Thread John Keeping
This check has gone through several incompatible variations in commits 53642399aa71 ("usb: gadget: f_fs: Fix wrong check on reserved1 of OS_DESC_EXT_COMPAT"), 354bc45bf329 ("usb: gadget: f_fs: Fix ExtCompat descriptor validation") and 3ba534df815f ("Revert "usb: gadget: f_fs: Fix ExtCompat