Re: [PATCH] usb: gadget: ncm: correct endianess conversion

2012-11-10 Thread Dmytro Milinevskyy
Hi, On Fri, Nov 9, 2012 at 12:53 PM, Felipe Balbi wrote: > Hi, > > On Fri, Nov 09, 2012 at 10:31:47AM +0100, Dmytro Milinevskyy wrote: >> Hi Felipe, >> >> On Thu, Nov 8, 2012 at 8:30 PM, Felipe Balbi wrote: >> > Hi, >> > >> > On Thu, Nov 08, 2012 at 08:07:57PM +0100, Dmytro Milinevskyy wrote:

Re: [PATCH] usb: gadget: ncm: correct endianess conversion

2012-11-10 Thread Dmytro Milinevskyy
Hi, On Fri, Nov 9, 2012 at 12:53 PM, Felipe Balbi ba...@ti.com wrote: Hi, On Fri, Nov 09, 2012 at 10:31:47AM +0100, Dmytro Milinevskyy wrote: Hi Felipe, On Thu, Nov 8, 2012 at 8:30 PM, Felipe Balbi ba...@ti.com wrote: Hi, On Thu, Nov 08, 2012 at 08:07:57PM +0100, Dmytro Milinevskyy

Re: [PATCH] usb: gadget: ncm: correct endianess conversion

2012-11-09 Thread Felipe Balbi
Hi, On Fri, Nov 09, 2012 at 10:31:47AM +0100, Dmytro Milinevskyy wrote: > Hi Felipe, > > On Thu, Nov 8, 2012 at 8:30 PM, Felipe Balbi wrote: > > Hi, > > > > On Thu, Nov 08, 2012 at 08:07:57PM +0100, Dmytro Milinevskyy wrote: > >> > On Wed, Nov 07, 2012 at 02:14:00PM +0100, Dmytro Milinevskyy

Re: [PATCH] usb: gadget: ncm: correct endianess conversion

2012-11-09 Thread Dmytro Milinevskyy
Hi Felipe, On Thu, Nov 8, 2012 at 8:30 PM, Felipe Balbi wrote: > Hi, > > On Thu, Nov 08, 2012 at 08:07:57PM +0100, Dmytro Milinevskyy wrote: >> > On Wed, Nov 07, 2012 at 02:14:00PM +0100, Dmytro Milinevskyy wrote: >> >> Unfortunately I have some issues with git send-email. >> >> I've attached

Re: [PATCH] usb: gadget: ncm: correct endianess conversion

2012-11-09 Thread Dmytro Milinevskyy
Hi Felipe, On Thu, Nov 8, 2012 at 8:30 PM, Felipe Balbi ba...@ti.com wrote: Hi, On Thu, Nov 08, 2012 at 08:07:57PM +0100, Dmytro Milinevskyy wrote: On Wed, Nov 07, 2012 at 02:14:00PM +0100, Dmytro Milinevskyy wrote: Unfortunately I have some issues with git send-email. I've attached the

Re: [PATCH] usb: gadget: ncm: correct endianess conversion

2012-11-09 Thread Felipe Balbi
Hi, On Fri, Nov 09, 2012 at 10:31:47AM +0100, Dmytro Milinevskyy wrote: Hi Felipe, On Thu, Nov 8, 2012 at 8:30 PM, Felipe Balbi ba...@ti.com wrote: Hi, On Thu, Nov 08, 2012 at 08:07:57PM +0100, Dmytro Milinevskyy wrote: On Wed, Nov 07, 2012 at 02:14:00PM +0100, Dmytro Milinevskyy

Re: [PATCH] usb: gadget: ncm: correct endianess conversion

2012-11-08 Thread Felipe Balbi
Hi, On Thu, Nov 08, 2012 at 08:07:57PM +0100, Dmytro Milinevskyy wrote: > > On Wed, Nov 07, 2012 at 02:14:00PM +0100, Dmytro Milinevskyy wrote: > >> Unfortunately I have some issues with git send-email. > >> I've attached the patch itself .. > > > > I'll apply it like that this time, but try to

Re: [PATCH] usb: gadget: ncm: correct endianess conversion

2012-11-08 Thread Dmytro Milinevskyy
On Thu, Nov 8, 2012 at 3:06 PM, Felipe Balbi wrote: > Hi, > > (please, never top-post) > got it! > On Wed, Nov 07, 2012 at 02:14:00PM +0100, Dmytro Milinevskyy wrote: >> Unfortunately I have some issues with git send-email. >> I've attached the patch itself .. > > I'll apply it like that this

Re: [PATCH] usb: gadget: ncm: correct endianess conversion

2012-11-08 Thread Felipe Balbi
Hi, (please, never top-post) On Wed, Nov 07, 2012 at 02:14:00PM +0100, Dmytro Milinevskyy wrote: > Unfortunately I have some issues with git send-email. > I've attached the patch itself .. I'll apply it like that this time, but try to figure out how to send patches properly. We have some very

Re: [PATCH] usb: gadget: ncm: correct endianess conversion

2012-11-08 Thread Felipe Balbi
Hi, (please, never top-post) On Wed, Nov 07, 2012 at 02:14:00PM +0100, Dmytro Milinevskyy wrote: Unfortunately I have some issues with git send-email. I've attached the patch itself .. I'll apply it like that this time, but try to figure out how to send patches properly. We have some very

Re: [PATCH] usb: gadget: ncm: correct endianess conversion

2012-11-08 Thread Dmytro Milinevskyy
On Thu, Nov 8, 2012 at 3:06 PM, Felipe Balbi ba...@ti.com wrote: Hi, (please, never top-post) got it! On Wed, Nov 07, 2012 at 02:14:00PM +0100, Dmytro Milinevskyy wrote: Unfortunately I have some issues with git send-email. I've attached the patch itself .. I'll apply it like that this

Re: [PATCH] usb: gadget: ncm: correct endianess conversion

2012-11-08 Thread Felipe Balbi
Hi, On Thu, Nov 08, 2012 at 08:07:57PM +0100, Dmytro Milinevskyy wrote: On Wed, Nov 07, 2012 at 02:14:00PM +0100, Dmytro Milinevskyy wrote: Unfortunately I have some issues with git send-email. I've attached the patch itself .. I'll apply it like that this time, but try to figure out

Re: [PATCH] usb: gadget: ncm: correct endianess conversion

2012-11-07 Thread Dmytro Milinevskyy
Unfortunately I have some issues with git send-email. I've attached the patch itself .. regards, -- dmytro On Tue, Nov 6, 2012 at 12:27 PM, Felipe Balbi wrote: > On Sun, Nov 04, 2012 at 03:30:21PM +0100, Dmytro Milinevskyy wrote: >> Convert USB descriptor's fields to CPU byte order before using

Re: [PATCH] usb: gadget: ncm: correct endianess conversion

2012-11-07 Thread Dmytro Milinevskyy
Unfortunately I have some issues with git send-email. I've attached the patch itself .. regards, -- dmytro On Tue, Nov 6, 2012 at 12:27 PM, Felipe Balbi ba...@ti.com wrote: On Sun, Nov 04, 2012 at 03:30:21PM +0100, Dmytro Milinevskyy wrote: Convert USB descriptor's fields to CPU byte order

Re: [PATCH] usb: gadget: ncm: correct endianess conversion

2012-11-06 Thread Felipe Balbi
On Sun, Nov 04, 2012 at 03:30:21PM +0100, Dmytro Milinevskyy wrote: > Convert USB descriptor's fields to CPU byte order before using locally in USB > NCM gadget driver. > Tested on MIPS32 big-endian device. > > Signed-off-by: Dmytro Milinevskyy doesn't apply: $ patch -p1 --dry-run <

Re: [PATCH] usb: gadget: ncm: correct endianess conversion

2012-11-06 Thread Felipe Balbi
On Sun, Nov 04, 2012 at 03:30:21PM +0100, Dmytro Milinevskyy wrote: Convert USB descriptor's fields to CPU byte order before using locally in USB NCM gadget driver. Tested on MIPS32 big-endian device. Signed-off-by: Dmytro Milinevskyy milinevs...@gmail.com doesn't apply: $ patch -p1

[PATCH] usb: gadget: ncm: correct endianess conversion

2012-11-04 Thread Dmytro Milinevskyy
Convert USB descriptor's fields to CPU byte order before using locally in USB NCM gadget driver. Tested on MIPS32 big-endian device. Signed-off-by: Dmytro Milinevskyy --- drivers/usb/gadget/f_ncm.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git

Re: [PATCH] usb: gadget: ncm: correct endianess conversion

2012-11-04 Thread Dmytro Milinevskyy
Hum, you are right. It's pain to send anything via thunderbird. Resending. br, -- dmytro On Fri, Nov 2, 2012 at 12:46 PM, Sergei Shtylyov wrote: > Hello. > > > On 01-11-2012 19:16, Dmytro Milinevskyy wrote: > >> Convert USB descriptor's fields to CPU byte order before using locally in >> USB >>

Re: [PATCH] usb: gadget: ncm: correct endianess conversion

2012-11-04 Thread Dmytro Milinevskyy
Hum, you are right. It's pain to send anything via thunderbird. Resending. br, -- dmytro On Fri, Nov 2, 2012 at 12:46 PM, Sergei Shtylyov sshtyl...@mvista.com wrote: Hello. On 01-11-2012 19:16, Dmytro Milinevskyy wrote: Convert USB descriptor's fields to CPU byte order before using locally

[PATCH] usb: gadget: ncm: correct endianess conversion

2012-11-04 Thread Dmytro Milinevskyy
Convert USB descriptor's fields to CPU byte order before using locally in USB NCM gadget driver. Tested on MIPS32 big-endian device. Signed-off-by: Dmytro Milinevskyy milinevs...@gmail.com --- drivers/usb/gadget/f_ncm.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff

Re: [PATCH] usb: gadget: ncm: correct endianess conversion

2012-11-02 Thread Sergei Shtylyov
Hello. On 01-11-2012 19:16, Dmytro Milinevskyy wrote: Convert USB descriptor's fields to CPU byte order before using locally in USB NCM gadget driver. Tested on MIPS32 big-endian device. Signed-off-by: Dmytro Milinevskyy --- drivers/usb/gadget/f_ncm.c | 12 1 file changed,

Re: [PATCH] usb: gadget: ncm: correct endianess conversion

2012-11-02 Thread Sergei Shtylyov
Hello. On 01-11-2012 19:16, Dmytro Milinevskyy wrote: Convert USB descriptor's fields to CPU byte order before using locally in USB NCM gadget driver. Tested on MIPS32 big-endian device. Signed-off-by: Dmytro Milinevskyy milinevs...@gmail.com --- drivers/usb/gadget/f_ncm.c | 12

Re: [PATCH] usb: gadget: ncm: correct endianess conversion

2012-11-01 Thread Dmytro Milinevskyy
Hi Felipe, resent with requested formatting changes. cheers, -- dmytro On Wed, Oct 31, 2012 at 2:35 PM, Felipe Balbi wrote: > Hi, > > On Tue, Oct 30, 2012 at 10:44:27AM +0100, Dmytro Milinevskyy wrote: >> Convert USB descriptor's fields to CPU byte order before using locally in >> USB NCM

[PATCH] usb: gadget: ncm: correct endianess conversion

2012-11-01 Thread Dmytro Milinevskyy
Convert USB descriptor's fields to CPU byte order before using locally in USB NCM gadget driver. Tested on MIPS32 big-endian device. Signed-off-by: Dmytro Milinevskyy --- drivers/usb/gadget/f_ncm.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git

[PATCH] usb: gadget: ncm: correct endianess conversion

2012-11-01 Thread Dmytro Milinevskyy
Convert USB descriptor's fields to CPU byte order before using locally in USB NCM gadget driver. Tested on MIPS32 big-endian device. Signed-off-by: Dmytro Milinevskyy milinevs...@gmail.com --- drivers/usb/gadget/f_ncm.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff

Re: [PATCH] usb: gadget: ncm: correct endianess conversion

2012-11-01 Thread Dmytro Milinevskyy
Hi Felipe, resent with requested formatting changes. cheers, -- dmytro On Wed, Oct 31, 2012 at 2:35 PM, Felipe Balbi ba...@ti.com wrote: Hi, On Tue, Oct 30, 2012 at 10:44:27AM +0100, Dmytro Milinevskyy wrote: Convert USB descriptor's fields to CPU byte order before using locally in USB NCM

Re: [PATCH] usb: gadget: ncm: correct endianess conversion

2012-10-31 Thread Felipe Balbi
Hi, On Tue, Oct 30, 2012 at 10:44:27AM +0100, Dmytro Milinevskyy wrote: > Convert USB descriptor's fields to CPU byte order before using locally in USB > NCM gadget driver. > Tested on MIPS32 big-endian device. > > Signed-off-by: Dmytro Milinevskyy > --- > drivers/usb/gadget/f_ncm.c | 12

Re: [PATCH] usb: gadget: ncm: correct endianess conversion

2012-10-31 Thread Felipe Balbi
On Sun, Oct 28, 2012 at 06:48:29PM +0100, Sebastian Andrzej Siewior wrote: > On Sun, Oct 28, 2012 at 06:30:02PM +0100, Dmytro Milinevskyy wrote: > > I was trying to keep 2 tabs but checkpatch didn't accept long line > > that's why I killed extra tab. > > Then move them to the code section instead

Re: [PATCH] usb: gadget: ncm: correct endianess conversion

2012-10-31 Thread Felipe Balbi
On Sun, Oct 28, 2012 at 06:48:29PM +0100, Sebastian Andrzej Siewior wrote: On Sun, Oct 28, 2012 at 06:30:02PM +0100, Dmytro Milinevskyy wrote: I was trying to keep 2 tabs but checkpatch didn't accept long line that's why I killed extra tab. Then move them to the code section instead to

Re: [PATCH] usb: gadget: ncm: correct endianess conversion

2012-10-31 Thread Felipe Balbi
Hi, On Tue, Oct 30, 2012 at 10:44:27AM +0100, Dmytro Milinevskyy wrote: Convert USB descriptor's fields to CPU byte order before using locally in USB NCM gadget driver. Tested on MIPS32 big-endian device. Signed-off-by: Dmytro Milinevskyy milinevs...@gmail.com ---

[PATCH] usb: gadget: ncm: correct endianess conversion

2012-10-30 Thread Dmytro Milinevskyy
Convert USB descriptor's fields to CPU byte order before using locally in USB NCM gadget driver. Tested on MIPS32 big-endian device. Signed-off-by: Dmytro Milinevskyy --- drivers/usb/gadget/f_ncm.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git

[PATCH] usb: gadget: ncm: correct endianess conversion

2012-10-30 Thread Dmytro Milinevskyy
Convert USB descriptor's fields to CPU byte order before using locally in USB NCM gadget driver. Tested on MIPS32 big-endian device. Signed-off-by: Dmytro Milinevskyy milinevs...@gmail.com --- drivers/usb/gadget/f_ncm.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff

Re: [PATCH] usb: gadget: ncm: correct endianess conversion

2012-10-28 Thread Sebastian Andrzej Siewior
On Sun, Oct 28, 2012 at 06:30:02PM +0100, Dmytro Milinevskyy wrote: > I was trying to keep 2 tabs but checkpatch didn't accept long line > that's why I killed extra tab. Then move them to the code section instead to initialize them in the declaration section. > >How does it work? Is the test on

Re: [PATCH] usb: gadget: ncm: correct endianess conversion

2012-10-28 Thread Dmytro Milinevskyy
Hi Sebastian, I was trying to keep 2 tabs but checkpatch didn't accept long line that's why I killed extra tab. >How does it work? Is the test on host side not strict enough? The host part(cdc_ncm) does not check this field. However I agree that at least on device side this should be corrected.

Re: [PATCH] usb: gadget: ncm: correct endianess conversion

2012-10-28 Thread Dmytro Milinevskyy
Hi Sebastian, I was trying to keep 2 tabs but checkpatch didn't accept long line that's why I killed extra tab. How does it work? Is the test on host side not strict enough? The host part(cdc_ncm) does not check this field. However I agree that at least on device side this should be corrected.

Re: [PATCH] usb: gadget: ncm: correct endianess conversion

2012-10-28 Thread Sebastian Andrzej Siewior
On Sun, Oct 28, 2012 at 06:30:02PM +0100, Dmytro Milinevskyy wrote: I was trying to keep 2 tabs but checkpatch didn't accept long line that's why I killed extra tab. Then move them to the code section instead to initialize them in the declaration section. How does it work? Is the test on host

Re: [PATCH] usb: gadget: ncm: correct endianess conversion

2012-10-24 Thread Sebastian Andrzej Siewior
On Mon, Oct 08, 2012 at 11:59:03PM +0300, Dmytro Milinevskyy wrote: > Convert USB descriptor's fields to CPU byte order before using locally in USB > NCM gadget driver. > Tested on MIPS32 big-endian device. > > Signed-off-by: Dmytro Milinevskyy > --- > drivers/usb/gadget/f_ncm.c | 10

Re: [PATCH] usb: gadget: ncm: correct endianess conversion

2012-10-24 Thread Sebastian Andrzej Siewior
On Mon, Oct 08, 2012 at 11:59:03PM +0300, Dmytro Milinevskyy wrote: Convert USB descriptor's fields to CPU byte order before using locally in USB NCM gadget driver. Tested on MIPS32 big-endian device. Signed-off-by: Dmytro Milinevskyy milinevs...@gmail.com --- drivers/usb/gadget/f_ncm.c

[PATCH] usb: gadget: ncm: correct endianess conversion

2012-10-08 Thread Dmytro Milinevskyy
Convert USB descriptor's fields to CPU byte order before using locally in USB NCM gadget driver. Tested on MIPS32 big-endian device. Signed-off-by: Dmytro Milinevskyy --- drivers/usb/gadget/f_ncm.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git

Re: [PATCH] usb: gadget: ncm: correct endianess conversion

2012-10-08 Thread Felipe Balbi
On Fri, Oct 05, 2012 at 01:58:21AM +0300, Dmytro Milinevskyy wrote: > > Signed-off-by: Dmytro Milinevskyy missing commit log. NAK. Just resend with a proper commit log and I can apply. -- balbi signature.asc Description: Digital signature

Re: [PATCH] usb: gadget: ncm: correct endianess conversion

2012-10-08 Thread Felipe Balbi
On Fri, Oct 05, 2012 at 01:58:21AM +0300, Dmytro Milinevskyy wrote: Signed-off-by: Dmytro Milinevskyy milinevs...@gmail.com missing commit log. NAK. Just resend with a proper commit log and I can apply. -- balbi signature.asc Description: Digital signature

[PATCH] usb: gadget: ncm: correct endianess conversion

2012-10-08 Thread Dmytro Milinevskyy
Convert USB descriptor's fields to CPU byte order before using locally in USB NCM gadget driver. Tested on MIPS32 big-endian device. Signed-off-by: Dmytro Milinevskyy milinevs...@gmail.com --- drivers/usb/gadget/f_ncm.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff

[PATCH] usb: gadget: ncm: correct endianess conversion

2012-10-04 Thread Dmytro Milinevskyy
Signed-off-by: Dmytro Milinevskyy --- drivers/usb/gadget/f_ncm.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/usb/gadget/f_ncm.c b/drivers/usb/gadget/f_ncm.c index b651b52..fce45ab 100644 --- a/drivers/usb/gadget/f_ncm.c +++ b/drivers/usb/gadget/f_ncm.c

[PATCH] usb: gadget: ncm: correct endianess conversion

2012-10-04 Thread Dmytro Milinevskyy
Signed-off-by: Dmytro Milinevskyy milinevs...@gmail.com --- drivers/usb/gadget/f_ncm.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/usb/gadget/f_ncm.c b/drivers/usb/gadget/f_ncm.c index b651b52..fce45ab 100644 --- a/drivers/usb/gadget/f_ncm.c +++