On Wed, Aug 27, 2014 at 11:09:08PM +0200, Bjørn Mork wrote:
> Greg Kroah-Hartman writes:
> > On Wed, Aug 27, 2014 at 09:39:43PM +0200, Ricardo Ribalda Delgado wrote:
> >>
> >> return sprintf(buf, "pci:v%08Xd%08Xsv%08Xsd%08Xbc%02Xsc%02Xi%02x\n",
>
> That final 'x' does look like a typo, doesn't
On Wed, Aug 27, 2014 at 11:03:00PM +0200, Ricardo Ribalda Delgado wrote:
> Hello Greg
>
> >>
> >> Not many drivers define the pci interface and there is no other driver
> >> that has the same vendor and product id. Therefore I see no hurt in
> >> adding both patches, one to make the driver
Greg Kroah-Hartman writes:
> On Wed, Aug 27, 2014 at 09:39:43PM +0200, Ricardo Ribalda Delgado wrote:
>>
>> return sprintf(buf, "pci:v%08Xd%08Xsv%08Xsd%08Xbc%02Xsc%02Xi%02x\n",
That final 'x' does look like a typo, doesn't it? We are otherwise
consistently using upper-case hex digits for field
Hello Greg
>>
>> Not many drivers define the pci interface and there is no other driver
>> that has the same vendor and product id. Therefore I see no hurt in
>> adding both patches, one to make the driver broader, and another to
>> fix pci-sysfs.
>>
>> Also, the change on pci-sysfs might affect
On Wed, Aug 27, 2014 at 09:39:43PM +0200, Ricardo Ribalda Delgado wrote:
> Hello Greg
>
>
>
>
>
> On Wed, Aug 27, 2014 at 9:25 PM, Greg Kroah-Hartman
> wrote:
> > On Wed, Aug 27, 2014 at 03:00:29PM +0200, Ricardo Ribalda Delgado wrote:
> >> Defining the vendor and the product id should be
Hello Greg
On Wed, Aug 27, 2014 at 9:25 PM, Greg Kroah-Hartman
wrote:
> On Wed, Aug 27, 2014 at 03:00:29PM +0200, Ricardo Ribalda Delgado wrote:
>> Defining the vendor and the product id should be enough to discriminate
>> the device.
>>
>> The reason for this patch is that there is a
On Wed, Aug 27, 2014 at 03:00:29PM +0200, Ricardo Ribalda Delgado wrote:
> Defining the vendor and the product id should be enough to discriminate
> the device.
>
> The reason for this patch is that there is a missmatch betweed the
> modalias showed by sysfs and the modalias generated by
Defining the vendor and the product id should be enough to discriminate
the device.
The reason for this patch is that there is a missmatch betweed the
modalias showed by sysfs and the modalias generated by file2alias.
One expects the programming interface in uppercase and the other
generates it
Defining the vendor and the product id should be enough to discriminate
the device.
The reason for this patch is that there is a missmatch betweed the
modalias showed by sysfs and the modalias generated by file2alias.
One expects the programming interface in uppercase and the other
generates it
On Wed, Aug 27, 2014 at 03:00:29PM +0200, Ricardo Ribalda Delgado wrote:
Defining the vendor and the product id should be enough to discriminate
the device.
The reason for this patch is that there is a missmatch betweed the
modalias showed by sysfs and the modalias generated by file2alias.
Hello Greg
On Wed, Aug 27, 2014 at 9:25 PM, Greg Kroah-Hartman
gre...@linuxfoundation.org wrote:
On Wed, Aug 27, 2014 at 03:00:29PM +0200, Ricardo Ribalda Delgado wrote:
Defining the vendor and the product id should be enough to discriminate
the device.
The reason for this patch is that
On Wed, Aug 27, 2014 at 09:39:43PM +0200, Ricardo Ribalda Delgado wrote:
Hello Greg
On Wed, Aug 27, 2014 at 9:25 PM, Greg Kroah-Hartman
gre...@linuxfoundation.org wrote:
On Wed, Aug 27, 2014 at 03:00:29PM +0200, Ricardo Ribalda Delgado wrote:
Defining the vendor and the product id
Hello Greg
Not many drivers define the pci interface and there is no other driver
that has the same vendor and product id. Therefore I see no hurt in
adding both patches, one to make the driver broader, and another to
fix pci-sysfs.
Also, the change on pci-sysfs might affect more stuff
Greg Kroah-Hartman gre...@linuxfoundation.org writes:
On Wed, Aug 27, 2014 at 09:39:43PM +0200, Ricardo Ribalda Delgado wrote:
return sprintf(buf, pci:v%08Xd%08Xsv%08Xsd%08Xbc%02Xsc%02Xi%02x\n,
That final 'x' does look like a typo, doesn't it? We are otherwise
consistently using upper-case
On Wed, Aug 27, 2014 at 11:03:00PM +0200, Ricardo Ribalda Delgado wrote:
Hello Greg
Not many drivers define the pci interface and there is no other driver
that has the same vendor and product id. Therefore I see no hurt in
adding both patches, one to make the driver broader, and
On Wed, Aug 27, 2014 at 11:09:08PM +0200, Bjørn Mork wrote:
Greg Kroah-Hartman gre...@linuxfoundation.org writes:
On Wed, Aug 27, 2014 at 09:39:43PM +0200, Ricardo Ribalda Delgado wrote:
return sprintf(buf, pci:v%08Xd%08Xsv%08Xsd%08Xbc%02Xsc%02Xi%02x\n,
That final 'x' does look like a
16 matches
Mail list logo
