Re: [PATCH] usb: gadget: udc-core: call udc_stop() before gadget unbind

2014-12-29 Thread Felipe Balbi
On Mon, Dec 29, 2014 at 08:30:04AM +0100, Robert Baldyga wrote: > Hi Felipe, > > On 12/23/2014 07:31 PM, Felipe Balbi wrote: > > On Tue, Dec 23, 2014 at 07:34:15AM +0100, Robert Baldyga wrote: > >> On 12/22/2014 05:34 PM, Felipe Balbi wrote: > >>> On Mon, Dec 15, 2014 at 11:05:22AM +0100, Robert B

Re: [PATCH] usb: gadget: udc-core: call udc_stop() before gadget unbind

2014-12-28 Thread Robert Baldyga
Hi Felipe, On 12/23/2014 07:31 PM, Felipe Balbi wrote: > On Tue, Dec 23, 2014 at 07:34:15AM +0100, Robert Baldyga wrote: >> On 12/22/2014 05:34 PM, Felipe Balbi wrote: >>> On Mon, Dec 15, 2014 at 11:05:22AM +0100, Robert Baldyga wrote: On 12/15/2014 06:13 AM, Peter Chen wrote: > On Fri, D

Re: [PATCH] usb: gadget: udc-core: call udc_stop() before gadget unbind

2014-12-23 Thread Felipe Balbi
On Tue, Dec 23, 2014 at 07:34:15AM +0100, Robert Baldyga wrote: > Hi Felipe, > > On 12/22/2014 05:34 PM, Felipe Balbi wrote: > > On Mon, Dec 15, 2014 at 11:05:22AM +0100, Robert Baldyga wrote: > >> On 12/15/2014 06:13 AM, Peter Chen wrote: > >>> On Fri, Dec 12, 2014 at 02:17:28PM +0100, Robert Bal

Re: [PATCH] usb: gadget: udc-core: call udc_stop() before gadget unbind

2014-12-22 Thread Robert Baldyga
Hi Felipe, On 12/22/2014 05:34 PM, Felipe Balbi wrote: > On Mon, Dec 15, 2014 at 11:05:22AM +0100, Robert Baldyga wrote: >> On 12/15/2014 06:13 AM, Peter Chen wrote: >>> On Fri, Dec 12, 2014 at 02:17:28PM +0100, Robert Baldyga wrote: As usb function drivers assumes that all usb request will b

Re: [PATCH] usb: gadget: udc-core: call udc_stop() before gadget unbind

2014-12-22 Thread Felipe Balbi
On Mon, Dec 15, 2014 at 11:05:22AM +0100, Robert Baldyga wrote: > On 12/15/2014 06:13 AM, Peter Chen wrote: > > On Fri, Dec 12, 2014 at 02:17:28PM +0100, Robert Baldyga wrote: > >> As usb function drivers assumes that all usb request will be completed > >> before function unbind call, we should sup

Re: [PATCH] usb: gadget: udc-core: call udc_stop() before gadget unbind

2014-12-22 Thread Felipe Balbi
On Fri, Dec 12, 2014 at 02:17:28PM +0100, Robert Baldyga wrote: > As usb function drivers assumes that all usb request will be completed > before function unbind call, we should supply such behavior. In some > cases ep_disable() won't kill all request effectively, because some > IN requests can be

Re: [PATCH] usb: gadget: udc-core: call udc_stop() before gadget unbind

2014-12-15 Thread Alan Stern
On Fri, 12 Dec 2014, Robert Baldyga wrote: > As usb function drivers assumes that all usb request will be completed > before function unbind call, we should supply such behavior. In some > cases ep_disable() won't kill all request effectively, because some > IN requests can be in running state. In

Re: [PATCH] usb: gadget: udc-core: call udc_stop() before gadget unbind

2014-12-15 Thread Robert Baldyga
On 12/15/2014 06:13 AM, Peter Chen wrote: > On Fri, Dec 12, 2014 at 02:17:28PM +0100, Robert Baldyga wrote: >> As usb function drivers assumes that all usb request will be completed >> before function unbind call, we should supply such behavior. In some >> cases ep_disable() won't kill all request

Re: [PATCH] usb: gadget: udc-core: call udc_stop() before gadget unbind

2014-12-14 Thread Peter Chen
On Fri, Dec 12, 2014 at 02:17:28PM +0100, Robert Baldyga wrote: > As usb function drivers assumes that all usb request will be completed > before function unbind call, we should supply such behavior. In some > cases ep_disable() won't kill all request effectively, because some > IN requests can be

RE: [PATCH] usb: gadget: udc-core: call udc_stop() before gadget unbind

2014-12-12 Thread Krzysztof Opasiak
zyprow...@samsung.com; k.opas...@samsung.com; Robert Baldyga > Subject: [PATCH] usb: gadget: udc-core: call udc_stop() before > gadget unbind > > As usb function drivers assumes that all usb request will be > completed > before function unbind call, we should supply such behavior. In

[PATCH] usb: gadget: udc-core: call udc_stop() before gadget unbind

2014-12-12 Thread Robert Baldyga
As usb function drivers assumes that all usb request will be completed before function unbind call, we should supply such behavior. In some cases ep_disable() won't kill all request effectively, because some IN requests can be in running state. In such situation it's possible to have unbind functio