Re: [PATCH] usb: host: xhci: mvebu: make USB 3.0 PHY optional for Armada 3720

2021-01-30 Thread Tomasz Maciej Nowak
W dniu 23.12.2020 o 17:24, Pali Rohár pisze: > Older ATF does not provide SMC call for USB 3.0 phy power on functionality > and therefore initialization of xhci-hcd is failing when older version of > ATF is used. In this case phy_power_on() function returns -EOPNOTSUPP. > > [3.108467] mvebu-a3

Re: [PATCH] usb: host: xhci: mvebu: make USB 3.0 PHY optional for Armada 3720

2021-01-30 Thread Tomasz Maciej Nowak
W dniu 30.01.2021 o 17:35, Pali Rohár pisze: > On Saturday 30 January 2021 17:31:41 Tomasz Maciej Nowak wrote: >> W dniu 23.12.2020 o 17:24, Pali Rohár pisze: >>> Older ATF does not provide SMC call for USB 3.0 phy power on functionality >>> and therefore initialization of xhci-hcd is failing when

Re: [PATCH] usb: host: xhci: mvebu: make USB 3.0 PHY optional for Armada 3720

2021-01-30 Thread Pali Rohár
On Saturday 30 January 2021 17:31:41 Tomasz Maciej Nowak wrote: > W dniu 23.12.2020 o 17:24, Pali Rohár pisze: > > Older ATF does not provide SMC call for USB 3.0 phy power on functionality > > and therefore initialization of xhci-hcd is failing when older version of > > ATF is used. In this case p

Re: [PATCH] usb: host: xhci: mvebu: make USB 3.0 PHY optional for Armada 3720

2020-12-28 Thread Pali Rohár
Hello! On Monday 28 December 2020 13:11:49 Marek Behun wrote: > Hi Pali and Miquel, > > On Wed, 23 Dec 2020 17:24:03 +0100 > Pali Rohár wrote: > > > int xhci_mvebu_a3700_init_quirk(struct usb_hcd *hcd) > > { > > struct xhci_hcd *xhci = hcd_to_xhci(hcd); > > + struct device *dev = hcd->s

Re: [PATCH] usb: host: xhci: mvebu: make USB 3.0 PHY optional for Armada 3720

2020-12-28 Thread Marek Behun
Hi Pali and Miquel, On Wed, 23 Dec 2020 17:24:03 +0100 Pali Rohár wrote: > int xhci_mvebu_a3700_init_quirk(struct usb_hcd *hcd) > { > struct xhci_hcd *xhci = hcd_to_xhci(hcd); > + struct device *dev = hcd->self.controller; > + struct phy *phy; > + int ret; > > /* With

RE: [PATCH] usb: host: xhci: mvebu: make USB 3.0 PHY optional for Armada 3720

2020-12-24 Thread Peter Chen
> > > > > > If not supported by ATF, then where to power on and off PHY since no other > place calls PHY APIs? Is it always on? > > > > Yes, in this case (when -EOPNOTSUPP is returned) SMC API is not > > supported by ATF, and PHY is always on. > > To make it clear, core/hcd.c function usb_add_hc

Re: [PATCH] usb: host: xhci: mvebu: make USB 3.0 PHY optional for Armada 3720

2020-12-24 Thread Pali Rohár
On Thursday 24 December 2020 14:24:01 Pali Rohár wrote: > On Thursday 24 December 2020 13:15:21 Peter Chen wrote: > > > > > > > + /* Old bindings miss the PHY handle */ > > > > > + phy = of_phy_get(dev->of_node, "usb3-phy"); > > > > > + if (IS_ERR(phy) && PTR_ERR(phy) == -EPROBE_DEFER

Re: [PATCH] usb: host: xhci: mvebu: make USB 3.0 PHY optional for Armada 3720

2020-12-24 Thread Pali Rohár
On Thursday 24 December 2020 13:15:21 Peter Chen wrote: > > > > > + /* Old bindings miss the PHY handle */ > > > > + phy = of_phy_get(dev->of_node, "usb3-phy"); > > > > + if (IS_ERR(phy) && PTR_ERR(phy) == -EPROBE_DEFER) > > > > + return -EPROBE_DEFER; > > > > > >

RE: [PATCH] usb: host: xhci: mvebu: make USB 3.0 PHY optional for Armada 3720

2020-12-24 Thread Peter Chen
> > > + /* Old bindings miss the PHY handle */ > > > + phy = of_phy_get(dev->of_node, "usb3-phy"); > > > + if (IS_ERR(phy) && PTR_ERR(phy) == -EPROBE_DEFER) > > > + return -EPROBE_DEFER; > > > > Doesn't need to judge IS_ERR(phy). > > Ok, I can remove it. I used same condition which is al

Re: [PATCH] usb: host: xhci: mvebu: make USB 3.0 PHY optional for Armada 3720

2020-12-24 Thread Pali Rohár
On Thursday 24 December 2020 05:54:55 Peter Chen wrote: > On 20-12-23 17:24:03, Pali Rohár wrote: > > Older ATF does not provide SMC call for USB 3.0 phy power on functionality > > and therefore initialization of xhci-hcd is failing when older version of > > ATF is used. In this case phy_power_on()

Re: [PATCH] usb: host: xhci: mvebu: make USB 3.0 PHY optional for Armada 3720

2020-12-23 Thread Peter Chen
On 20-12-23 17:24:03, Pali Rohár wrote: > Older ATF does not provide SMC call for USB 3.0 phy power on functionality > and therefore initialization of xhci-hcd is failing when older version of > ATF is used. In this case phy_power_on() function returns -EOPNOTSUPP. > > [3.108467] mvebu-a3700-c

[PATCH] usb: host: xhci: mvebu: make USB 3.0 PHY optional for Armada 3720

2020-12-23 Thread Pali Rohár
Older ATF does not provide SMC call for USB 3.0 phy power on functionality and therefore initialization of xhci-hcd is failing when older version of ATF is used. In this case phy_power_on() function returns -EOPNOTSUPP. [3.108467] mvebu-a3700-comphy d0018300.phy: unsupported SMC call, try upd