Re: [PATCH] usb: hub: wrong order of putting interfaces when processing hub events

2014-09-12 Thread Petr Mladek
On Fri 2014-09-12 10:06:03, Alan Stern wrote: > On Fri, 12 Sep 2014, Petr Mladek wrote: > > > usb_autopm_put_interface() must be called only when > > usb_autopm_get_interface() > > succeeded before. There was wrong ordering of the goto targets. > > No, you are wrong. The code is correct as it s

Re: [PATCH] usb: hub: wrong order of putting interfaces when processing hub events

2014-09-12 Thread Alan Stern
On Fri, 12 Sep 2014, Petr Mladek wrote: > usb_autopm_put_interface() must be called only when usb_autopm_get_interface() > succeeded before. There was wrong ordering of the goto targets. No, you are wrong. The code is correct as it stands. > The funny thing is that the names of the goto targets

[PATCH] usb: hub: wrong order of putting interfaces when processing hub events

2014-09-12 Thread Petr Mladek
usb_autopm_put_interface() must be called only when usb_autopm_get_interface() succeeded before. There was wrong ordering of the goto targets. The funny thing is that the names of the goto targets and the related comments were correct. Signed-off-by: Petr Mladek --- drivers/usb/core/hub.c | 4 +