Re: [PATCH] usb: musb: add printf attribute to log function

2021-01-07 Thread Bin Liu
Hi, On Tue, Dec 22, 2020 at 01:52:48AM -0800, Joe Perches wrote: > On Tue, 2020-12-22 at 09:52 +0100, Greg KH wrote: > > On Mon, Dec 21, 2020 at 08:25:47AM -0800, t...@redhat.com wrote: > > > From: Tom Rix > > > > > > Attributing the function allows the compiler to more thoroughly > > > check

Re: [PATCH] usb: musb: add printf attribute to log function

2020-12-22 Thread Joe Perches
On Tue, 2020-12-22 at 09:52 +0100, Greg KH wrote: > On Mon, Dec 21, 2020 at 08:25:47AM -0800, t...@redhat.com wrote: > > From: Tom Rix > > > > Attributing the function allows the compiler to more thoroughly > > check the use of the function with -Wformat and similar flags. > > > >

Re: [PATCH] usb: musb: add printf attribute to log function

2020-12-22 Thread Greg KH
On Mon, Dec 21, 2020 at 08:25:47AM -0800, t...@redhat.com wrote: > From: Tom Rix > > Attributing the function allows the compiler to more thoroughly > check the use of the function with -Wformat and similar flags. > > Signed-off-by: Tom Rix > --- > drivers/usb/musb/musb_debug.h | 1 + > 1

Re: [PATCH] usb: musb: add printf attribute to log function

2020-12-21 Thread Tom Rix
On 12/21/20 12:33 PM, Joe Perches wrote: > On Mon, 2020-12-21 at 08:25 -0800, t...@redhat.com wrote: >> From: Tom Rix >> >> Attributing the function allows the compiler to more thoroughly >> check the use of the function with -Wformat and similar flags. >> >> Signed-off-by: Tom Rix >> --- >>  

Re: [PATCH] usb: musb: add printf attribute to log function

2020-12-21 Thread Joe Perches
On Mon, 2020-12-21 at 08:25 -0800, t...@redhat.com wrote: > From: Tom Rix > > Attributing the function allows the compiler to more thoroughly > check the use of the function with -Wformat and similar flags. > > Signed-off-by: Tom Rix > --- >  drivers/usb/musb/musb_debug.h | 1 + >  1 file

[PATCH] usb: musb: add printf attribute to log function

2020-12-21 Thread trix
From: Tom Rix Attributing the function allows the compiler to more thoroughly check the use of the function with -Wformat and similar flags. Signed-off-by: Tom Rix --- drivers/usb/musb/musb_debug.h | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/musb/musb_debug.h