Re: [PATCH] usb: musb: remove unused variable 'devctl'

2020-11-20 Thread Alan Stern
On Fri, Nov 20, 2020 at 05:32:44PM +0100, Greg Kroah-Hartman wrote: > On Fri, Nov 20, 2020 at 11:15:19AM -0500, Alan Stern wrote: > > > Perhaps you might want to add a comment here so that people will not > > > keep making this same mistake when they run auto-checkers on the > > > codebase? > > >

Re: [PATCH] usb: musb: remove unused variable 'devctl'

2020-11-20 Thread Greg Kroah-Hartman
On Fri, Nov 20, 2020 at 11:15:19AM -0500, Alan Stern wrote: > On Fri, Nov 20, 2020 at 09:36:33AM +0100, Greg Kroah-Hartman wrote: > > On Fri, Nov 20, 2020 at 03:42:06PM +0800, Min Guo wrote: > > > On Fri, 2020-11-20 at 07:54 +0100, Greg Kroah-Hartman wrote: > > > > On Fri, Nov 20, 2020 at 02:48:50P

Re: [PATCH] usb: musb: remove unused variable 'devctl'

2020-11-20 Thread Alan Stern
On Fri, Nov 20, 2020 at 09:36:33AM +0100, Greg Kroah-Hartman wrote: > On Fri, Nov 20, 2020 at 03:42:06PM +0800, Min Guo wrote: > > On Fri, 2020-11-20 at 07:54 +0100, Greg Kroah-Hartman wrote: > > > On Fri, Nov 20, 2020 at 02:48:50PM +0800, Min Guo wrote: > > > > Hi greg k-h: > > > > On Wed, 2020-11

Re: [PATCH] usb: musb: remove unused variable 'devctl'

2020-11-20 Thread Greg Kroah-Hartman
On Fri, Nov 20, 2020 at 05:02:15PM +0800, Min Guo wrote: > On Fri, 2020-11-20 at 09:36 +0100, Greg Kroah-Hartman wrote: > > On Fri, Nov 20, 2020 at 03:42:06PM +0800, Min Guo wrote: > > > On Fri, 2020-11-20 at 07:54 +0100, Greg Kroah-Hartman wrote: > > > > On Fri, Nov 20, 2020 at 02:48:50PM +0800, M

Re: [PATCH] usb: musb: remove unused variable 'devctl'

2020-11-20 Thread Min Guo
On Fri, 2020-11-20 at 09:36 +0100, Greg Kroah-Hartman wrote: > On Fri, Nov 20, 2020 at 03:42:06PM +0800, Min Guo wrote: > > On Fri, 2020-11-20 at 07:54 +0100, Greg Kroah-Hartman wrote: > > > On Fri, Nov 20, 2020 at 02:48:50PM +0800, Min Guo wrote: > > > > Hi greg k-h: > > > > On Wed, 2020-11-18 at

Re: [PATCH] usb: musb: remove unused variable 'devctl'

2020-11-20 Thread Greg Kroah-Hartman
On Fri, Nov 20, 2020 at 03:42:06PM +0800, Min Guo wrote: > On Fri, 2020-11-20 at 07:54 +0100, Greg Kroah-Hartman wrote: > > On Fri, Nov 20, 2020 at 02:48:50PM +0800, Min Guo wrote: > > > Hi greg k-h: > > > On Wed, 2020-11-18 at 12:48 +0100, Greg Kroah-Hartman wrote: > > > > On Tue, Nov 17, 2020 at

Re: [PATCH] usb: musb: remove unused variable 'devctl'

2020-11-19 Thread Min Guo
On Fri, 2020-11-20 at 07:54 +0100, Greg Kroah-Hartman wrote: > On Fri, Nov 20, 2020 at 02:48:50PM +0800, Min Guo wrote: > > Hi greg k-h: > > On Wed, 2020-11-18 at 12:48 +0100, Greg Kroah-Hartman wrote: > > > On Tue, Nov 17, 2020 at 04:21:25PM +0800, min@mediatek.com wrote: > > > > From: Min Guo

Re: [PATCH] usb: musb: remove unused variable 'devctl'

2020-11-19 Thread Greg Kroah-Hartman
On Fri, Nov 20, 2020 at 02:48:50PM +0800, Min Guo wrote: > Hi greg k-h: > On Wed, 2020-11-18 at 12:48 +0100, Greg Kroah-Hartman wrote: > > On Tue, Nov 17, 2020 at 04:21:25PM +0800, min@mediatek.com wrote: > > > From: Min Guo > > > > > > Remove unused 'devctl' variable to fix compile warnings:

Re: [PATCH] usb: musb: remove unused variable 'devctl'

2020-11-19 Thread Min Guo
Hi greg k-h: On Wed, 2020-11-18 at 12:48 +0100, Greg Kroah-Hartman wrote: > On Tue, Nov 17, 2020 at 04:21:25PM +0800, min@mediatek.com wrote: > > From: Min Guo > > > > Remove unused 'devctl' variable to fix compile warnings: > > > > drivers/usb/musb/musbhsdma.c: In function 'dma_controll

Re: [PATCH] usb: musb: remove unused variable 'devctl'

2020-11-18 Thread Greg Kroah-Hartman
On Tue, Nov 17, 2020 at 04:21:25PM +0800, min@mediatek.com wrote: > From: Min Guo > > Remove unused 'devctl' variable to fix compile warnings: > > drivers/usb/musb/musbhsdma.c: In function 'dma_controller_irq': > drivers/usb/musb/musbhsdma.c:324:8: warning: variable 'devctl' set >

[PATCH] usb: musb: remove unused variable 'devctl'

2020-11-17 Thread min.guo
From: Min Guo Remove unused 'devctl' variable to fix compile warnings: drivers/usb/musb/musbhsdma.c: In function 'dma_controller_irq': drivers/usb/musb/musbhsdma.c:324:8: warning: variable 'devctl' set but not used [-Wunused-but-set-variable] Signed-off-by: Min Guo --- drivers/usb