Re: [PATCH] usb: remove redundant conditions

2015-12-10 Thread Felipe Balbi
Hi, "Geyslan G. Bem" writes: > 2015-12-10 12:13 GMT-03:00 Felipe Balbi : >> "Geyslan G. Bem" writes: >> >>> This patch removes redundant conditions. >>> >>> - (!A || (A && B)) is the same as (!A || B). >>> - (length && length > 5) can be reduced to a single evaluation. >>> >>> Caught by: cppc

Re: [PATCH] usb: remove redundant conditions

2015-12-10 Thread Geyslan G. Bem
2015-12-10 12:29 GMT-03:00 Geyslan G. Bem : > 2015-12-10 12:17 GMT-03:00 David Laight : >> From: Felipe Balbi >>> Sent: 10 December 2015 15:14 >>> "Geyslan G. Bem" writes: >>> >>> > This patch removes redundant conditions. >>> > >>> > - (!A || (A && B)) is the same as (!A || B). >>> > - (length

Re: [PATCH] usb: remove redundant conditions

2015-12-10 Thread Geyslan G. Bem
2015-12-10 12:17 GMT-03:00 David Laight : > From: Felipe Balbi >> Sent: 10 December 2015 15:14 >> "Geyslan G. Bem" writes: >> >> > This patch removes redundant conditions. >> > >> > - (!A || (A && B)) is the same as (!A || B). >> > - (length && length > 5) can be reduced to a single evaluation.

RE: [PATCH] usb: remove redundant conditions

2015-12-10 Thread David Laight
From: Felipe Balbi > Sent: 10 December 2015 15:14 > "Geyslan G. Bem" writes: > > > This patch removes redundant conditions. > > > > - (!A || (A && B)) is the same as (!A || B). > > - (length && length > 5) can be reduced to a single evaluation. > > > > Caught by: cppcheck > > > > Signed-off-by:

Re: [PATCH] usb: remove redundant conditions

2015-12-10 Thread Geyslan G. Bem
2015-12-10 12:13 GMT-03:00 Felipe Balbi : > "Geyslan G. Bem" writes: > >> This patch removes redundant conditions. >> >> - (!A || (A && B)) is the same as (!A || B). >> - (length && length > 5) can be reduced to a single evaluation. >> >> Caught by: cppcheck >> >> Signed-off-by: Geyslan G. Bem

Re: [PATCH] usb: remove redundant conditions

2015-12-10 Thread Felipe Balbi
"Geyslan G. Bem" writes: > This patch removes redundant conditions. > > - (!A || (A && B)) is the same as (!A || B). > - (length && length > 5) can be reduced to a single evaluation. > > Caught by: cppcheck > > Signed-off-by: Geyslan G. Bem > --- I guess you didn't get previous comment in tim

Re: [PATCH] usb: remove redundant conditions

2015-12-10 Thread Geyslan G. Bem
2015-12-10 11:50 GMT-03:00 Felipe Balbi : > > Hi, > > "Geyslan G. Bem" writes: >> This patch removes redundant conditions. >> >> - (!A || (A && B)) is the same as (!A || B). >> - (length && length > 5) can be reduced to a single evaluation. >> >> Caught by: cppcheck >> >> Signed-off-by: Geyslan

Re: [PATCH] usb: remove redundant conditions

2015-12-10 Thread Felipe Balbi
Hi, "Geyslan G. Bem" writes: > This patch removes redundant conditions. > > - (!A || (A && B)) is the same as (!A || B). > - (length && length > 5) can be reduced to a single evaluation. > > Caught by: cppcheck > > Signed-off-by: Geyslan G. Bem Can you split this into one patch per driver, t

Re: [PATCH] usb: remove redundant conditions

2015-12-10 Thread Geyslan G. Bem
2015-12-10 7:44 GMT-03:00 Johan Hovold : > On Wed, Dec 09, 2015 at 10:52:42PM -0300, Geyslan G. Bem wrote: >> This patch removes redundant conditions. >> >> - (!A || (A && B)) is the same as (!A || B). >> - (length && length > 5) can be reduced to a single evaluation. >> >> Caught by: cppcheck >>

Re: [PATCH] usb: remove redundant conditions

2015-12-10 Thread Johan Hovold
On Wed, Dec 09, 2015 at 10:52:42PM -0300, Geyslan G. Bem wrote: > This patch removes redundant conditions. > > - (!A || (A && B)) is the same as (!A || B). > - (length && length > 5) can be reduced to a single evaluation. > > Caught by: cppcheck > > Signed-off-by: Geyslan G. Bem > --- > driv

[PATCH] usb: remove redundant conditions

2015-12-09 Thread Geyslan G. Bem
This patch removes redundant conditions. - (!A || (A && B)) is the same as (!A || B). - (length && length > 5) can be reduced to a single evaluation. Caught by: cppcheck Signed-off-by: Geyslan G. Bem --- drivers/usb/gadget/udc/s3c-hsudc.c | 2 +- drivers/usb/host/fhci-sched.c | 2 +-