Re: [PATCH] usb: typec: anx7688: Add driver for ANX7688 USB-C HDMI bridge

2024-02-09 Thread Pavel Machek
Hi! > > From: Ondrej Jirman > > > > This is driver for ANX7688 USB-C HDMI, with flashing and debugging > > features removed. ANX7688 is rather criticial piece on PinePhone, > > there's no display and no battery charging without it. > > Don't remove the flashing part. Some Pinephones come

Re: [PATCH] usb: typec: anx7688: Add driver for ANX7688 USB-C HDMI bridge

2024-02-03 Thread Ondřej Jirman
Hi Pavel, On Thu, Feb 01, 2024 at 11:41:56AM +0100, Pavel Machek wrote: > From: Ondrej Jirman > > This is driver for ANX7688 USB-C HDMI, with flashing and debugging > features removed. ANX7688 is rather criticial piece on PinePhone, > there's no display and no battery charging without it.

Re: [PATCH] usb: typec: anx7688: Add driver for ANX7688 USB-C HDMI bridge

2024-02-02 Thread Pavel Machek
Hi! > > --- /dev/null > > +++ b/drivers/usb/typec/anx7688.c > > @@ -0,0 +1,1866 @@ > > +/* > > + * ANX7688 USB-C HDMI bridge/PD driver > > + * > > > > Did this pass checkpatch? I need a spdx line for new files please, > don't force us to go back and guess in the future, that isn't nice.

Re: [PATCH] usb: typec: anx7688: Add driver for ANX7688 USB-C HDMI bridge

2024-02-01 Thread Greg KH
On Thu, Feb 01, 2024 at 11:41:56AM +0100, Pavel Machek wrote: > +#define DEBUG Please don't. This is dynamic, use the dynamic debugging and set it from userspace if you want to debug the driver. > + > +#include > +#include > +#include > +#include > +#include > +#include > +#include >

Re: [PATCH] usb: typec: anx7688: Add driver for ANX7688 USB-C HDMI bridge

2024-02-01 Thread Greg KH
On Thu, Feb 01, 2024 at 11:41:56AM +0100, Pavel Machek wrote: > --- /dev/null > +++ b/drivers/usb/typec/anx7688.c > @@ -0,0 +1,1866 @@ > +/* > + * ANX7688 USB-C HDMI bridge/PD driver > + * Did this pass checkpatch? I need a spdx line for new files please, don't force us to go back and guess in

[PATCH] usb: typec: anx7688: Add driver for ANX7688 USB-C HDMI bridge

2024-02-01 Thread Pavel Machek
From: Ondrej Jirman This is driver for ANX7688 USB-C HDMI, with flashing and debugging features removed. ANX7688 is rather criticial piece on PinePhone, there's no display and no battery charging without it. There's likely more work to be done here, but having basic support in mainline is