Re: [PATCH] usb: typec: tcpm: Correct the PPS out_volt calculation

2019-01-31 Thread Heikki Krogerus
On Thu, Jan 31, 2019 at 09:01:00AM +0100, Greg KH wrote: > On Thu, Jan 31, 2019 at 09:31:25AM +0200, Heikki Krogerus wrote: > > On Wed, Jan 30, 2019 at 11:13:53AM +0800, Kyle Tso wrote: > > > When Sink negotiates PPS, the voltage range of selected PPS APDO might > > > not cover the previous

Re: [PATCH] usb: typec: tcpm: Correct the PPS out_volt calculation

2019-01-31 Thread Greg KH
On Thu, Jan 31, 2019 at 09:31:25AM +0200, Heikki Krogerus wrote: > On Wed, Jan 30, 2019 at 11:13:53AM +0800, Kyle Tso wrote: > > When Sink negotiates PPS, the voltage range of selected PPS APDO might > > not cover the previous voltage (out_volt). If the previous out_volt is > > lower than the new

Re: [PATCH] usb: typec: tcpm: Correct the PPS out_volt calculation

2019-01-30 Thread Heikki Krogerus
On Wed, Jan 30, 2019 at 11:13:53AM +0800, Kyle Tso wrote: > When Sink negotiates PPS, the voltage range of selected PPS APDO might > not cover the previous voltage (out_volt). If the previous out_volt is > lower than the new min_volt, the output voltage in RDO might be set to > an invalid value.

Re: [PATCH] usb: typec: tcpm: Correct the PPS out_volt calculation

2019-01-30 Thread Guenter Roeck
On Wed, Jan 30, 2019 at 11:13:53AM +0800, Kyle Tso wrote: > When Sink negotiates PPS, the voltage range of selected PPS APDO might > not cover the previous voltage (out_volt). If the previous out_volt is > lower than the new min_volt, the output voltage in RDO might be set to > an invalid value.

RE: [PATCH] usb: typec: tcpm: Correct the PPS out_volt calculation

2019-01-30 Thread Adam Thomson
On 30 January 2019 03:14, Kyle Tso wrote: > When Sink negotiates PPS, the voltage range of selected PPS APDO might not > cover the previous voltage (out_volt). If the previous out_volt is lower than > the > new min_volt, the output voltage in RDO might be set to an invalid value. For > instance,

[PATCH] usb: typec: tcpm: Correct the PPS out_volt calculation

2019-01-29 Thread Kyle Tso
When Sink negotiates PPS, the voltage range of selected PPS APDO might not cover the previous voltage (out_volt). If the previous out_volt is lower than the new min_volt, the output voltage in RDO might be set to an invalid value. For instance, supposed that the previous voltage is 5V, and the new