Re: [PATCH] usb: usbip: fix null pointer dereference

2016-06-06 Thread Sudip Mukherjee
On Mon, Jun 06, 2016 at 10:20:37AM +0200, Krzysztof Opasiak wrote: > > > On 06/05/2016 07:54 PM, Sudip Mukherjee wrote: > > > > Yes, I should have seen earlier that the only caller has already > > dereferenced udc. So maybe the following will be appropriate in this > > situation. > > > > Your

Re: [PATCH] usb: usbip: fix null pointer dereference

2016-06-06 Thread Krzysztof Opasiak
On 06/05/2016 07:54 PM, Sudip Mukherjee wrote: > On Friday 03 June 2016 09:29 AM, Krzysztof Opasiak wrote: >> >> >> On 06/02/2016 03:22 PM, Sudip Mukherjee wrote: >>> We have been dereferencing udc before checking it. Lets use it after it >>> has been checked. >>> >> >> To be honest I have mixed

Re: [PATCH] usb: usbip: fix null pointer dereference

2016-06-05 Thread Sudip Mukherjee
On Friday 03 June 2016 09:29 AM, Krzysztof Opasiak wrote: On 06/02/2016 03:22 PM, Sudip Mukherjee wrote: We have been dereferencing udc before checking it. Lets use it after it has been checked. To be honest I have mixed feelings about this patch. On one hand it prevents us from dereferenc

Re: [PATCH] usb: usbip: fix null pointer dereference

2016-06-03 Thread Alan Stern
On Fri, 3 Jun 2016, Krzysztof Opasiak wrote: > On 06/02/2016 03:22 PM, Sudip Mukherjee wrote: > > We have been dereferencing udc before checking it. Lets use it after it > > has been checked. > > > > To be honest I have mixed feelings about this patch. > > On one hand it prevents us from derefe

Re: [PATCH] usb: usbip: fix null pointer dereference

2016-06-03 Thread Krzysztof Opasiak
On 06/02/2016 03:22 PM, Sudip Mukherjee wrote: > We have been dereferencing udc before checking it. Lets use it after it > has been checked. > To be honest I have mixed feelings about this patch. On one hand it prevents us from dereferencing potential NULL ptr what is generally good. But on th

[PATCH] usb: usbip: fix null pointer dereference

2016-06-02 Thread Sudip Mukherjee
We have been dereferencing udc before checking it. Lets use it after it has been checked. Signed-off-by: Sudip Mukherjee --- drivers/usb/usbip/vudc_sysfs.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/usb/usbip/vudc_sysfs.c b/drivers/usb/usbip/vudc_sysfs.c i