Re: [PATCH] usb: xhci: Consolidate XHCI TD Size calculation

2013-05-15 Thread Julius Werner
> Does this patch fix the control transfer data stage issue? Please break > this into a bug fix for that, with your refactoring on top of that. We > need to backport the bug fix to the stable kernels, and queue the > refactoring for 3.11. I don't think there is really any practial adverse effect

Re: [PATCH] usb: xhci: Consolidate XHCI TD Size calculation

2013-05-14 Thread Sarah Sharp
On Thu, May 09, 2013 at 09:42:51PM -0700, Julius Werner wrote: > The TD Size field in an XHCI TRB is calculated in two different ways, > depending on the XHCI version. The current code does this version check > in every caller, which makes it easy to forget (such as in the function > for control tr

[PATCH] usb: xhci: Consolidate XHCI TD Size calculation

2013-05-09 Thread Julius Werner
The TD Size field in an XHCI TRB is calculated in two different ways, depending on the XHCI version. The current code does this version check in every caller, which makes it easy to forget (such as in the function for control transfers, which still erroneously uses the old calculation for its data