Re: [PATCH] usb: xhci: Correct last context entry calculation for Configure Endpoint

2014-04-29 Thread Julius Werner
Okay, thanks, sounds good. I personally don't care that much about the stable backport. Let me respin this with a fixed commit message and the type change Felipe suggested. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to

Re: [PATCH] usb: xhci: Correct last context entry calculation for Configure Endpoint

2014-04-29 Thread Mathias Nyman
On 04/29/2014 06:11 AM, Julius Werner wrote: *bump* Sarah, Mathias, can we decide how to proceed with this? I think the section Alan quoted is a pretty good argument in favor of my interpretation (although of course this would not be the first time that two sections of a spec contradict each

Re: [PATCH] usb: xhci: Correct last context entry calculation for Configure Endpoint

2014-04-29 Thread Mathias Nyman
On 04/29/2014 06:11 AM, Julius Werner wrote: *bump* Sarah, Mathias, can we decide how to proceed with this? I think the section Alan quoted is a pretty good argument in favor of my interpretation (although of course this would not be the first time that two sections of a spec contradict each

Re: [PATCH] usb: xhci: Correct last context entry calculation for Configure Endpoint

2014-04-29 Thread Julius Werner
Okay, thanks, sounds good. I personally don't care that much about the stable backport. Let me respin this with a fixed commit message and the type change Felipe suggested. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to

Re: [PATCH] usb: xhci: Correct last context entry calculation for Configure Endpoint

2014-04-28 Thread Julius Werner
*bump* Sarah, Mathias, can we decide how to proceed with this? I think the section Alan quoted is a pretty good argument in favor of my interpretation (although of course this would not be the first time that two sections of a spec contradict each other). But more importantly, we have a case that

Re: [PATCH] usb: xhci: Correct last context entry calculation for Configure Endpoint

2014-04-28 Thread Julius Werner
*bump* Sarah, Mathias, can we decide how to proceed with this? I think the section Alan quoted is a pretty good argument in favor of my interpretation (although of course this would not be the first time that two sections of a spec contradict each other). But more importantly, we have a case that

Re: [PATCH] usb: xhci: Correct last context entry calculation for Configure Endpoint

2014-04-01 Thread Alan Stern
On Tue, 1 Apr 2014, Julius Werner wrote: > > http://marc.info/?l=linux-usb=137158978503741=2 > > > > There's an xHCI spec ambiguity: Does the last valid context entry refer > > to the last valid endpoint context in the *input* device context or the > > *output* device context? It's not

Re: [PATCH] usb: xhci: Correct last context entry calculation for Configure Endpoint

2014-04-01 Thread Julius Werner
> http://marc.info/?l=linux-usb=137158978503741=2 > > There's an xHCI spec ambiguity: Does the last valid context entry refer > to the last valid endpoint context in the *input* device context or the > *output* device context? > > The code currently assumes it refers to the input device context,

Re: [PATCH] usb: xhci: Correct last context entry calculation for Configure Endpoint

2014-04-01 Thread Julius Werner
http://marc.info/?l=linux-usbm=137158978503741w=2 There's an xHCI spec ambiguity: Does the last valid context entry refer to the last valid endpoint context in the *input* device context or the *output* device context? The code currently assumes it refers to the input device context,

Re: [PATCH] usb: xhci: Correct last context entry calculation for Configure Endpoint

2014-04-01 Thread Alan Stern
On Tue, 1 Apr 2014, Julius Werner wrote: http://marc.info/?l=linux-usbm=137158978503741w=2 There's an xHCI spec ambiguity: Does the last valid context entry refer to the last valid endpoint context in the *input* device context or the *output* device context? It's not ambiguous at

Re: [PATCH] usb: xhci: Correct last context entry calculation for Configure Endpoint

2014-03-31 Thread Sarah Sharp
On Tue, Mar 25, 2014 at 11:42:43AM -0700, Julius Werner wrote: > The current XHCI driver recalculates the Context Entries field in the > Slot Context on every add_endpoint() and drop_endpoint() call. In the > case of drop_endpoint(), it seems to assume that the add_flags will > always contain

Re: [PATCH] usb: xhci: Correct last context entry calculation for Configure Endpoint

2014-03-31 Thread Sarah Sharp
On Tue, Mar 25, 2014 at 11:42:43AM -0700, Julius Werner wrote: The current XHCI driver recalculates the Context Entries field in the Slot Context on every add_endpoint() and drop_endpoint() call. In the case of drop_endpoint(), it seems to assume that the add_flags will always contain every

Re: [PATCH] usb: xhci: Correct last context entry calculation for Configure Endpoint

2014-03-28 Thread Mathias Nyman
On 03/25/2014 08:42 PM, Julius Werner wrote: The current XHCI driver recalculates the Context Entries field in the Slot Context on every add_endpoint() and drop_endpoint() call. In the case of drop_endpoint(), it seems to assume that the add_flags will always contain every endpoint for the new

Re: [PATCH] usb: xhci: Correct last context entry calculation for Configure Endpoint

2014-03-28 Thread Felipe Balbi
Hi, On Tue, Mar 25, 2014 at 11:42:43AM -0700, Julius Werner wrote: > @@ -2723,8 +2697,19 @@ int xhci_check_bandwidth(struct usb_hcd *hcd, struct > usb_device *udev) > ctrl_ctx->drop_flags == 0) > return 0; > > - xhci_dbg(xhci, "New Input Control

Re: [PATCH] usb: xhci: Correct last context entry calculation for Configure Endpoint

2014-03-28 Thread Felipe Balbi
Hi, On Tue, Mar 25, 2014 at 11:42:43AM -0700, Julius Werner wrote: @@ -2723,8 +2697,19 @@ int xhci_check_bandwidth(struct usb_hcd *hcd, struct usb_device *udev) ctrl_ctx-drop_flags == 0) return 0; - xhci_dbg(xhci, New Input Control Context:\n); +

Re: [PATCH] usb: xhci: Correct last context entry calculation for Configure Endpoint

2014-03-28 Thread Mathias Nyman
On 03/25/2014 08:42 PM, Julius Werner wrote: The current XHCI driver recalculates the Context Entries field in the Slot Context on every add_endpoint() and drop_endpoint() call. In the case of drop_endpoint(), it seems to assume that the add_flags will always contain every endpoint for the new

[PATCH] usb: xhci: Correct last context entry calculation for Configure Endpoint

2014-03-25 Thread Julius Werner
The current XHCI driver recalculates the Context Entries field in the Slot Context on every add_endpoint() and drop_endpoint() call. In the case of drop_endpoint(), it seems to assume that the add_flags will always contain every endpoint for the new configuration, which is not necessarily correct

[PATCH] usb: xhci: Correct last context entry calculation for Configure Endpoint

2014-03-25 Thread Julius Werner
The current XHCI driver recalculates the Context Entries field in the Slot Context on every add_endpoint() and drop_endpoint() call. In the case of drop_endpoint(), it seems to assume that the add_flags will always contain every endpoint for the new configuration, which is not necessarily correct