Re: [PATCH] usb: xhci: Use non-interruptible sleep for XHCI commands

2013-08-20 Thread Julius Werner
Hi Sarah, I know you are probably swamped with patches, but this (https://patchwork.kernel.org/patch/2612831/) has been hanging a few months and I just wanted to double-check if it slipped through somewhere. I still think this is necessary (regardless of any command queue reengineering in the futu

Re: [PATCH] usb: xhci: Use non-interruptible sleep for XHCI commands

2013-05-29 Thread Julius Werner
On Wed, May 29, 2013 at 11:06 AM, Sarah Sharp wrote: > I really wish you had contacted me about this issue before writing code > to fix it. Now I don't know the backstory behind this issue, which > makes it hard to evaluate whether this fix is correct. No worries... this was a very trivial patch

Re: [PATCH] usb: xhci: Use non-interruptible sleep for XHCI commands

2013-05-29 Thread Sarah Sharp
I really wish you had contacted me about this issue before writing code to fix it. Now I don't know the backstory behind this issue, which makes it hard to evaluate whether this fix is correct. On Fri, May 24, 2013 at 06:39:37PM -0700, Julius Werner wrote: > The XHCI stack usually uses wait_for_c

[PATCH] usb: xhci: Use non-interruptible sleep for XHCI commands

2013-05-24 Thread Julius Werner
The XHCI stack usually uses wait_for_completion_interruptible_timeout() to wait for the completion of an XHCI command, and treats both timeouts and interruptions as errors. This is a bad idea, since these commands are often essential for the correct operation of the USB stack, and their failure can