Re: [PATCH] usb-serial: Sierra driver - add devices and update dtr

2008-01-18 Thread Greg KH
On Thu, Jan 17, 2008 at 03:15:23PM -0800, Kevin Lloyd wrote: > > > Correct, the 0x0023 is the only newly added device that requires the > new > > > features. > > > > Does that mean things will not work for this device if it is added to > > the device table, without the code updates? > Adding the

Re: [PATCH] usb-serial: Sierra driver - add devices and update dtr

2008-01-18 Thread Greg KH
On Thu, Jan 17, 2008 at 03:15:23PM -0800, Kevin Lloyd wrote: Correct, the 0x0023 is the only newly added device that requires the new features. Does that mean things will not work for this device if it is added to the device table, without the code updates? Adding the device will not

RE: [PATCH] usb-serial: Sierra driver - add devices and update dtr

2008-01-17 Thread Kevin Lloyd
> > Correct, the 0x0023 is the only newly added device that requires the new > > features. > > Does that mean things will not work for this device if it is added to > the device table, without the code updates? Adding the device will not break the driver (assuming you remove the tag). > And is

Re: [PATCH] usb-serial: Sierra driver - add devices and update dtr

2008-01-17 Thread Greg KH
On Mon, Jan 14, 2008 at 09:21:32AM -0800, Kevin Lloyd wrote: > > Hm, no, the intrusion into the driver is just too much this late in > the > > release cycle to allow this. > > > > Now I will be glad to only add the new device ids for the devices that > > do not rely on the new changes right now,

Re: [PATCH] usb-serial: Sierra driver - add devices and update dtr

2008-01-17 Thread Greg KH
On Mon, Jan 14, 2008 at 09:21:32AM -0800, Kevin Lloyd wrote: Hm, no, the intrusion into the driver is just too much this late in the release cycle to allow this. Now I will be glad to only add the new device ids for the devices that do not rely on the new changes right now, but that's

RE: [PATCH] usb-serial: Sierra driver - add devices and update dtr

2008-01-17 Thread Kevin Lloyd
Correct, the 0x0023 is the only newly added device that requires the new features. Does that mean things will not work for this device if it is added to the device table, without the code updates? Adding the device will not break the driver (assuming you remove the tag). And is this

RE: [PATCH] usb-serial: Sierra driver - add devices and update dtr

2008-01-14 Thread Kevin Lloyd
> Hm, no, the intrusion into the driver is just too much this late in the > release cycle to allow this. > > Now I will be glad to only add the new device ids for the devices that > do not rely on the new changes right now, but that's it. > > So, right now I have a separate patch split out of your

RE: [PATCH] usb-serial: Sierra driver - add devices and update dtr

2008-01-14 Thread Kevin Lloyd
Hm, no, the intrusion into the driver is just too much this late in the release cycle to allow this. Now I will be glad to only add the new device ids for the devices that do not rely on the new changes right now, but that's it. So, right now I have a separate patch split out of your

Re: [PATCH] usb-serial: Sierra driver - add devices and update dtr

2008-01-11 Thread Greg KH
On Fri, Jan 11, 2008 at 09:24:36AM -0800, Kevin Lloyd wrote: > > Those device ids are already in my tree, as it was my understanding > that > > you would not be sending me patches for them :) > You're right, I normally wouldn't, but since someone else already had, I > figured it would be alright.

RE: [PATCH] usb-serial: Sierra driver - add devices and update dtr

2008-01-11 Thread Kevin Lloyd
> Those device ids are already in my tree, as it was my understanding that > you would not be sending me patches for them :) You're right, I normally wouldn't, but since someone else already had, I figured it would be alright. > I'll split this patch up into something that updates the device ids

RE: [PATCH] usb-serial: Sierra driver - add devices and update dtr

2008-01-11 Thread Kevin Lloyd
Those device ids are already in my tree, as it was my understanding that you would not be sending me patches for them :) You're right, I normally wouldn't, but since someone else already had, I figured it would be alright. I'll split this patch up into something that updates the device ids and

Re: [PATCH] usb-serial: Sierra driver - add devices and update dtr

2008-01-11 Thread Greg KH
On Fri, Jan 11, 2008 at 09:24:36AM -0800, Kevin Lloyd wrote: Those device ids are already in my tree, as it was my understanding that you would not be sending me patches for them :) You're right, I normally wouldn't, but since someone else already had, I figured it would be alright. I'll

Re: [PATCH] usb-serial: Sierra driver - add devices and update dtr

2008-01-10 Thread Greg KH
On Thu, Jan 10, 2008 at 11:11:04AM -0800, Kevin Lloyd wrote: > From: Kevin Lloyd <[EMAIL PROTECTED]> > > This patch is targeted for the 2.6.24-rc7 kernel. > > The following improvements were made: > - Added new product support: MC5725, AC 880 U, MP 3G (UMTS & CDMA) > - Fixed control line issue

[PATCH] usb-serial: Sierra driver - add devices and update dtr

2008-01-10 Thread Kevin Lloyd
From: Kevin Lloyd <[EMAIL PROTECTED]> This patch is targeted for the 2.6.24-rc7 kernel. The following improvements were made: - Added new product support: MC5725, AC 880 U, MP 3G (UMTS & CDMA) - Fixed control line issue where asserting DTR on ep5 would close ep2 - Added support for

[PATCH] usb-serial: Sierra driver - add devices and update dtr

2008-01-10 Thread Kevin Lloyd
From: Kevin Lloyd [EMAIL PROTECTED] This patch is targeted for the 2.6.24-rc7 kernel. The following improvements were made: - Added new product support: MC5725, AC 880 U, MP 3G (UMTS CDMA) - Fixed control line issue where asserting DTR on ep5 would close ep2 - Added support for

Re: [PATCH] usb-serial: Sierra driver - add devices and update dtr

2008-01-10 Thread Greg KH
On Thu, Jan 10, 2008 at 11:11:04AM -0800, Kevin Lloyd wrote: From: Kevin Lloyd [EMAIL PROTECTED] This patch is targeted for the 2.6.24-rc7 kernel. The following improvements were made: - Added new product support: MC5725, AC 880 U, MP 3G (UMTS CDMA) - Fixed control line issue where