Re: [PATCH] usb host: Faraday FUSBH200 HCD driver.

2013-03-20 Thread Yuan-Hsin Chen
Hi, On Wed, Mar 20, 2013 at 10:26 PM, Alan Stern wrote: > On Wed, 20 Mar 2013, Yuan-Hsin Chen wrote: > >> Hi, >> >> On Tue, Mar 19, 2013 at 11:48 PM, Alan Stern >> wrote: >> > On Tue, 19 Mar 2013, Yuan-Hsin Chen wrote: >> > >> >> > What about the port_status registers? They're not between comm

Re: [PATCH] usb host: Faraday FUSBH200 HCD driver.

2013-03-20 Thread Alan Stern
On Wed, 20 Mar 2013, Yuan-Hsin Chen wrote: > Hi, > > On Tue, Mar 19, 2013 at 11:48 PM, Alan Stern > wrote: > > On Tue, 19 Mar 2013, Yuan-Hsin Chen wrote: > > > >> > What about the port_status registers? They're not between command and > >> > async_next. If they aren't consistent with EHCI, it

Re: [PATCH] usb host: Faraday FUSBH200 HCD driver.

2013-03-20 Thread Yuan-Hsin Chen
Hi, On Tue, Mar 19, 2013 at 11:48 PM, Alan Stern wrote: > On Tue, 19 Mar 2013, Yuan-Hsin Chen wrote: > >> > What about the port_status registers? They're not between command and >> > async_next. If they aren't consistent with EHCI, it makes things a lot >> > more complicated. >> >> fusbh200 has

Re: [PATCH] usb host: Faraday FUSBH200 HCD driver.

2013-03-19 Thread Yuan-Hsin Chen
On Tue, Mar 19, 2013 at 11:48 PM, Alan Stern wrote: > On Tue, 19 Mar 2013, Yuan-Hsin Chen wrote: > >> > What about the port_status registers? They're not between command and >> > async_next. If they aren't consistent with EHCI, it makes things a lot >> > more complicated. >> >> fusbh200 has only

Re: [PATCH] usb host: Faraday FUSBH200 HCD driver.

2013-03-19 Thread Alan Stern
On Tue, 19 Mar 2013, Yuan-Hsin Chen wrote: > > What about the port_status registers? They're not between command and > > async_next. If they aren't consistent with EHCI, it makes things a lot > > more complicated. > > fusbh200 has only one port_status register with different offset, > 0x30, and

Re: [PATCH] usb host: Faraday FUSBH200 HCD driver.

2013-03-19 Thread Yuan-Hsin Chen
Hi, On Mon, Mar 18, 2013 at 10:16 PM, Alan Stern wrote: > On Mon, 18 Mar 2013, Felipe Balbi wrote: > >> On Mon, Mar 18, 2013 at 06:06:18PM +0800, Yuan-Hsin Chen wrote: >> > Hi, >> > >> > I tried to modify fusbh200 hcd driver following ehci-platform.c. >> > However, the register definition of fusb

Re: [PATCH] usb host: Faraday FUSBH200 HCD driver.

2013-03-18 Thread Alan Stern
On Mon, 18 Mar 2013, Felipe Balbi wrote: > Hi, > > On Mon, Mar 18, 2013 at 10:16:56AM -0400, Alan Stern wrote: > > > > it would cause copious modification and duplication of ehci hcd > > > > driver. For example, there is no "configured_flag" register in > > > > fusbh200 controller, yet, ehci hcd

Re: [PATCH] usb host: Faraday FUSBH200 HCD driver.

2013-03-18 Thread Felipe Balbi
Hi, On Mon, Mar 18, 2013 at 10:16:56AM -0400, Alan Stern wrote: > > > it would cause copious modification and duplication of ehci hcd > > > driver. For example, there is no "configured_flag" register in > > > fusbh200 controller, yet, ehci hcd driver accesses "configured_flag" > > > in function eh

Re: [PATCH] usb host: Faraday FUSBH200 HCD driver.

2013-03-18 Thread Alan Stern
On Mon, 18 Mar 2013, Felipe Balbi wrote: > On Mon, Mar 18, 2013 at 06:06:18PM +0800, Yuan-Hsin Chen wrote: > > Hi, > > > > I tried to modify fusbh200 hcd driver following ehci-platform.c. > > However, the register definition of fusbh200 is partially incompatible > > to ehci. For fusbh200, only th

Re: [PATCH] usb host: Faraday FUSBH200 HCD driver.

2013-03-18 Thread Felipe Balbi
Hi, (don't top-post) On Mon, Mar 18, 2013 at 06:06:18PM +0800, Yuan-Hsin Chen wrote: > Hi, > > I tried to modify fusbh200 hcd driver following ehci-platform.c. > However, the register definition of fusbh200 is partially incompatible > to ehci. For fusbh200, only the elements between "command" an

Re: [PATCH] usb host: Faraday FUSBH200 HCD driver.

2013-03-18 Thread Yuan-Hsin Chen
Hi, I tried to modify fusbh200 hcd driver following ehci-platform.c. However, the register definition of fusbh200 is partially incompatible to ehci. For fusbh200, only the elements between "command" and "async_next" in struct ehci_regs are consistent with ehci which means it would cause copious mo

Re: [PATCH] usb host: Faraday FUSBH200 HCD driver.

2013-02-06 Thread Yuan-Hsin Chen
On Thu, Feb 7, 2013 at 12:38 AM, Felipe Balbi wrote: > On Wed, Feb 06, 2013 at 07:24:01PM +0800, Yuan-Hsin Chen wrote: >> From: Yuan-Hsin Chen >> >> USB2.0 HCD driver for Faraday FUSBH200 >> >> Signed-off-by: Yuan-Hsin Chen > > just use ehci-platform.c and avoid the duplication > > -- > balbi T

Re: [PATCH] usb host: Faraday FUSBH200 HCD driver.

2013-02-06 Thread Felipe Balbi
On Wed, Feb 06, 2013 at 07:24:01PM +0800, Yuan-Hsin Chen wrote: > From: Yuan-Hsin Chen > > USB2.0 HCD driver for Faraday FUSBH200 > > Signed-off-by: Yuan-Hsin Chen just use ehci-platform.c and avoid the duplication -- balbi signature.asc Description: Digital signature

Re: [PATCH] usb host: Faraday FUSBH200 HCD driver.

2013-02-06 Thread Alan Stern
On Wed, 6 Feb 2013, Yuan-Hsin Chen wrote: > From: Yuan-Hsin Chen > > USB2.0 HCD driver for Faraday FUSBH200 In what way is this driver different from the existing ehci-hcd driver? It looks like almost all of the code is identical. We don't need to have two copies of the same code in the ker