Re: [PATCH] usb_wwan: some improvement on write and resume

2014-04-27 Thread Johan Hovold
On Sun, Apr 27, 2014 at 10:15:45AM +0800, Xiao Jin wrote: > > They are however two distinct bugs and should be fixed separately. Could > > you split the fixes into two patches and resubmit? > > > > Please also include a more descriptive subject line for each patch, for > > example: > > > > "USB

Re: [PATCH] usb_wwan: some improvement on write and resume

2014-04-26 Thread Xiao Jin
They are however two distinct bugs and should be fixed separately. Could you split the fixes into two patches and resubmit? Please also include a more descriptive subject line for each patch, for example: "USB: usb_wwan: fix urb leak in write error path" "USB: usb_wwan: fix ra

Re: [PATCH] usb_wwan: some improvement on write and resume

2014-04-25 Thread Johan Hovold
On Fri, Apr 25, 2014 at 08:57:15AM +0800, xiao jin wrote: > When enable usb serial for modem data, sometimes the tty is blocked > in tty_wait_until_sent because portdata->out_busy always is set and > have no chance to be cleared. > > We have found two scenarios lead to portdata->out_busy problem. >

[PATCH] usb_wwan: some improvement on write and resume

2014-04-24 Thread xiao jin
When enable usb serial for modem data, sometimes the tty is blocked in tty_wait_until_sent because portdata->out_busy always is set and have no chance to be cleared. We have found two scenarios lead to portdata->out_busy problem. 1. usb_wwan_write set portdata->out_busy firstly, then try autopm as