Re: [PATCH] usbip: vudc: check for NULL before use

2016-12-21 Thread Sudip Mukherjee
On Wed, Dec 21, 2016 at 07:38:21AM -0700, Shuah Khan wrote: > Hi Sudip, > > On Wed, Dec 21, 2016 at 6:33 AM, Sudip Mukherjee > wrote: > > On Tue, Dec 20, 2016 at 07:31:44AM -0700, Shuah Khan wrote: > >> On 12/18/2016 03:44 PM, Sudip Mukherjee wrote: > >> > to_vep() is doing a container_of() on _e

Re: [PATCH] usbip: vudc: check for NULL before use

2016-12-21 Thread Krzysztof Opasiak
Hi, On 12/21/2016 03:38 PM, Shuah Khan wrote: > Hi Sudip, > > On Wed, Dec 21, 2016 at 6:33 AM, Sudip Mukherjee > wrote: >> On Tue, Dec 20, 2016 at 07:31:44AM -0700, Shuah Khan wrote: >>> On 12/18/2016 03:44 PM, Sudip Mukherjee wrote: to_vep() is doing a container_of() on _ep. It is better t

Re: [PATCH] usbip: vudc: check for NULL before use

2016-12-21 Thread Shuah Khan
Hi Sudip, On Wed, Dec 21, 2016 at 6:33 AM, Sudip Mukherjee wrote: > On Tue, Dec 20, 2016 at 07:31:44AM -0700, Shuah Khan wrote: >> On 12/18/2016 03:44 PM, Sudip Mukherjee wrote: >> > to_vep() is doing a container_of() on _ep. It is better to do the NULL >> > check first and then use it. >> > >> >

Re: [PATCH] usbip: vudc: check for NULL before use

2016-12-21 Thread Sudip Mukherjee
On Tue, Dec 20, 2016 at 07:31:44AM -0700, Shuah Khan wrote: > On 12/18/2016 03:44 PM, Sudip Mukherjee wrote: > > to_vep() is doing a container_of() on _ep. It is better to do the NULL > > check first and then use it. > > > > Signed-off-by: Sudip Mukherjee > > --- > > drivers/usb/usbip/vudc_dev.c

Re: [PATCH] usbip: vudc: check for NULL before use

2016-12-20 Thread Shuah Khan
On 12/18/2016 03:44 PM, Sudip Mukherjee wrote: > to_vep() is doing a container_of() on _ep. It is better to do the NULL > check first and then use it. > > Signed-off-by: Sudip Mukherjee > --- > drivers/usb/usbip/vudc_dev.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a

[PATCH] usbip: vudc: check for NULL before use

2016-12-18 Thread Sudip Mukherjee
to_vep() is doing a container_of() on _ep. It is better to do the NULL check first and then use it. Signed-off-by: Sudip Mukherjee --- drivers/usb/usbip/vudc_dev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/usbip/vudc_dev.c b/drivers/usb/usbip/vudc_dev.c inde