Re: [PATCH] use spinlock instead of binary mutex in CDU-31A driver

2007-04-22 Thread Matthias Kaehlcke
El Mon, Apr 23, 2007 at 01:25:58AM +0200 Andi Kleen ha dit: > Matthias Kaehlcke <[EMAIL PROTECTED]> writes: > > > -static DECLARE_MUTEX(sony_sem);/* Semaphore for drive hardware > > access */ > > +static DEFINE_MUTEX(sony_mtx); /* Mutex for drive hardware > > access */ >

Re: [PATCH] use spinlock instead of binary mutex in CDU-31A driver

2007-04-22 Thread Andi Kleen
Matthias Kaehlcke <[EMAIL PROTECTED]> writes: > -static DECLARE_MUTEX(sony_sem); /* Semaphore for drive hardware > access */ > +static DEFINE_MUTEX(sony_mtx); /* Mutex for drive hardware > access */ That's not a spinlock. Also normally some rationale is added to the

[PATCH] use spinlock instead of binary mutex in CDU-31A driver

2007-04-22 Thread Matthias Kaehlcke
use spinlock instead of binary mutex in CDU-31A driver Signed-off-by: Matthias Kaehlcke <[EMAIL PROTECTED]> -- diff --git a/drivers/cdrom/cdu31a.c b/drivers/cdrom/cdu31a.c index 2157c58..d3649e4 100644 --- a/drivers/cdrom/cdu31a.c +++ b/drivers/cdrom/cdu31a.c @@ -263,7 +263,7 @@ static int sony