Re: [PATCH] usermodehelper: kill the sub_info->path[0] check

2013-05-22 Thread Oleg Nesterov
Hi Lucas, On 05/21, Lucas De Marchi wrote: > > Acked-By: Lucas De Marchi Thanks. > > @@ -147,6 +147,9 @@ int __request_module(bool wait, const char *fmt, ...) > > */ > > WARN_ON_ONCE(wait && current_is_async()); > > > > + if (!modprobe_path[0]) > > + return

Re: [PATCH] usermodehelper: kill the sub_info->path[0] check

2013-05-21 Thread Lucas De Marchi
Hi Oleg, On Mon, May 20, 2013 at 1:55 PM, Oleg Nesterov wrote: > call_usermodehelper_exec() does nothing but returns success if > path[0] == 0. The only user which needs this strange feature is > request_module(), it can check modprobe_path[0] itself like other > users do if they want to detect t

Re: [PATCH] usermodehelper: kill the sub_info->path[0] check

2013-05-21 Thread Rusty Russell
Oleg Nesterov writes: > call_usermodehelper_exec() does nothing but returns success if > path[0] == 0. The only user which needs this strange feature is > request_module(), it can check modprobe_path[0] itself like other > users do if they want to detect the "disabled by admin" case. > > Kill it.

[PATCH] usermodehelper: kill the sub_info->path[0] check

2013-05-20 Thread Oleg Nesterov
call_usermodehelper_exec() does nothing but returns success if path[0] == 0. The only user which needs this strange feature is request_module(), it can check modprobe_path[0] itself like other users do if they want to detect the "disabled by admin" case. Kill it. Not only it looks strange, it can