Re: [PATCH] userns: Add basic quota support v4

2012-09-19 Thread Eric W. Biederman
Dave thank you earlier taking some time to do review. It made me realize that my code was not as mature as it needed to be. That said you missed a lot of important details, and I will aim at to address some of the highlights. Precedent in naming. that has been merged since 3.5, earlier there i

Re: [PATCH] userns: Add basic quota support v4

2012-09-04 Thread Eric W. Biederman
Dave Chinner writes: > On Wed, Aug 29, 2012 at 02:31:26AM -0700, Eric W. Biederman wrote: >> >> Dave thanks for taking the time to take a detailed look at this code. >> >> Dave Chinner writes: >> >> > On Tue, Aug 28, 2012 at 12:09:56PM -0700, Eric W. Biederman wrote: >> > How did you tes

Re: [PATCH] userns: Add basic quota support v4

2012-08-30 Thread Dave Chinner
On Wed, Aug 29, 2012 at 02:31:26AM -0700, Eric W. Biederman wrote: > > Dave thanks for taking the time to take a detailed look at this code. > > Dave Chinner writes: > > > On Tue, Aug 28, 2012 at 12:09:56PM -0700, Eric W. Biederman wrote: > >> > >> Add the data type struct kqid which holds the

Re: [PATCH] userns: Add basic quota support v4

2012-08-29 Thread Eric W. Biederman
Dave thanks for taking the time to take a detailed look at this code. Dave Chinner writes: > On Tue, Aug 28, 2012 at 12:09:56PM -0700, Eric W. Biederman wrote: >> >> Add the data type struct kqid which holds the kernel internal form of >> the owning identifier of a quota. struct kqid is a rep

Re: [PATCH] userns: Add basic quota support v4

2012-08-28 Thread Dave Chinner
On Tue, Aug 28, 2012 at 12:09:56PM -0700, Eric W. Biederman wrote: > > Add the data type struct kqid which holds the kernel internal form of > the owning identifier of a quota. struct kqid is a replacement for > the implicit union of uid, gid and project stored in an unsigned int > and the quota

[PATCH] userns: Add basic quota support v4

2012-08-28 Thread Eric W. Biederman
Add the data type struct kqid which holds the kernel internal form of the owning identifier of a quota. struct kqid is a replacement for the implicit union of uid, gid and project stored in an unsigned int and the quota type field that is was used in the quota data structures. Making the data ty