Re: [PATCH] v2 bakclight: fix missing checks in ambient_light_zone_store

2019-01-07 Thread Daniel Thompson
On Sat, Jan 05, 2019 at 12:48:07PM -0600, Aditya Pakki wrote: > In adp8870_bl_ambient_light_zone_store, set, clear, and write > can return an error but are not checked. The fix adds a check for these > cases and returns -1 to match the return type (ssize_t). Sorry... missed this before but there

Re: [PATCH] v2 bakclight: fix missing checks in ambient_light_zone_store

2019-01-07 Thread Daniel Thompson
On Sat, Jan 05, 2019 at 12:48:07PM -0600, Aditya Pakki wrote: > In adp8870_bl_ambient_light_zone_store, set, clear, and write I'm curious... What attracted you to this particular _store function? AFAICT the same ignoring of return values occurs in other _store functions in this file? > can

[PATCH] v2 bakclight: fix missing checks in ambient_light_zone_store

2019-01-05 Thread Aditya Pakki
In adp8870_bl_ambient_light_zone_store, set, clear, and write can return an error but are not checked. The fix adds a check for these cases and returns -1 to match the return type (ssize_t). Signed-off-by: Aditya Pakki --- drivers/video/backlight/adp8870_bl.c | 16 +--- 1 file