Re: [PATCH] v3 of IBM power meter driver

2007-09-11 Thread Darrick J. Wong
On Tue, Sep 11, 2007 at 09:23:35AM -0400, Mark M. Hoffman wrote: > I am not an IPMI expert, so I would appreciate getting an Acked-by from > someone who knows more about that subsystem. > > Anyway, some comments are below. This is nowhere near a complete review yet. Thank you for the review! C

Re: [PATCH] v3 of IBM power meter driver

2007-09-11 Thread Jean Delvare
On 9/11/2007, "Mark M. Hoffman" <[EMAIL PROTECTED]> wrote: >* Darrick J. Wong <[EMAIL PROTECTED]> [2007-08-28 16:25:05 -0700]: >> --- a/drivers/hwmon/Kconfig >> +++ b/drivers/hwmon/Kconfig >> @@ -275,6 +275,18 @@ config SENSORS_CORETEMP >>sensor inside your CPU. Supported all are all known

Re: [PATCH] v3 of IBM power meter driver

2007-09-11 Thread Mark M. Hoffman
Hi Darrick: * Darrick J. Wong <[EMAIL PROTECTED]> [2007-08-28 16:25:05 -0700]: > Dave Hansen complained about the magic numbers, repetitive code, and > various other minor problems with the driver code, so here's a v3 with > the magic numbers migrated to the top of the file and #define'd, > helper

[PATCH] v3 of IBM power meter driver

2007-08-28 Thread Darrick J. Wong
Dave Hansen complained about the magic numbers, repetitive code, and various other minor problems with the driver code, so here's a v3 with the magic numbers migrated to the top of the file and #define'd, helper macros taking place of the bit shifting/masking activities, and the compression of the