Re: [PATCH] vcodec: mediatek: Add g/s_selection support for V4L2 Encoder

2016-07-19 Thread tiffany lin
Hi Hans, On Mon, 2016-07-18 at 14:44 +0200, Hans Verkuil wrote: > On 07/18/2016 02:28 PM, tiffany lin wrote: > > Understood now. > > > > Now I am trying to figure out how to make this function right. > > Our encoder only support crop range from (0, 0) to (width, height), so > > if s->r.top and s-

Re: [PATCH] vcodec: mediatek: Add g/s_selection support for V4L2 Encoder

2016-07-18 Thread Hans Verkuil
On 07/18/2016 02:28 PM, tiffany lin wrote: > Understood now. > > Now I am trying to figure out how to make this function right. > Our encoder only support crop range from (0, 0) to (width, height), so > if s->r.top and s->r.left not 0, I will return -EINVAL. > > > Another thing is that in v4l2-c

Re: [PATCH] vcodec: mediatek: Add g/s_selection support for V4L2 Encoder

2016-07-18 Thread tiffany lin
On Fri, 2016-07-15 at 19:50 +0200, Hans Verkuil wrote: > On 07/14/2016 08:27 AM, tiffany lin wrote: > > Hi Hans, > > > > > > On Mon, 2016-07-11 at 06:32 +0200, Hans Verkuil wrote: > >> Hi Tiffany, > >> > >> My apologies for the delay, but here is my review at last: > >> > >> On 05/30/2016 09:52 A

Re: [PATCH] vcodec: mediatek: Add g/s_selection support for V4L2 Encoder

2016-07-15 Thread Hans Verkuil
On 07/14/2016 08:27 AM, tiffany lin wrote: > Hi Hans, > > > On Mon, 2016-07-11 at 06:32 +0200, Hans Verkuil wrote: >> Hi Tiffany, >> >> My apologies for the delay, but here is my review at last: >> >> On 05/30/2016 09:52 AM, Tiffany Lin wrote: >>> This patch add g/s_selection support for MT8173 >

Re: [PATCH] vcodec: mediatek: Add g/s_selection support for V4L2 Encoder

2016-07-13 Thread tiffany lin
Hi Hans, On Mon, 2016-07-11 at 06:32 +0200, Hans Verkuil wrote: > Hi Tiffany, > > My apologies for the delay, but here is my review at last: > > On 05/30/2016 09:52 AM, Tiffany Lin wrote: > > This patch add g/s_selection support for MT8173 > > > > Signed-off-by: Tiffany Lin > > --- > > drive

Re: [PATCH] vcodec: mediatek: Add g/s_selection support for V4L2 Encoder

2016-07-11 Thread tiffany lin
Hi Hans, On Mon, 2016-07-11 at 06:32 +0200, Hans Verkuil wrote: > Hi Tiffany, > > My apologies for the delay, but here is my review at last: > > On 05/30/2016 09:52 AM, Tiffany Lin wrote: > > This patch add g/s_selection support for MT8173 > > > > Signed-off-by: Tiffany Lin > > --- > > driver

Re: [PATCH] vcodec: mediatek: Add g/s_selection support for V4L2 Encoder

2016-07-10 Thread Hans Verkuil
Hi Tiffany, My apologies for the delay, but here is my review at last: On 05/30/2016 09:52 AM, Tiffany Lin wrote: > This patch add g/s_selection support for MT8173 > > Signed-off-by: Tiffany Lin > --- > drivers/media/platform/mtk-vcodec/mtk_vcodec_enc.c | 74 > > 1 file

[PATCH] vcodec: mediatek: Add g/s_selection support for V4L2 Encoder

2016-05-30 Thread Tiffany Lin
This patch add g/s_selection support for MT8173 Signed-off-by: Tiffany Lin --- drivers/media/platform/mtk-vcodec/mtk_vcodec_enc.c | 74 1 file changed, 74 insertions(+) diff --git a/drivers/media/platform/mtk-vcodec/mtk_vcodec_enc.c b/drivers/media/platform/mtk-vcodec/mt