Re: [PATCH] vdpa/mlx5: Fix erroneous null pointer checks

2020-08-09 Thread Alex Dewar
l@vger.kernel.org > Subject: Re: [PATCH] vdpa/mlx5: Fix erroneous null pointer checks > > Acked-by: Eli Cohen > On Thu, Aug 06, 2020 at 08:18:39PM +0100, Alex Dewar wrote: > > In alloc_inout() in net/mlx5_vnet.c, there are a few places where > > memory is allocated to *in an

RE: [PATCH] vdpa/mlx5: Fix erroneous null pointer checks

2020-08-08 Thread Eli Cohen
: Michael S. Tsirkin ; Jason Wang ; Parav Pandit ; virtualizat...@lists.linux-foundation.org; linux-kernel@vger.kernel.org Subject: Re: [PATCH] vdpa/mlx5: Fix erroneous null pointer checks Acked-by: Eli Cohen On Thu, Aug 06, 2020 at 08:18:39PM +0100, Alex Dewar wrote: > In alloc_inout() in

Re: [PATCH] vdpa/mlx5: Fix erroneous null pointer checks

2020-08-08 Thread Eli Cohen
Acked-by: Eli Cohen On Thu, Aug 06, 2020 at 08:18:39PM +0100, Alex Dewar wrote: > In alloc_inout() in net/mlx5_vnet.c, there are a few places where memory > is allocated to *in and *out, but only the values of in and out are > null-checked (i.e. there is a missing dereference). Fix this. > > Addr

Re: [PATCH] vdpa/mlx5: Fix erroneous null pointer checks

2020-08-06 Thread Jason Wang
On 2020/8/7 上午11:37, Jason Wang wrote: On 2020/8/7 上午3:18, Alex Dewar wrote: In alloc_inout() in net/mlx5_vnet.c, there are a few places where memory is allocated to *in and *out, but only the values of in and out are null-checked (i.e. there is a missing dereference). Fix this. Addresses-Co

Re: [PATCH] vdpa/mlx5: Fix erroneous null pointer checks

2020-08-06 Thread Jason Wang
On 2020/8/7 上午3:18, Alex Dewar wrote: In alloc_inout() in net/mlx5_vnet.c, there are a few places where memory is allocated to *in and *out, but only the values of in and out are null-checked (i.e. there is a missing dereference). Fix this. Addresses-Coverity: ("CID 1496603: (REVERSE_INULL)")

[PATCH] vdpa/mlx5: Fix erroneous null pointer checks

2020-08-06 Thread Alex Dewar
In alloc_inout() in net/mlx5_vnet.c, there are a few places where memory is allocated to *in and *out, but only the values of in and out are null-checked (i.e. there is a missing dereference). Fix this. Addresses-Coverity: ("CID 1496603: (REVERSE_INULL)") Fixes: 1a86b377aa21 ("vdpa/mlx5: Add VDPA