Re: [PATCH] vdpa/mlx5: Use write memory barrier after updating CQ index

2020-12-09 Thread Michael S. Tsirkin
On Wed, Dec 09, 2020 at 11:38:36AM +0200, Eli Cohen wrote: > On Wed, Dec 09, 2020 at 03:05:42AM -0500, Michael S. Tsirkin wrote: > > On Wed, Dec 09, 2020 at 08:58:46AM +0200, Eli Cohen wrote: > > > On Wed, Dec 09, 2020 at 01:46:22AM -0500, Michael S. Tsirkin wrote: > > > > On Wed, Dec 09, 2020 at 0

Re: [PATCH] vdpa/mlx5: Use write memory barrier after updating CQ index

2020-12-09 Thread Eli Cohen
On Wed, Dec 09, 2020 at 03:05:42AM -0500, Michael S. Tsirkin wrote: > On Wed, Dec 09, 2020 at 08:58:46AM +0200, Eli Cohen wrote: > > On Wed, Dec 09, 2020 at 01:46:22AM -0500, Michael S. Tsirkin wrote: > > > On Wed, Dec 09, 2020 at 08:02:30AM +0200, Eli Cohen wrote: > > > > On Tue, Dec 08, 2020 at 0

Re: [PATCH] vdpa/mlx5: Use write memory barrier after updating CQ index

2020-12-09 Thread Michael S. Tsirkin
On Wed, Dec 09, 2020 at 08:58:46AM +0200, Eli Cohen wrote: > On Wed, Dec 09, 2020 at 01:46:22AM -0500, Michael S. Tsirkin wrote: > > On Wed, Dec 09, 2020 at 08:02:30AM +0200, Eli Cohen wrote: > > > On Tue, Dec 08, 2020 at 04:45:04PM -0500, Michael S. Tsirkin wrote: > > > > On Sun, Dec 06, 2020 at 1

Re: [PATCH] vdpa/mlx5: Use write memory barrier after updating CQ index

2020-12-08 Thread Eli Cohen
On Wed, Dec 09, 2020 at 01:46:22AM -0500, Michael S. Tsirkin wrote: > On Wed, Dec 09, 2020 at 08:02:30AM +0200, Eli Cohen wrote: > > On Tue, Dec 08, 2020 at 04:45:04PM -0500, Michael S. Tsirkin wrote: > > > On Sun, Dec 06, 2020 at 12:57:19PM +0200, Eli Cohen wrote: > > > > Make sure to put write me

Re: [PATCH] vdpa/mlx5: Use write memory barrier after updating CQ index

2020-12-08 Thread Michael S. Tsirkin
On Wed, Dec 09, 2020 at 08:02:30AM +0200, Eli Cohen wrote: > On Tue, Dec 08, 2020 at 04:45:04PM -0500, Michael S. Tsirkin wrote: > > On Sun, Dec 06, 2020 at 12:57:19PM +0200, Eli Cohen wrote: > > > Make sure to put write memory barrier after updating CQ consumer index > > > so the hardware knows th

Re: [PATCH] vdpa/mlx5: Use write memory barrier after updating CQ index

2020-12-08 Thread Eli Cohen
On Tue, Dec 08, 2020 at 04:45:04PM -0500, Michael S. Tsirkin wrote: > On Sun, Dec 06, 2020 at 12:57:19PM +0200, Eli Cohen wrote: > > Make sure to put write memory barrier after updating CQ consumer index > > so the hardware knows that there are available CQE slots in the queue. > > > > Failure to

Re: [PATCH] vdpa/mlx5: Use write memory barrier after updating CQ index

2020-12-08 Thread Michael S. Tsirkin
On Sun, Dec 06, 2020 at 12:57:19PM +0200, Eli Cohen wrote: > Make sure to put write memory barrier after updating CQ consumer index > so the hardware knows that there are available CQE slots in the queue. > > Failure to do this can cause the update of the RX doorbell record to get > updated before

Re: [PATCH] vdpa/mlx5: Use write memory barrier after updating CQ index

2020-12-08 Thread Michael S. Tsirkin
On Tue, Dec 08, 2020 at 11:15:00AM +0200, Eli Cohen wrote: > On Mon, Dec 07, 2020 at 10:51:44AM +0800, Jason Wang wrote: > > > > On 2020/12/6 下午6:57, Eli Cohen wrote: > > > Make sure to put write memory barrier after updating CQ consumer index > > > so the hardware knows that there are available C

Re: [PATCH] vdpa/mlx5: Use write memory barrier after updating CQ index

2020-12-08 Thread Eli Cohen
On Mon, Dec 07, 2020 at 10:51:44AM +0800, Jason Wang wrote: > > On 2020/12/6 下午6:57, Eli Cohen wrote: > > Make sure to put write memory barrier after updating CQ consumer index > > so the hardware knows that there are available CQE slots in the queue. > > > > Failure to do this can cause the upda

Re: [PATCH] vdpa/mlx5: Use write memory barrier after updating CQ index

2020-12-06 Thread Jason Wang
On 2020/12/6 下午6:57, Eli Cohen wrote: Make sure to put write memory barrier after updating CQ consumer index so the hardware knows that there are available CQE slots in the queue. Failure to do this can cause the update of the RX doorbell record to get updated before the CQ consumer index resu

[PATCH] vdpa/mlx5: Use write memory barrier after updating CQ index

2020-12-06 Thread Eli Cohen
Make sure to put write memory barrier after updating CQ consumer index so the hardware knows that there are available CQE slots in the queue. Failure to do this can cause the update of the RX doorbell record to get updated before the CQ consumer index resulting in CQ overrun. Change-Id: Ib0ae4c11